1704777 - The file Path is missing from modals on local files

Status: VERIFIED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect, P2)

Description

[Rares Doghi, Desktop QA]

Attachment: path_Missing.mp4

[Affected platforms]:
Platforms: Windows, Ubuntu, Mac OSX

[Steps to reproduce]

1. Launch the Firefox browser.
2. Add a local file where you can trigger a Javascript Modal.
3. Trigger the Modal.

[Expected result]
The Path for the file should be displayed in the title as well as in the modals content.

[Actual result]
The file Path is missing from the modals on local files

Comment 1

[Neil Deakin]

Attachment: Bug 1704777, fix typo in prepath so that file uris appear in modal prompt titles, r=gijs

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e569ec3e42c
fix typo in prepath so that file uris appear in modal prompt titles, r=Gijs

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/4e569ec3e42c

Comment 4

[Rares Doghi, Desktop QA]

Hi Gijs can you please take a look at this issue ? The File Path only shows the "file://" not the entire path, is this ok ? also the body text from the modal still has the text: "Allow notifications like this from to take you to their tab" and I think the "Allow notifications like this from file:// to take you to their tab" is the correct one ? shouldnt the file:// text be added to that checkbox label ? Ill attach a screenshot.

Comment 5

[Rares Doghi, Desktop QA]

Attachment: Modals.png

Comment 6

[:Gijs (he/him)]

(In reply to Rares Doghi from comment #4)

Hi Gijs can you please take a look at this issue ? The File Path only shows the "file://" not the entire path, is this ok ?

Yeah, I can live with this. It might be nice to show a local file path in the platform-appropriate way (backslashes on Windows!) but I really don't think optimizing file:// pages should be super high on the agenda. Maybe file an enhancement request for this.

(Really, we need a single utility to transform a principal or URI into a reasonable user-facing string rather than having to keep re-inventing this wheel, but that's another topic...)

also the body text from the modal still has the text: "Allow notifications like this from to take you to their tab" and I think the "Allow notifications like this from file:// to take you to their tab" is the correct one ? shouldnt the file:// text be added to that checkbox label ? Ill attach a screenshot.

Ugh. Yeah, that should be a separate bug (ie second follow-up, not the same as the previous point) that we should probably prioritize slightly more highly given that the current state is actually not useful.

Thanks for checking this so quickly.

Comment 7

[Rares Doghi, Desktop QA]

Added Bug 1707208 and the enhancement Bug 1707212 as separate issues.

This issue is verified as fixed in our latest Nightly build. Will this be uplifted to beta ?

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:enndeakin, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 9

[Neil Deakin]

Comment on attachment 9217280 [details]
Bug 1704777, fix typo in prepath so that file uris appear in modal prompt titles, r=gijs

Beta/Release Uplift Approval Request

• User impact if declined: It isn't too important, but just fixes a typo, so has no real risk. The impact is that users opening a local file that opens a dialog box won't see a title.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): no risk
• String changes made/needed: none

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9217280 [details]
Bug 1704777, fix typo in prepath so that file uris appear in modal prompt titles, r=gijs

Approved for 89 beta 6, thanks.

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/cfaec059ab5b

Comment 12

[Rares Doghi, Desktop QA]

This issue is Verified as fixed in our latest Beta 89.0b6 on Windows, Mac and Ubuntu.