1706593 - nsIPrincipal and nsIURI have differently-cased `prePath` idl members which causes bugs

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[:Gijs (he/him)]

With the effort to stop people accessing nsIPrincipal::URI, a lot of properties were put on nsIPrincipal instead. The prePath URI property is now prepath (note: all-lowercase) on nsIPrincipal. This is confusing. It should match the capitalization of the URI property.

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Basti, any chance you could fix that? Should be an easy fix.

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Basti, I am assigning to you - should be an easy fix - thank you!

Comment 3

[Daniel Veditz [:dveditz]]

There appear to be two code uses of this already that will have to be fixed also (plus tests):
https://searchfox.org/mozilla-central/search?q=prepath&path=&case=true&regexp=false

(could be more, that was just a quick search)

Comment 4

[Christoph Kerschbaumer [:ckerschb]]

Let me iron that out real quick ...

Comment 5

[Christoph Kerschbaumer [:ckerschb]]

Attachment: Bug 1706593: Update prePath to camel case in nsIPrincipal.idl

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/293a97df5df8
Update prePath to camel case in nsIPrincipal.idl r=Gijs

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/293a97df5df8

Comment 8

[:Gijs (he/him)]

Christoph: just to clarify, I checked and this doesn't in fact help with bug 1707208 :-( , so you can avoid spending time on getting this uplifted to 89. :-)

Comment 9

[Christoph Kerschbaumer [:ckerschb]]

(In reply to :Gijs (he/him) from comment #8)

Christoph: just to clarify, I checked and this doesn't in fact help with bug 1707208 :-( , so you can avoid spending time on getting this uplifted to 89. :-)

Arh, that's unfortunate - thanks for checking though!