Closed Bug 1704875 Opened 5 years ago Closed 5 years ago

Don't synthesize events on menus in browser/components/extensions/test/browser/head.js

Categories

(WebExtensions :: General, task)

task

Tracking

(firefox89 fixed)

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(2 files)

No description provided.

This test checks that the mouse button is correctly propagated when clicking menu items.
Now that the closeExtensionContextMenu helper function uses activateItem, the mouse
button is discarded and this test fails. I have filed bug 1704879 for the activateItem
limitation.
As a workaround, temporarily change this test to manually synthesize events.
This will allow us to land the head.js patch without breaking the test for non-native menus.
Once bug 1704879 is fixed, we can revert this patch again.

Depends on D111673

See Also: → 1704883
Attachment #9215566 - Attachment description: Bug 1704875 - For now, keep synthesizing events on menus in browser_ext_menus_capture_secondary_click.js. r=robwu → Bug 1704875 - For now, keep synthesizing events on menus if a mouse button is set. r=robwu
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/7ac3b6ec22fb Don't synthesize events on menus in browser/components/extensions/test/browser/head.js. r=robwu https://hg.mozilla.org/integration/autoland/rev/e48984c73090 For now, keep synthesizing events on menus if a mouse button is set. r=robwu
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: