Remove JSID_IS_ATOM from js/src/vm/JSFunction.cpp
Categories
(Core :: JavaScript Engine, enhancement, P5)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | fixed |
People
(Reporter: mgaudet, Assigned: bukky.akinnadeju17, Mentored)
References
Details
(Keywords: good-first-bug)
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1703596 +++
Note: this bug is currently reserved for Outreachy applicants for the Spring/Summer 2021 cycle. If it has not been completed by the end of the application cycle, we will open it up.
Background
The JSID_IS_ATOM calls reflect an old style of SpiderMonkey programming that we think we can start to get away from, internally to the engine.
This Bug
This bug is about removing uses of JSID_IS_ATOM within the js/src/vm/JSFunction.cpp file. Instead of using JSID_IS_ATOM we should be using JS::PropertyKey::isAtom, which is actually how JSID_IS_ATOM is implemented.
Prerequisites
Before getting started, you'll want to
- You Have a checkout of the Firefox source code
- Make sure you can build and test SpiderMonkey
- Read this walkthrough about how development works in Firefox
How you’ll know you’re done
- The use of
JSID_IS_ATOMis removed - SpiderMonkey builds
- The tests run successfully.
Bonus:
- If you happen to see nearby uses of
JSID_TO_ATOM, we should also remove those.
Getting Help
Feel free to leave comments on this bug for questions, or, if you have more synchronous questions about this bug, feel free to drop into the #spidermonkey channel on chat.mozilla.org.
Tips:
- Not sure if the code you've been editing is getting run? Insert a call to
MOZ_CRASH, a macro which will crash when executed, and run the entire test suite with an optimized build (for speed). If you see crashes, you can then use a debug build to make sure it's crashing in your code!
|
Assignee | |
Comment 1•3 years ago
|
||
Hi Mathew,
I'm definitely taking a peek at this, thanks for recommending.
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
||
Updated•3 years ago
|
Pushed by mgaudet@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/22bb8aeff546 Remove JSID_IS_ATOM from js/src/vm/JSFunction.cpp. r=mgaudet
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Description
•