1705034 - Update EMECleaner to support clearing partitioned storage

Status: RESOLVED FIXED

(Toolkit :: Data Sanitization, task)

Description

[Emma Zühlcke [:emz]]

Storage that needs to be cleared: https://bugzilla.mozilla.org/show_bug.cgi?id=1646215#c5

Comment 1

[Stefan Zabka (:vringar)]

Writing down my thoughts for further reference:

1. The module has a three step dance when forgetting a site
   1. GeckoMediaPluginServiceParent::ForgetThisSite
   2. GeckoMediaPluginServiceParent::ForgetThisSiteNative
   3. GeckoMediaPluginServiceParent::ForgetThisSiteOnGMPThread
2. The actual matching against the OriginAttributesPattern and the site happens in MatchOrigin
3. Since all work seems to happen on the GMPThread it seems unwise to just abuse getStorageDir

My conclusion:

We should perform the same three step dance and define our own MatchBaseDomain filter function that checks for a given base domain if either the site is a subdomain of the base domain or if the originAttributes base domain is the same as our base domain.

Comment 2

[Stefan Zabka (:vringar)]

Attachment: Bug 1705034 - Implemented ForgetThisBaseDomain in GMPServiceParent. r=bryce

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bf78f953aac
Implemented ForgetThisBaseDomain in GMPServiceParent. r=pbz,bryce

Comment 4

[Atila Butkovits]

Backed out for causing Gtest failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/c44b8cb709e120ea64f093647b809cb800df8817

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=efxyv2CSQ52xL-gYsOGjbQ.0&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Ctest-linux1804-64%2Fdebug-gtest-1proc%2Cgtest&revision=0bf78f953aacfc995d19fb4e29afbc822289d23d

Failure log: https://treeherder.mozilla.org/logviewer?job_id=344493409&repo=autoland&lineNumber=31682

Comment 5

[Stefan Zabka (:vringar)]

Okay, creating the test directory on the GMP thread failed, because you can't call dirsvc::get on non-main threads.
That's why I moved the TestMatchBaseDomain tests out of the CDMStorageTest and instead have them be free standing functions running on the main thread.
With these modifications they are passing on my machine again and this try run is currently running all GTests to ensure they also pass on other architectures.
Once they have passed the patch is ready to be relanded.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98a3f624dd08
Implemented ForgetThisBaseDomain in GMPServiceParent. r=pbz,bryce

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/98a3f624dd08