1705048 - [Wayland] Sharing indicator is in new window

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect, P1)

Description

[Jan Vlug]

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:87.0) Gecko/20100101 Firefox/87.0

Steps to reproduce:

1. On a system with microphone and webcam attached on a GNOME Wayland session go to https://meet.jit.si and open a meeting.
2. Firefox asks for permission to use the microphone and webcam.
3. Grant permission

Actual results:

A small new Firefox windows appears with the title Firefox - Sharing Indicator. This small window shows that the camera and microphone are in use.

Expected results:

The sharing indicator should appear on top of the desktop (or somewhere else) but preferably not in a new window that sometimes get out if sight behind other windows. In Xorg the indicator is visible at the top of the window or desktop.

Comment 1

[Jan Vlug]

See also bug 1628431.

Comment 2

[Jan Vlug]

Attachment: Screenshot of the small Sharing Indicator window

I attached a screenshot of the small Sharing Indicator window. Note that it is also partially transparent. When this window is resized the transparency disappears.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 4

[dschridde+mozilla]

I believe this could be a duplicate of bug #1628431.

Comment 5

[Olivier Tilloy]

Also reported downstream in Ubuntu (Ubuntu 21.04, released last week, ships with a Wayland session by default): https://bugs.launchpad.net/firefox/+bug/1925837

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1705048 [Wayland] Emulate X11 popup parentless window as a toplevel on Wayland, r?jhorak

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f8208b4e636
[Wayland] Emulate X11 popup parentless window as a toplevel on Wayland, r=jhorak

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1f8208b4e636

Comment 9

[dschridde+mozilla]

(In reply to Pulsebot from comment #7)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f8208b4e636
[Wayland] Emulate X11 popup parentless window as a toplevel on Wayland,
r=jhorak

Thanks, Martin! Does this mean bug #1628431 is also fixed?

Comment 10

[Martin Stránský [:stransky] (ni? me)]

(In reply to devurandom from comment #9)

(In reply to Pulsebot from comment #7)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f8208b4e636
[Wayland] Emulate X11 popup parentless window as a toplevel on Wayland,
r=jhorak

Thanks, Martin! Does this mean bug #1628431 is also fixed?

Please try that. The windows is still created as toplevel but it has disabled decorations. We can't create it as popup as it does not have a parent window. Bug 1703073 will have huge popup redesign and we should apply correct popup roles when it's fixed.

Comment 11

[Catalin Sasca, Desktop QA [:csasca]]

I was able to reproduce the window issue on Firefox 87.0b5 wayland session under Ubuntu 20.04 by following the info provided in Comment 0.

The issue is fixed and the indicator appeared on the left side of the screen on Firefox 90.0b5 on the same system.

Comment 12

[leonhenrik.plickat]

I wonder if it makes more sense to expose the sharing state and controls via DBus and let the desktop environment handle displaying an indicator.

That would solve this issue entirely. Currently there is no universal way for Wayland clients to directly position views (layer-shell does it but is but non-standardized), but with a DBus interface, the desktop can take of this in a way that fits better into the environment. As an example, the desktop could show the indicator as a new widget visually similar to what Firefox does on non-Wayland desktops, or it could also place it into the status area of the panel.