1705200 - Improve contrast on the download details "blocked" text

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, task, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

I think this is a matter of changing --downloads-item-font-size-factor to something like 0.8 when Proton is enabled. Whatever value gets us closest to the spec with the default font size.

Prathiksha, do you have time to look at this?

Comment 1

[:prathiksha]

(In reply to Mike Conley (:mconley) (:⚙️) (Catching up on needinfos) from comment #0)

Prathiksha, do you have time to look at this?

Sorry Mike, I do not. I'm in the middle of wrapping up my existing commitments before my 2 week PTO begins.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1705200 - Converge on 0.8em for Downloads Panel item font size factor. r?Itiel!

Depends on D113192

Comment 3

[Tyler Duzan]

Was this affected by the broader font size changes that are slated to be reverted?

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Yes, the Downloads Panel was affected by the panel and modal font size change in bug 1701920. However, I suspect the work in bug 1703014 also made it so that the text under the filename ended up with the same relative font size as the filename.

Comment 5

[Molly Howell (she/her) (mostly inactive)]

Attachment: size_comparison.png

Currently we are getting the 10% reduction from --downloads-item-font-size-factor, so the details text is slightly smaller (12px vs. 10.8px) than the filename text. Figma shows the two lines at 13px and 10px, so a wider range between the two. But the filename text size we have now matches the body text for other panels/menus, so changing that just here doesn't seem like the right move? And this comment in the abandoned patch looks correct; lowering the scale factor to make the details text 10px makes it look really small to me. I've attached a screenshot comparing the current state against that change.
So I'm not sure we really should try to change either font size, which would mean we don't have anything to do for this bug. Janice, can I get your thoughts?

Comment 6

[Janice Cramer]

(In reply to Molly Howell (she/her) [:mhowell] from comment #5)

Created attachment 9237585 [details]
size_comparison.png

Currently we are getting the 10% reduction from --downloads-item-font-size-factor, so the details text is slightly smaller (12px vs. 10.8px) than the filename text. Figma shows the two lines at 13px and 10px, so a wider range between the two. But the filename text size we have now matches the body text for other panels/menus, so changing that just here doesn't seem like the right move? And this comment in the abandoned patch looks correct; lowering the scale factor to make the details text 10px makes it look really small to me. I've attached a screenshot comparing the current state against that change.
So I'm not sure we really should try to change either font size, which would mean we don't have anything to do for this bug. Janice, can I get your thoughts?

Molly, I agree that the body text should stay consistent—are there any options to increase it across the board to 13px, or was that a decision made w/ Katie to keep it closer to 12px?

On another note, I'm noticing that the contrast of the red text : background seems low. Do you know if that was tested for accessibility?

Comment 7

[Molly Howell (she/her) (mostly inactive)]

Yeah, the text size was a specific decision that was made a while back. I wasn't directly involved and I don't know the details, but initially in Proton we were using a larger size globally, and I think it was changed mainly to match the OS default (so that OS font size settings are reflected properly) and to reduce incidence of menus having to scroll on lower screen resolutions.

You're right about the contrast, thanks for pointing that out. There's actually some transparency being applied to that text, which I think is intended for the download status text, but I really don't think should be getting applied to these error messages. I'll see about fixing that.

Comment 8

[Molly Howell (she/her) (mostly inactive)]

Attachment: Bug 1705200 - Improve contrast on the download details "blocked" text. r=#desktop-theme-reviewers

This bug was originally about changing the size of this text, but we aren't
really able to do that. We are however able to improve its legibility by giving
it some additional contrast against the background.

Based on the specs (and also on intuition, to be honest), I believe only the
"normal" download status text should be getting any reduced opacity, and the
error message states should not. So this patch undoes the opacity reduction in
the error states.

Comment 9

[Janice Cramer]

Thanks for giving text size decision context.

Sounds good re opacity. Thank you, Molly!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5a18fe5fd51
Improve contrast on the download details "blocked" text. r=desktop-theme-reviewers,dao

Comment 11

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/a5a18fe5fd51

Comment 12

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is verified fixed in Fx93.0b7 on windows 10, ubuntu 20.04 and macOS 10.15. The change to the contrast is very subtle but visible.