1703014 - Downloads Panel is missing a number of Proton styles

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, task, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

Quoting UX from their review:

At the current state, the download panel is so far off from the visual refresh  proposed that it doesn’t allow us to start the review.

The following bullets should be interpreted as P1. 

* Missing padding top
* Still has icons in the sub-panel
* Badge and icons are not matching, providing a confusing experience
* The footer buttons behaves unexpectedly, spreading for the full width of the panel.
*Font-size is small and hierarchy of text is off. Making this sub-panel hard to read an scan.

tduzan, UX considers the above work P1 and should block MR1. Do you concur?

Comment 1

[Tyler Duzan]

I largely agree with the UX feedback here. During my PM review of MR1, when I got to the downloads panel it felt halfway styled to me. I wasn't sure if we had descoped part of this, or not, but based on this feedback it sounds like we did not. I'd like to see this fixed before we ship. An additional item not noted above is that the downloads panel is also misaligned to its button. I'm comfortable saying this is a P1. There is quite a bit of visual work needed here still, and it seemed somewhat jarring.

Comment 2

[Tyler Duzan]

I'm actually marking this p2a, but will make a note to follow-up on this with Romain tomorrow to discuss priority. I don't want to bump this to P1 without discussing with him first.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Here's a site where one can download benign test files that show up in those special states in the downloads panel: https://testsafebrowsing.appspot.com/

See the "Desktop Download Warnings"

Comment 4

[:prathiksha]

Attachment: Bug 1703014 - Update the downloads panel footer string. r=mconley!

Comment 5

[:prathiksha]

Attachment: Bug 1703014 - Update layout in the downloads panel main view to match proton styles. r=mconley!

Depends on D111131

Comment 7

[:prathiksha]

Attachment: Bug 1703014 - Update hover and active effects in the downloads panel mainview for Proton. r=mconley!

Depends on D111132

Comment 8

[:prathiksha]

Attachment: Bug 1703014 - Update button layout in the downloads subpanel for Proton. r=mconley!

Depends on D111290

Comment 9

[:prathiksha]

Attachment: Bug 1703014 - Update badge placement and icons in the downloads panel to match proton styles. r=mconley!

Depends on D111408

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e37a637126c7
Update the downloads panel footer string. r=mconley,fluent-reviewers,flod

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e37a637126c7

Comment 14

[Mike Conley (:mconley) (:⚙️)]

A few patches left to land here before we close this out. Reopening.

Comment 15

[:prathiksha]

Attachment: Bug 1703014 - Position the downloads button to match proton styles. r=mconley!

Depends on D111409

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14b567c6f349
Update layout in the downloads panel main view to match proton styles. r=mconley,desktop-theme-reviewers,harry
https://hg.mozilla.org/integration/autoland/rev/eb3635cd3bae
Update hover and active effects in the downloads panel mainview for Proton. r=mconley,desktop-theme-reviewers,harry
https://hg.mozilla.org/integration/autoland/rev/7982342bb3a1
Update button layout in the downloads subpanel for Proton. r=mconley,desktop-theme-reviewers,harry
https://hg.mozilla.org/integration/autoland/rev/0c1add0307f9
Update badge placement and icons in the downloads panel to match proton styles. r=mconley,desktop-theme-reviewers,harry
https://hg.mozilla.org/integration/autoland/rev/76f152242b12
Position the downloads button to match proton styles. r=mconley,desktop-theme-reviewers,harry

Comment 17

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/14b567c6f349
https://hg.mozilla.org/mozilla-central/rev/eb3635cd3bae
https://hg.mozilla.org/mozilla-central/rev/7982342bb3a1
https://hg.mozilla.org/mozilla-central/rev/0c1add0307f9
https://hg.mozilla.org/mozilla-central/rev/76f152242b12

Comment 18

[:prathiksha]

I think this bug can now be resolved if all patches have been merged to central :)

Comment 19

[Oana Botisan, Desktop QA]

Attachment: image (1).png

We found some differences between the specs and the fix in the Dowload details panel:

• There is no spacing between "This file..." subtitle and the rest of the text.
• There is a spacing between the two frases.
• The text ocupies a bigger space on the panel.

Are these changes expected?

Comment 20

[Oana Botisan, Desktop QA]

Attachment: image.png

This is the image we got from the specs.

Comment 21

[Ciprian Georgiu, Desktop QA]

Can you please help us :prathiksha, clarifying the above?

Comment 22

[Blake Winton (:bwinton) (:☕️)]

I asked UX, and they said that it should look like the spec in comment 20.
(Perhaps we should file a follow-up bug for those changes, so that they can be prioritized correctly by UX/PM…)