1705202 - Add FTP related protocols to the registerProtocolHandler safelist.

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P2)

Description

[Asanka Herath]

As a part of removing FTP support in Chromium (and in turn Google Chrome, Edge, etc.) I'd like to release ftp, sftp, ftps protocols as being registrable via registerProtocolHandler.

ChromeStatus entry is here: https://www.chromestatus.com/feature/5762628536238080

I'll follow up with relevant PR to whatwg/html and wpt.

Blink I2S thread is https://groups.google.com/a/chromium.org/g/blink-dev/c/ABhlioapE0E/m/gXL84wPfAAAJ . Please express your support objections here or there as appropriate.

Comment 1

[Asanka Herath]

Related whatwg/html issue : https://github.com/whatwg/html/issues/6583

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Hi Asanka. You should file an issue on https://github.com/mozilla/standards-positions/issues to get a position on this topic.
I'll keep this bug for necessary changes if we reach a decision.

Comment 3

[Asanka Herath]

Thank! Did so. https://github.com/mozilla/standards-positions/issues/513

Comment 4

[Anne (:annevk)]

Ah, I saw this after the GitHub issue. 😊 This seems reasonable to me now FTP is no longer a scheme the browser handles.

Comment 5

[Rob Wu [:robwu]]

FYI: The protocol_handlers extension API supports ftp since bug 1626365 (https://hg.mozilla.org/mozilla-central/rev/bcdf1f609632#l3.2).

Comment 6

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1705202 - Add FTP related protocols to the registerProtocolHandler safelist. r=#necko,annevk!

Comment 7

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1705202 - Strip user & password from FTP schemes when going through webhandler r=Gijs

According to https://github.com/mozilla/standards-positions/issues/513
the safe thing to do for FTP URLs when using a protocol handler is to strip
the credentials from them first.

This also adds a test that makes sure credentials are stripped when using
a web protocol handler.

Depends on D136121

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b52cf82fbe03
Add FTP related protocols to the registerProtocolHandler safelist. r=annevk
https://hg.mozilla.org/integration/autoland/rev/882c7f9567cd
Strip user & password from FTP schemes when going through webhandler r=Gijs

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b52cf82fbe03
https://hg.mozilla.org/mozilla-central/rev/882c7f9567cd

Comment 10

[Hamish Willee]

FF98 docs work for this can be tracked in https://github.com/mdn/content/pull/12790

I see from https://github.com/whatwg/html/issues/6583#issue-858243907 that this change is currently non-spec. Will this bugfix remain in the release even if the PR is not accepted?
This will affect how the browser compatibility and MDN documents are updated.

Comment 11

[Valentin Gosu [:valentin] (he/him)]

Presumably this change will be backed out if the PR gets rejected, but that's unlikely given this is a widely supported change.

Comment 12

[Hamish Willee]

Thanks! The spec got updated. I have marked as dev-doc-complete. The browser compatibility update is still in discussion though (you can follow that through issue linked in https://github.com/mdn/content/pull/12790)