1705254 - Proton context menu has a misaligned corner border

Status: NEW

(Firefox :: Menus, defect, P2)

Description

[Ivar Hill]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

Right-click any element that open the new Proton context menu. Testing on Windows 10, not sure about other platforms.

Actual results:

The bottom right corner has its border misaligned - the radius of the border seems to be 1px smaller than the radius of the actual context menu background, resulting in a small gap in the corner.

Most likely this issue is actually occurring in all corners, but only visible in the bottom right due to the drop shadow being there.

Expected results:

The context menu border should have its radius match the actual context menu background, making it flush with the edge and look as expected.

Comment 1

[Ivar Hill]

Attachment: Left side: Issue with bottom-right corner of context menu. Right side: The expected appearance.

Comment 2

[Ivar Hill]

Attachment: Magnified. Left side: Issue with bottom-right corner of context menu. Right side: The expected appearance.

Comment 3

[Ivar Hill]

Attachment: Dark theme has the same issue. Left side: Issue with bottom-right corner of context menu. Right side: The expected appearance.

Comment 4

[Ivar Hill]

For clarification, this happens regardless of DPI - tested on 100% and 125%. It's easiest to notice the issue when the context menu is against a pure white background.

Comment 5

[Ivar Hill]

Attachment: Clearer comparison of the issue (on left) vs. expected appearance (on right).

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Menus' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 7

[Tracy Walker [:tracy]]

Not sure if this is to Proton spec or not. Bogdan, can you take a look?

Comment 8

[Bogdan Maris, Desktop QA]

Attachment: Zoomed with magnifier glass

(In reply to Tracy Walker [:tracy] from comment #7)

Not sure if this is to Proton spec or not. Bogdan, can you take a look?

I used magnifier glass and print screen and zoom inside paint to try and replicate the image from comment 2 these are the images I get.

Comment 9

[Bogdan Maris, Desktop QA]

Attachment: Zoom with paint3D

Screenshot using paint3D and zoomed. I for one am not sure if this is per spec or not, maybe Gijs could give a better answer.

Comment 10

[:Gijs (he/him)]

I think bug 1704040 might help here, but on the whole this is tricky because the shadow is rendered by Windows and the border by us, and getting the two perfectly aligned across DPIs, with rounded corners, has been a little... interesting.

I have to admit that in the non-zoomed-in images, I can't really see the two pixel difference... the issue in bug 1704040 is much more noticeable, however.