1705389 - View source requires new HTTP authentication

Status: UNCONFIRMED

(Core :: Networking, defect, P2)

Description

[Martin F.]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:87.0) Gecko/20100101 Firefox/87.0

Steps to reproduce:

• Open web page requiring HTTP authentication
• Enter valid user and password, page is displayed
• View source

Actual results:

User and password have to be entered again

Expected results:

Firefox should use the login data previously entered

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Password Manager' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Dimi Lee [:dimi]]

To make sure I understand the problem correctly, I'll give a short summary.
In my test, If we choose to save the username and password in the web page requiring HTTP authentication, after the view-source tab is opened, an authentication dialog appears again, and the username and password are filled.

The problem is about we should use the credential saved in the first prompt so the view-source tab is displayed without the prompt.
This problem is not whether the username and password are filled in the second prompt.
Martin, please correct me if I'm wrong.

Comment 3

[Martin F.]

Right. After authenticating in the first tab, the view source tab should not display a login prompt at all. I have not stored the credentials in the password manager, nonetheless I expect the view source tab to be working without entering the login data again.

Comment 4

[Valentin Gosu [:valentin] (he/him)]

This seems to have been regressed by bug 1651134.
Setting privacy.partition.network_state to false fixes the issue.

Comment 7

[Valentin Gosu [:valentin] (he/him)]

I think here we need to have a special case for view-source channels where use get the inner channel origin.
https://searchfox.org/mozilla-central/rev/02a4a649ed75ebaf3fbdf301c3d3137baf6842a1/netwerk/protocol/http/nsHttpChannelAuthProvider.cpp#71-80