White flash before showing about:home for the first time
Categories
(Firefox :: New Tab Page, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox89 | --- | fixed |
People
(Reporter: alexical, Assigned: Mardak)
References
Details
Attachments
(1 file)
Either the new tab page needs updating to the Proton in-content colors, which AIUI is a white background, or we need to back out bug 1693819. Ed, do you know what the plan is here for the new tab page background color?
Assignee | ||
Comment 1•4 years ago
|
||
I believe the page uses --newtab-background-color
which a theme can set via ntp_background
that does get set in the packaged themes:
https://searchfox.org/mozilla-central/rev/5e70cd673a0ba0ad19b662c1cf656e0823781596/browser/themes/addons/light/manifest.json#39
So is the ask to have new tab page use in-content background and ignore the active theme's colors? If so, Scott any plans?
dthayer, does this change any with bug 1701691, which I believe cleans up some mismatch between OS/firefox-theme selecting light/dark?
Reporter | ||
Comment 2•4 years ago
|
||
(In reply to Ed Lee :Mardak from comment #1)
I believe the page uses
--newtab-background-color
which a theme can set viantp_background
that does get set in the packaged themes:
https://searchfox.org/mozilla-central/rev/5e70cd673a0ba0ad19b662c1cf656e0823781596/browser/themes/addons/light/manifest.json#39So is the ask to have new tab page use in-content background and ignore the active theme's colors? If so, Scott any plans?
I honestly don't know the plan here and I don't know who does know. I just know there is now a white flash between the skeleton UI's light grey and about:home's light grey :(. Romain, would you happen to be able to elucidate on whether we want about:home to match the in-content styling with a white background?
dthayer, does this change any with bug 1701691, which I believe cleans up some mismatch between OS/firefox-theme selecting light/dark?
Briefly glancing at it, no I don't think it does.
Comment 3•4 years ago
|
||
@ed I am no aware of any plans by myself or others in regards to background colours on newtab.
Comment 5•4 years ago
|
||
(In reply to Ed Lee :Mardak from comment #1)
I believe the page uses
--newtab-background-color
which a theme can set viantp_background
that does get set in the packaged themes:
https://searchfox.org/mozilla-central/rev/5e70cd673a0ba0ad19b662c1cf656e0823781596/browser/themes/addons/light/manifest.json#39So is the ask to have new tab page use in-content background and ignore the active theme's colors? If so, Scott any plans?
The issue is that the defaults for --newtab-background-color
used to match the default in-content page background colour defined in common.inc.css , but they don't anymore with proton.
To fix this bug, we just need to add some CSS such that the colours match when proton is enabled. I don't know if you can use the proton media queries in about:newtab; if not, you could use a root attribute to change the value of that CSS var when not overridden by custom themes.
Assignee | ||
Comment 6•4 years ago
|
||
(In reply to :Gijs (he/him) from comment #5)
To fix this bug, we just need to add some CSS such that the colours match when proton is enabled. I don't know if you can use the proton media queries in about:newtab; if not, you could use a root attribute to change the value of that CSS var when not overridden by custom themes.
A quick test does seem to show @media (-moz-proton) {
works on about:newtab. So your approach seems reasonable to prevent this variable from getting used:
https://searchfox.org/mozilla-central/rev/5e70cd673a0ba0ad19b662c1cf656e0823781596/browser/components/newtab/content-src/styles/_theme.scss#26
Is this just light theme with proton enabled? Or also dark proton does not match #2A2A2E
from system dark theme?
https://searchfox.org/mozilla-central/rev/5e70cd673a0ba0ad19b662c1cf656e0823781596/toolkit/mozapps/extensions/default-theme/manifest.json#41
Comment 7•4 years ago
|
||
(In reply to Ed Lee :Mardak from comment #6)
Is this just light theme with proton enabled? Or also dark proton does not match
#2A2A2E
from system dark theme?
https://searchfox.org/mozilla-central/rev/5e70cd673a0ba0ad19b662c1cf656e0823781596/toolkit/mozapps/extensions/default-theme/manifest.json#41
It does not, https://hg.mozilla.org/mozilla-central/rev/f5df9fe05c93#l1.40 is slightly different. Sounds like for that we could/should just update that manifest file though. Jared, does that seem right?
Comment 8•4 years ago
•
|
||
Yes, but you will need to update both default-theme/manifest.json
and dark/manifest.json
too.
Assignee | ||
Comment 9•4 years ago
|
||
Use the values from common.inc.css both light and dark. The theme values will override the page defaults, but not all themes use ntp_.
Updated•4 years ago
|
Comment 10•4 years ago
|
||
Comment 11•4 years ago
|
||
Backed out changeset 068351eb5881 (bug 1705511) for browser_ext_themes_ntp_colors_perwindow.js mochitest failures.
Backout link: https://hg.mozilla.org/integration/autoland/rev/c5d1d6c3377c96d1f04c41b916e9e44fb05fa63f
Failure log: https://treeherder.mozilla.org/logviewer?job_id=336855832&repo=autoland&lineNumber=2760
[task 2021-04-17T01:56:00.190Z] 01:56:00 INFO - TEST-START | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js
[task 2021-04-17T01:56:10.593Z] 01:56:10 INFO - TEST-INFO | started process screentopng
[task 2021-04-17T01:56:10.973Z] 01:56:10 INFO - TEST-INFO | screentopng: exit 0
[task 2021-04-17T01:56:10.973Z] 01:56:10 INFO - Buffered messages logged at 01:56:00
[task 2021-04-17T01:56:10.973Z] 01:56:10 INFO - Entering test bound test_per_window_ntp_theme
[task 2021-04-17T01:56:10.974Z] 01:56:10 INFO - Extension loaded
[task 2021-04-17T01:56:10.974Z] 01:56:10 INFO - Console message: Warning: attempting to write 5563 bytes to preference extensions.webextensions.uuids. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.
[task 2021-04-17T01:56:10.974Z] 01:56:10 INFO - Buffered messages logged at 01:56:02
[task 2021-04-17T01:56:10.974Z] 01:56:10 INFO - Test that single window update works
[task 2021-04-17T01:56:10.974Z] 01:56:10 INFO - Opening url: about:newtab
[task 2021-04-17T01:56:10.974Z] 01:56:10 INFO - Buffered messages logged at 01:56:05
[task 2021-04-17T01:56:10.974Z] 01:56:10 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should have lwt-newtab attribute - true == true -
[task 2021-04-17T01:56:10.976Z] 01:56:10 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should not have lwt-newtab-brighttext attribute - false == false -
[task 2021-04-17T01:56:10.976Z] 01:56:10 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page background should be set. - "rgb(173, 216, 230)" == "rgb(173, 216, 230)" -
[task 2021-04-17T01:56:10.976Z] 01:56:10 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page text color should be set. - "rgb(0, 0, 0)" == "rgb(0, 0, 0)" -
[task 2021-04-17T01:56:10.976Z] 01:56:10 INFO - Opening url: about:home
[task 2021-04-17T01:56:10.976Z] 01:56:10 INFO - Buffered messages logged at 01:56:07
[task 2021-04-17T01:56:10.976Z] 01:56:10 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should have lwt-newtab attribute - true == true -
[task 2021-04-17T01:56:10.977Z] 01:56:10 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should not have lwt-newtab-brighttext attribute - false == false -
[task 2021-04-17T01:56:10.977Z] 01:56:10 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page background should be set. - "rgb(173, 216, 230)" == "rgb(173, 216, 230)" -
[task 2021-04-17T01:56:10.979Z] 01:56:10 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page text color should be set. - "rgb(0, 0, 0)" == "rgb(0, 0, 0)" -
[task 2021-04-17T01:56:10.979Z] 01:56:10 INFO - Opening url: about:welcome
[task 2021-04-17T01:56:10.979Z] 01:56:10 INFO - Buffered messages logged at 01:56:08
[task 2021-04-17T01:56:10.979Z] 01:56:10 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should have lwt-newtab attribute - true == true -
[task 2021-04-17T01:56:10.979Z] 01:56:10 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should not have lwt-newtab-brighttext attribute - false == false -
[task 2021-04-17T01:56:10.982Z] 01:56:10 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page background should be set. - "rgb(173, 216, 230)" == "rgb(173, 216, 230)" -
[task 2021-04-17T01:56:10.982Z] 01:56:10 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page text color should be set. - "rgb(0, 0, 0)" == "rgb(0, 0, 0)" -
[task 2021-04-17T01:56:10.982Z] 01:56:10 INFO - Opening url: about:newtab
[task 2021-04-17T01:56:10.982Z] 01:56:10 INFO - Buffered messages logged at 01:56:10
[task 2021-04-17T01:56:10.982Z] 01:56:10 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should not have lwt-newtab attribute - true == true -
[task 2021-04-17T01:56:10.982Z] 01:56:10 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should not have lwt-newtab-brighttext attribute - true == true -
[task 2021-04-17T01:56:10.982Z] 01:56:10 INFO - Buffered messages finished
[task 2021-04-17T01:56:10.983Z] 01:56:10 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page background should be reset. - "rgb(255, 255, 255)" == "rgb(249, 249, 250)" - got "rgb(255, 255, 255)", expected "rgb(249, 249, 250)" (operator ==)
[task 2021-04-17T01:56:10.983Z] 01:56:10 INFO - Stack trace:
[task 2021-04-17T01:56:10.983Z] 01:56:10 INFO - is@resource://specialpowers/SpecialPowersSandbox.jsm:90:21
[task 2021-04-17T01:56:10.983Z] 01:56:10 INFO - @chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js:112:9
[task 2021-04-17T01:56:10.983Z] 01:56:10 INFO - execute@resource://specialpowers/SpecialPowersSandbox.jsm:141:12
[task 2021-04-17T01:56:10.983Z] 01:56:10 INFO - _spawnTask@resource://specialpowers/SpecialPowersChild.jsm:1604:15
[task 2021-04-17T01:56:10.983Z] 01:56:10 INFO - receiveMessage@resource://specialpowers/SpecialPowersChild.jsm:310:21
[task 2021-04-17T01:56:10.984Z] 01:56:10 INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-04-17T01:56:10.984Z] 01:56:10 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page text color should be reset. - "rgb(21, 20, 26)" == "rgb(12, 12, 13)" - got "rgb(21, 20, 26)", expected "rgb(12, 12, 13)" (operator ==)
[task 2021-04-17T01:56:10.984Z] 01:56:10 INFO - Stack trace:
[task 2021-04-17T01:56:10.984Z] 01:56:10 INFO - is@resource://specialpowers/SpecialPowersSandbox.jsm:90:21
[task 2021-04-17T01:56:10.984Z] 01:56:10 INFO - @chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js:117:9
[task 2021-04-17T01:56:10.984Z] 01:56:10 INFO - execute@resource://specialpowers/SpecialPowersSandbox.jsm:141:12
[task 2021-04-17T01:56:10.984Z] 01:56:10 INFO - _spawnTask@resource://specialpowers/SpecialPowersChild.jsm:1604:15
[task 2021-04-17T01:56:10.984Z] 01:56:10 INFO - receiveMessage@resource://specialpowers/SpecialPowersChild.jsm:310:21
[task 2021-04-17T01:56:10.984Z] 01:56:10 INFO - Opening url: about:home
[task 2021-04-17T01:56:12.468Z] 01:56:12 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should not have lwt-newtab attribute - true == true -
[task 2021-04-17T01:56:12.469Z] 01:56:12 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should not have lwt-newtab-brighttext attribute - true == true -
[task 2021-04-17T01:56:12.469Z] 01:56:12 INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-04-17T01:56:12.469Z] 01:56:12 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page background should be reset. - "rgb(255, 255, 255)" == "rgb(249, 249, 250)" - got "rgb(255, 255, 255)", expected "rgb(249, 249, 250)" (operator ==)
[task 2021-04-17T01:56:12.469Z] 01:56:12 INFO - Stack trace:
[task 2021-04-17T01:56:12.469Z] 01:56:12 INFO - is@resource://specialpowers/SpecialPowersSandbox.jsm:90:21
[task 2021-04-17T01:56:12.469Z] 01:56:12 INFO - @chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js:112:9
[task 2021-04-17T01:56:12.469Z] 01:56:12 INFO - execute@resource://specialpowers/SpecialPowersSandbox.jsm:141:12
[task 2021-04-17T01:56:12.469Z] 01:56:12 INFO - _spawnTask@resource://specialpowers/SpecialPowersChild.jsm:1604:15
[task 2021-04-17T01:56:12.469Z] 01:56:12 INFO - receiveMessage@resource://specialpowers/SpecialPowersChild.jsm:310:21
[task 2021-04-17T01:56:12.510Z] 01:56:12 INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-04-17T01:56:12.510Z] 01:56:12 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page text color should be reset. - "rgb(21, 20, 26)" == "rgb(12, 12, 13)" - got "rgb(21, 20, 26)", expected "rgb(12, 12, 13)" (operator ==)
[task 2021-04-17T01:56:12.511Z] 01:56:12 INFO - Stack trace:
[task 2021-04-17T01:56:12.511Z] 01:56:12 INFO - is@resource://specialpowers/SpecialPowersSandbox.jsm:90:21
[task 2021-04-17T01:56:12.511Z] 01:56:12 INFO - @chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js:117:9
[task 2021-04-17T01:56:12.511Z] 01:56:12 INFO - execute@resource://specialpowers/SpecialPowersSandbox.jsm:141:12
[task 2021-04-17T01:56:12.511Z] 01:56:12 INFO - _spawnTask@resource://specialpowers/SpecialPowersChild.jsm:1604:15
[task 2021-04-17T01:56:12.511Z] 01:56:12 INFO - receiveMessage@resource://specialpowers/SpecialPowersChild.jsm:310:21
[task 2021-04-17T01:56:12.588Z] 01:56:12 INFO - Opening url: about:welcome
[task 2021-04-17T01:56:13.711Z] 01:56:13 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | About:welcome page should not have lwt-newtab attribute - true == true -
[task 2021-04-17T01:56:13.711Z] 01:56:13 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | About:welcome page should not have lwt-newtab-brighttext attribute - true == true -
[task 2021-04-17T01:56:13.714Z] 01:56:13 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | About:welcome page background should be reset. - "rgb(237, 237, 240)" == "rgb(237, 237, 240)" -
[task 2021-04-17T01:56:13.718Z] 01:56:13 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | About:welcome page text color should be reset. - "rgb(12, 12, 13)" == "rgb(12, 12, 13)" -
[task 2021-04-17T01:56:13.935Z] 01:56:13 INFO - Test that applying different themes on both windows
[task 2021-04-17T01:56:14.419Z] 01:56:14 INFO - Opening url: about:newtab
[task 2021-04-17T01:56:16.617Z] 01:56:16 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should have lwt-newtab attribute - true == true -
[task 2021-04-17T01:56:16.618Z] 01:56:16 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should not have lwt-newtab-brighttext attribute - false == false -
[task 2021-04-17T01:56:16.625Z] 01:56:16 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page background should be set. - "rgb(173, 216, 230)" == "rgb(173, 216, 230)" -
[task 2021-04-17T01:56:16.626Z] 01:56:16 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page text color should be set. - "rgb(0, 0, 0)" == "rgb(0, 0, 0)" -
[task 2021-04-17T01:56:16.693Z] 01:56:16 INFO - Opening url: about:home
[task 2021-04-17T01:56:19.205Z] 01:56:19 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should have lwt-newtab attribute - true == true -
[task 2021-04-17T01:56:19.205Z] 01:56:19 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should not have lwt-newtab-brighttext attribute - false == false -
[task 2021-04-17T01:56:19.206Z] 01:56:19 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page background should be set. - "rgb(173, 216, 230)" == "rgb(173, 216, 230)" -
[task 2021-04-17T01:56:19.253Z] 01:56:19 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page text color should be set. - "rgb(0, 0, 0)" == "rgb(0, 0, 0)" -
[task 2021-04-17T01:56:19.296Z] 01:56:19 INFO - Opening url: about:welcome
[task 2021-04-17T01:56:20.566Z] 01:56:20 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should have lwt-newtab attribute - true == true -
[task 2021-04-17T01:56:20.566Z] 01:56:20 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should not have lwt-newtab-brighttext attribute - false == false -
[task 2021-04-17T01:56:20.567Z] 01:56:20 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page background should be set. - "rgb(173, 216, 230)" == "rgb(173, 216, 230)" -
[task 2021-04-17T01:56:20.567Z] 01:56:20 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page text color should be set. - "rgb(0, 0, 0)" == "rgb(0, 0, 0)" -
[task 2021-04-17T01:56:20.718Z] 01:56:20 INFO - Opening url: about:newtab
[task 2021-04-17T01:56:22.618Z] 01:56:22 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should have lwt-newtab attribute - true == true -
[task 2021-04-17T01:56:22.618Z] 01:56:22 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should have lwt-newtab-brighttext attribute - true == true -
[task 2021-04-17T01:56:22.621Z] 01:56:22 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page background should be set. - "rgb(0, 0, 139)" == "rgb(0, 0, 139)" -
[task 2021-04-17T01:56:22.631Z] 01:56:22 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page text color should be set. - "rgb(173, 216, 230)" == "rgb(173, 216, 230)" -
[task 2021-04-17T01:56:22.727Z] 01:56:22 INFO - Opening url: about:home
[task 2021-04-17T01:56:24.472Z] 01:56:24 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should have lwt-newtab attribute - true == true -
[task 2021-04-17T01:56:24.473Z] 01:56:24 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should have lwt-newtab-brighttext attribute - true == true -
[task 2021-04-17T01:56:24.473Z] 01:56:24 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page background should be set. - "rgb(0, 0, 139)" == "rgb(0, 0, 139)" -
[task 2021-04-17T01:56:24.520Z] 01:56:24 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page text color should be set. - "rgb(173, 216, 230)" == "rgb(173, 216, 230)" -
[task 2021-04-17T01:56:24.596Z] 01:56:24 INFO - Opening url: about:welcome
[task 2021-04-17T01:56:25.641Z] 01:56:25 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should have lwt-newtab attribute - true == true -
[task 2021-04-17T01:56:25.641Z] 01:56:25 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should have lwt-newtab-brighttext attribute - true == true -
[task 2021-04-17T01:56:25.642Z] 01:56:25 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page background should be set. - "rgb(0, 0, 139)" == "rgb(0, 0, 139)" -
[task 2021-04-17T01:56:25.659Z] 01:56:25 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page text color should be set. - "rgb(173, 216, 230)" == "rgb(173, 216, 230)" -
[task 2021-04-17T01:56:25.892Z] 01:56:25 INFO - Test resetting the theme on one window
[task 2021-04-17T01:56:26.133Z] 01:56:26 INFO - Opening url: about:newtab
[task 2021-04-17T01:56:28.190Z] 01:56:28 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should not have lwt-newtab attribute - true == true -
[task 2021-04-17T01:56:28.191Z] 01:56:28 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should not have lwt-newtab-brighttext attribute - true == true -
[task 2021-04-17T01:56:28.195Z] 01:56:28 INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-04-17T01:56:28.195Z] 01:56:28 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page background should be reset. - "rgb(255, 255, 255)" == "rgb(249, 249, 250)" - got "rgb(255, 255, 255)", expected "rgb(249, 249, 250)" (operator ==)
[task 2021-04-17T01:56:28.195Z] 01:56:28 INFO - Stack trace:
[task 2021-04-17T01:56:28.195Z] 01:56:28 INFO - is@resource://specialpowers/SpecialPowersSandbox.jsm:90:21
[task 2021-04-17T01:56:28.195Z] 01:56:28 INFO - @chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js:112:9
[task 2021-04-17T01:56:28.195Z] 01:56:28 INFO - execute@resource://specialpowers/SpecialPowersSandbox.jsm:141:12
[task 2021-04-17T01:56:28.195Z] 01:56:28 INFO - _spawnTask@resource://specialpowers/SpecialPowersChild.jsm:1604:15
[task 2021-04-17T01:56:28.195Z] 01:56:28 INFO - receiveMessage@resource://specialpowers/SpecialPowersChild.jsm:310:21
[task 2021-04-17T01:56:28.203Z] 01:56:28 INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-04-17T01:56:28.203Z] 01:56:28 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page text color should be reset. - "rgb(21, 20, 26)" == "rgb(12, 12, 13)" - got "rgb(21, 20, 26)", expected "rgb(12, 12, 13)" (operator ==)
[task 2021-04-17T01:56:28.203Z] 01:56:28 INFO - Stack trace:
[task 2021-04-17T01:56:28.204Z] 01:56:28 INFO - is@resource://specialpowers/SpecialPowersSandbox.jsm:90:21
[task 2021-04-17T01:56:28.204Z] 01:56:28 INFO - @chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js:117:9
[task 2021-04-17T01:56:28.204Z] 01:56:28 INFO - execute@resource://specialpowers/SpecialPowersSandbox.jsm:141:12
[task 2021-04-17T01:56:28.204Z] 01:56:28 INFO - _spawnTask@resource://specialpowers/SpecialPowersChild.jsm:1604:15
[task 2021-04-17T01:56:28.205Z] 01:56:28 INFO - receiveMessage@resource://specialpowers/SpecialPowersChild.jsm:310:21
[task 2021-04-17T01:56:28.266Z] 01:56:28 INFO - Opening url: about:home
[task 2021-04-17T01:56:29.998Z] 01:56:29 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should not have lwt-newtab attribute - true == true -
[task 2021-04-17T01:56:29.999Z] 01:56:29 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should not have lwt-newtab-brighttext attribute - true == true -
[task 2021-04-17T01:56:29.999Z] 01:56:29 INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-04-17T01:56:29.999Z] 01:56:29 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page background should be reset. - "rgb(255, 255, 255)" == "rgb(249, 249, 250)" - got "rgb(255, 255, 255)", expected "rgb(249, 249, 250)" (operator ==)
[task 2021-04-17T01:56:29.999Z] 01:56:29 INFO - Stack trace:
[task 2021-04-17T01:56:29.999Z] 01:56:29 INFO - is@resource://specialpowers/SpecialPowersSandbox.jsm:90:21
[task 2021-04-17T01:56:29.999Z] 01:56:29 INFO - @chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js:112:9
[task 2021-04-17T01:56:29.999Z] 01:56:29 INFO - execute@resource://specialpowers/SpecialPowersSandbox.jsm:141:12
[task 2021-04-17T01:56:29.999Z] 01:56:29 INFO - _spawnTask@resource://specialpowers/SpecialPowersChild.jsm:1604:15
[task 2021-04-17T01:56:29.999Z] 01:56:29 INFO - receiveMessage@resource://specialpowers/SpecialPowersChild.jsm:310:21
[task 2021-04-17T01:56:30.054Z] 01:56:30 INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-04-17T01:56:30.055Z] 01:56:30 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page text color should be reset. - "rgb(21, 20, 26)" == "rgb(12, 12, 13)" - got "rgb(21, 20, 26)", expected "rgb(12, 12, 13)" (operator ==)
[task 2021-04-17T01:56:30.055Z] 01:56:30 INFO - Stack trace:
[task 2021-04-17T01:56:30.056Z] 01:56:30 INFO - is@resource://specialpowers/SpecialPowersSandbox.jsm:90:21
[task 2021-04-17T01:56:30.056Z] 01:56:30 INFO - @chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js:117:9
[task 2021-04-17T01:56:30.057Z] 01:56:30 INFO - execute@resource://specialpowers/SpecialPowersSandbox.jsm:141:12
[task 2021-04-17T01:56:30.057Z] 01:56:30 INFO - _spawnTask@resource://specialpowers/SpecialPowersChild.jsm:1604:15
[task 2021-04-17T01:56:30.057Z] 01:56:30 INFO - receiveMessage@resource://specialpowers/SpecialPowersChild.jsm:310:21
[task 2021-04-17T01:56:30.093Z] 01:56:30 INFO - Opening url: about:welcome
[task 2021-04-17T01:56:31.176Z] 01:56:31 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | About:welcome page should not have lwt-newtab attribute - true == true -
[task 2021-04-17T01:56:31.177Z] 01:56:31 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | About:welcome page should not have lwt-newtab-brighttext attribute - true == true -
[task 2021-04-17T01:56:31.181Z] 01:56:31 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | About:welcome page background should be reset. - "rgb(237, 237, 240)" == "rgb(237, 237, 240)" -
[task 2021-04-17T01:56:31.184Z] 01:56:31 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | About:welcome page text color should be reset. - "rgb(12, 12, 13)" == "rgb(12, 12, 13)" -
[task 2021-04-17T01:56:31.325Z] 01:56:31 INFO - Opening url: about:newtab
[task 2021-04-17T01:56:33.324Z] 01:56:33 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should have lwt-newtab attribute - true == true -
[task 2021-04-17T01:56:33.324Z] 01:56:33 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should have lwt-newtab-brighttext attribute - true == true -
[task 2021-04-17T01:56:33.333Z] 01:56:33 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page background should be set. - "rgb(0, 0, 139)" == "rgb(0, 0, 139)" -
[task 2021-04-17T01:56:33.333Z] 01:56:33 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page text color should be set. - "rgb(173, 216, 230)" == "rgb(173, 216, 230)" -
[task 2021-04-17T01:56:33.436Z] 01:56:33 INFO - Opening url: about:home
[task 2021-04-17T01:56:35.288Z] 01:56:35 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should have lwt-newtab attribute - true == true -
[task 2021-04-17T01:56:35.292Z] 01:56:35 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should have lwt-newtab-brighttext attribute - true == true -
[task 2021-04-17T01:56:35.295Z] 01:56:35 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page background should be set. - "rgb(0, 0, 139)" == "rgb(0, 0, 139)" -
[task 2021-04-17T01:56:35.343Z] 01:56:35 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page text color should be set. - "rgb(173, 216, 230)" == "rgb(173, 216, 230)" -
[task 2021-04-17T01:56:35.423Z] 01:56:35 INFO - Opening url: about:welcome
[task 2021-04-17T01:56:36.598Z] 01:56:36 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should have lwt-newtab attribute - true == true -
[task 2021-04-17T01:56:36.598Z] 01:56:36 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should have lwt-newtab-brighttext attribute - true == true -
[task 2021-04-17T01:56:36.602Z] 01:56:36 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page background should be set. - "rgb(0, 0, 139)" == "rgb(0, 0, 139)" -
[task 2021-04-17T01:56:36.605Z] 01:56:36 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page text color should be set. - "rgb(173, 216, 230)" == "rgb(173, 216, 230)" -
[task 2021-04-17T01:56:37.050Z] 01:56:37 INFO - Opening url: about:newtab
[task 2021-04-17T01:56:39.948Z] 01:56:39 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should not have lwt-newtab attribute - true == true -
[task 2021-04-17T01:56:39.948Z] 01:56:39 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should not have lwt-newtab-brighttext attribute - true == true -
[task 2021-04-17T01:56:39.949Z] 01:56:39 INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-04-17T01:56:39.952Z] 01:56:39 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page background should be reset. - "rgb(255, 255, 255)" == "rgb(249, 249, 250)" - got "rgb(255, 255, 255)", expected "rgb(249, 249, 250)" (operator ==)
[task 2021-04-17T01:56:39.953Z] 01:56:39 INFO - Stack trace:
[task 2021-04-17T01:56:39.954Z] 01:56:39 INFO - is@resource://specialpowers/SpecialPowersSandbox.jsm:90:21
[task 2021-04-17T01:56:39.955Z] 01:56:39 INFO - @chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js:112:9
[task 2021-04-17T01:56:39.955Z] 01:56:39 INFO - execute@resource://specialpowers/SpecialPowersSandbox.jsm:141:12
[task 2021-04-17T01:56:39.956Z] 01:56:39 INFO - _spawnTask@resource://specialpowers/SpecialPowersChild.jsm:1604:15
[task 2021-04-17T01:56:39.957Z] 01:56:39 INFO - receiveMessage@resource://specialpowers/SpecialPowersChild.jsm:310:21
[task 2021-04-17T01:56:39.960Z] 01:56:39 INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-04-17T01:56:39.962Z] 01:56:39 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page text color should be reset. - "rgb(21, 20, 26)" == "rgb(12, 12, 13)" - got "rgb(21, 20, 26)", expected "rgb(12, 12, 13)" (operator ==)
[task 2021-04-17T01:56:39.963Z] 01:56:39 INFO - Stack trace:
[task 2021-04-17T01:56:39.963Z] 01:56:39 INFO - is@resource://specialpowers/SpecialPowersSandbox.jsm:90:21
[task 2021-04-17T01:56:39.965Z] 01:56:39 INFO - @chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js:117:9
[task 2021-04-17T01:56:39.966Z] 01:56:39 INFO - execute@resource://specialpowers/SpecialPowersSandbox.jsm:141:12
[task 2021-04-17T01:56:39.966Z] 01:56:39 INFO - _spawnTask@resource://specialpowers/SpecialPowersChild.jsm:1604:15
[task 2021-04-17T01:56:39.967Z] 01:56:39 INFO - receiveMessage@resource://specialpowers/SpecialPowersChild.jsm:310:21
[task 2021-04-17T01:56:40.027Z] 01:56:40 INFO - Opening url: about:home
[task 2021-04-17T01:56:41.774Z] 01:56:41 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should not have lwt-newtab attribute - true == true -
[task 2021-04-17T01:56:41.774Z] 01:56:41 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page should not have lwt-newtab-brighttext attribute - true == true -
[task 2021-04-17T01:56:41.775Z] 01:56:41 INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-04-17T01:56:41.776Z] 01:56:41 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page background should be reset. - "rgb(255, 255, 255)" == "rgb(249, 249, 250)" - got "rgb(255, 255, 255)", expected "rgb(249, 249, 250)" (operator ==)
[task 2021-04-17T01:56:41.776Z] 01:56:41 INFO - Stack trace:
[task 2021-04-17T01:56:41.777Z] 01:56:41 INFO - is@resource://specialpowers/SpecialPowersSandbox.jsm:90:21
[task 2021-04-17T01:56:41.777Z] 01:56:41 INFO - @chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js:112:9
[task 2021-04-17T01:56:41.777Z] 01:56:41 INFO - execute@resource://specialpowers/SpecialPowersSandbox.jsm:141:12
[task 2021-04-17T01:56:41.777Z] 01:56:41 INFO - _spawnTask@resource://specialpowers/SpecialPowersChild.jsm:1604:15
[task 2021-04-17T01:56:41.778Z] 01:56:41 INFO - receiveMessage@resource://specialpowers/SpecialPowersChild.jsm:310:21
[task 2021-04-17T01:56:41.826Z] 01:56:41 INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-04-17T01:56:41.826Z] 01:56:41 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | New tab page text color should be reset. - "rgb(21, 20, 26)" == "rgb(12, 12, 13)" - got "rgb(21, 20, 26)", expected "rgb(12, 12, 13)" (operator ==)
[task 2021-04-17T01:56:41.826Z] 01:56:41 INFO - Stack trace:
[task 2021-04-17T01:56:41.826Z] 01:56:41 INFO - is@resource://specialpowers/SpecialPowersSandbox.jsm:90:21
[task 2021-04-17T01:56:41.826Z] 01:56:41 INFO - @chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js:117:9
[task 2021-04-17T01:56:41.827Z] 01:56:41 INFO - execute@resource://specialpowers/SpecialPowersSandbox.jsm:141:12
[task 2021-04-17T01:56:41.827Z] 01:56:41 INFO - _spawnTask@resource://specialpowers/SpecialPowersChild.jsm:1604:15
[task 2021-04-17T01:56:41.828Z] 01:56:41 INFO - receiveMessage@resource://specialpowers/SpecialPowersChild.jsm:310:21
[task 2021-04-17T01:56:41.870Z] 01:56:41 INFO - Opening url: about:welcome
[task 2021-04-17T01:56:43.113Z] 01:56:43 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | About:welcome page should not have lwt-newtab attribute - true == true -
[task 2021-04-17T01:56:43.113Z] 01:56:43 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | About:welcome page should not have lwt-newtab-brighttext attribute - true == true -
[task 2021-04-17T01:56:43.113Z] 01:56:43 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | About:welcome page background should be reset. - "rgb(237, 237, 240)" == "rgb(237, 237, 240)" -
[task 2021-04-17T01:56:43.114Z] 01:56:43 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | About:welcome page text color should be reset. - "rgb(12, 12, 13)" == "rgb(12, 12, 13)" -
[task 2021-04-17T01:56:43.269Z] 01:56:43 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | perwindow-ntp-theme -
[task 2021-04-17T01:56:43.270Z] 01:56:43 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | test result correct -
[task 2021-04-17T01:56:43.287Z] 01:56:43 INFO - Console message: [JavaScript Error: "ExtensionError: Invalid window ID: 201"]
[task 2021-04-17T01:56:43.287Z] 01:56:43 INFO - ExtensionError@resource://gre/modules/ExtensionUtils.jsm:58:5
[task 2021-04-17T01:56:43.287Z] 01:56:43 INFO - getWindow@chrome://extensions/content/parent/ext-tabs-base.js:1612:13
[task 2021-04-17T01:56:43.287Z] 01:56:43 INFO - unload@chrome://extensions/content/parent/ext-theme.js:392:38
[task 2021-04-17T01:56:43.287Z] 01:56:43 INFO - onShutdown@chrome://extensions/content/parent/ext-theme.js:427:15
[task 2021-04-17T01:56:43.287Z] 01:56:43 INFO - ExtensionAPI/<@resource://gre/modules/ExtensionCommon.jsm:359:14
[task 2021-04-17T01:56:43.287Z] 01:56:43 INFO - wrapper@resource://gre/modules/ExtensionCommon.jsm:303:14
[task 2021-04-17T01:56:43.287Z] 01:56:43 INFO - emit@resource://gre/modules/ExtensionCommon.jsm:330:32
[task 2021-04-17T01:56:43.287Z] 01:56:43 INFO - emit@resource://gre/modules/Extension.jsm:2081:25
[task 2021-04-17T01:56:43.287Z] 01:56:43 INFO - shutdown@resource://gre/modules/Extension.jsm:2741:10
[task 2021-04-17T01:56:43.287Z] 01:56:43 INFO - receiveMessage@resource://specialpowers/SpecialPowersParent.jsm:1187:28
[task 2021-04-17T01:56:43.287Z] 01:56:43 INFO -
[task 2021-04-17T01:56:43.323Z] 01:56:43 INFO - Leaving test bound test_per_window_ntp_theme
[task 2021-04-17T01:56:43.343Z] 01:56:43 INFO - GECKO(2506) | MEMORY STAT | vsize 130551435MB | residentFast 2615MB
[task 2021-04-17T01:56:43.343Z] 01:56:43 INFO - TEST-OK | toolkit/components/extensions/test/browser/browser_ext_themes_ntp_colors_perwindow.js | took 43152ms
Comment 12•4 years ago
|
||
Comment 13•4 years ago
|
||
bugherder |
Assignee | ||
Comment 14•4 years ago
|
||
Yup browser_ext_themes_ntp_colors_perwindow needed updating. Although I did notice bug 1705883 in the try builds when forcing TVs. Some reason 4. Run each test 5 times in a new browser each time, in chaos mode.
would cause issues and maybe it's specific to this "perwindow" test.
Description
•