Closed Bug 1693819 Opened 10 months ago Closed 8 months ago

Apply proton white background to tabbrowser empty browser background

Categories

(Firefox :: Tabbed Browser, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: RT, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-foundations] [priority:2a])

Attachments

(1 file)

Context:
While about: pages are not directly in scope for Proton, Proton visual design changes impacted about: pages given shared style pages exist. This will cause about: pages to inherit Proton styles that won't have good contrast with current background color.

Acceptance criteria:

  • Apply white background to about: pages
Severity: -- → N/A
Component: General → Themes
Priority: -- → P3
Product: Firefox → Toolkit

(Do we also intend to use white in dark mode, or should we use the dark background colour, or black?)

Flagging here Aaron to make sure it's part of the dark mode spec

Flags: needinfo?(abenson)

(In reply to Tim Nguyen :ntim from comment #3)

This is relatively straightforward to do, these variables need updating:

https://searchfox.org/mozilla-central/source/toolkit/themes/shared/in-content/common.inc.css

This already happened in bug 1693276 which you reviewed, right?

https://searchfox.org/mozilla-central/rev/9bf82ef9c097ee6af0e34a1d21c073b2616cc438/browser/themes/shared/tabs.inc.css#41-56
https://searchfox.org/mozilla-central/rev/9bf82ef9c097ee6af0e34a1d21c073b2616cc438/layout/style/res/plaintext.css#24-25

The second one is dark mode only, so I don't think it needs changing in this bug. The dark mode bug should probably update it.

Flags: needinfo?(ntim.bugs)

(In reply to :Gijs (he/him) from comment #4)

(In reply to Tim Nguyen :ntim from comment #3)

This is relatively straightforward to do, these variables need updating:

https://searchfox.org/mozilla-central/source/toolkit/themes/shared/in-content/common.inc.css

This already happened in bug 1693276 which you reviewed, right?

Yes.

https://searchfox.org/mozilla-central/rev/9bf82ef9c097ee6af0e34a1d21c073b2616cc438/browser/themes/shared/tabs.inc.css#41-56
https://searchfox.org/mozilla-central/rev/9bf82ef9c097ee6af0e34a1d21c073b2616cc438/layout/style/res/plaintext.css#24-25

The second one is dark mode only, so I don't think it needs changing in this bug. The dark mode bug should probably update it.

Sounds fine, worth adding a note on that bug. The first one still needs updating though for the light mode at least.

Flags: needinfo?(ntim.bugs)
Component: Themes → Tabbed Browser
Product: Toolkit → Firefox
Summary: Apply white background to about: pages → Apply proton white background to tabbrowser empty browser background

The product::component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Priority: P3 → --
Whiteboard: [proton-foundations]
Priority: -- → P2
Whiteboard: [proton-foundations] → [proton-foundations] [priority:2a]
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(abenson)
Attachment #9213880 - Attachment description: Bug 1693819 - match up the new in-content backgroundd to the tabpanels background with proton enabled, r?jaws → Bug 1693819 - match up the new in-content background to the tabpanels background with proton enabled, r?jaws
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f5df9fe05c93
match up the new in-content background to the tabpanels background with proton enabled, r=jaws
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Depends on: 1705511
Blocks: 1706360
Depends on: 1708717
Depends on: 1711258
No longer depends on: 1711258
Blocks: 1730562
You need to log in before you can comment on or make changes to this bug.