1693819 - Apply proton white background to tabbrowser empty browser background

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement, P2)

Description

[Romain Testard [:RT]]

Context:
While about: pages are not directly in scope for Proton, Proton visual design changes impacted about: pages given shared style pages exist. This will cause about: pages to inherit Proton styles that won't have good contrast with current background color.

Acceptance criteria:

• Apply white background to about: pages

Comment 1

[Blake Winton (:bwinton) (:☕️)]

(Do we also intend to use white in dark mode, or should we use the dark background colour, or black?)

Comment 2

[Romain Testard [:RT]]

Flagging here Aaron to make sure it's part of the dark mode spec

Comment 3

[Tim Nguyen :ntim]

This is relatively straightforward to do, these variables need updating:

https://searchfox.org/mozilla-central/source/toolkit/themes/shared/in-content/common.inc.css
https://searchfox.org/mozilla-central/rev/9bf82ef9c097ee6af0e34a1d21c073b2616cc438/browser/themes/shared/tabs.inc.css#41-56
https://searchfox.org/mozilla-central/rev/9bf82ef9c097ee6af0e34a1d21c073b2616cc438/layout/style/res/plaintext.css#24-25

Comment 4

[:Gijs (he/him)]

(In reply to Tim Nguyen :ntim from comment #3)

This is relatively straightforward to do, these variables need updating:

https://searchfox.org/mozilla-central/source/toolkit/themes/shared/in-content/common.inc.css

This already happened in bug 1693276 which you reviewed, right?

https://searchfox.org/mozilla-central/rev/9bf82ef9c097ee6af0e34a1d21c073b2616cc438/browser/themes/shared/tabs.inc.css#41-56
https://searchfox.org/mozilla-central/rev/9bf82ef9c097ee6af0e34a1d21c073b2616cc438/layout/style/res/plaintext.css#24-25

The second one is dark mode only, so I don't think it needs changing in this bug. The dark mode bug should probably update it.

Comment 5

[Tim Nguyen :ntim]

(In reply to :Gijs (he/him) from comment #4)

(In reply to Tim Nguyen :ntim from comment #3)

This is relatively straightforward to do, these variables need updating:

https://searchfox.org/mozilla-central/source/toolkit/themes/shared/in-content/common.inc.css

This already happened in bug 1693276 which you reviewed, right?

Yes.

https://searchfox.org/mozilla-central/rev/9bf82ef9c097ee6af0e34a1d21c073b2616cc438/browser/themes/shared/tabs.inc.css#41-56
https://searchfox.org/mozilla-central/rev/9bf82ef9c097ee6af0e34a1d21c073b2616cc438/layout/style/res/plaintext.css#24-25

The second one is dark mode only, so I don't think it needs changing in this bug. The dark mode bug should probably update it.

Sounds fine, worth adding a note on that bug. The first one still needs updating though for the light mode at least.

Comment 6

[:Gijs (he/him)]

(In reply to Tim Nguyen :ntim from comment #5)

https://searchfox.org/mozilla-central/rev/9bf82ef9c097ee6af0e34a1d21c073b2616cc438/browser/themes/shared/tabs.inc.css#41-56

This still needs updating, morphing for this.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The product::component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Comment 8

[:Gijs (he/him)]

Attachment: Bug 1693819 - match up the new in-content background to the tabpanels background with proton enabled, r?jaws

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5df9fe05c93
match up the new in-content background to the tabpanels background with proton enabled, r=jaws

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/f5df9fe05c93