1705529 - [Meta] Enable login CSV import for all channels

Status: NEW

(Firefox :: about:logins, enhancement)

Description

[Tim Giles [:tgiles] | OOO Nov 25-29]

After resolving the blocking bugs, we should enable login CSV import for all channels.

Comment 1

[Tim Giles [:tgiles] | OOO Nov 25-29]

Adding Bug 1688213 as a bug that is blocked by this. There's probably a better way to manage this, but this should be good enough for now.

Comment 2

[codebugs]

I understand that 1705529 is a feature enhancement for a UI element that would display feedback to people with large numbers of passwords when the file is still being read. If this list contains hundreds of thousands of passwords, it can take a time before the operation completes.

If that feature enhancement is not likely to complete soon, could it be possible to reconsider marking enabling password import as a dependency on it? Improving the UI experience for the importing a list of passwords of that size is helpful, but it is not clear from my reading that the rare occasion an individual importing that many user accounts having a moment of confusion outweighs the inconvenience of not being able to import passwords in general.

Users who follow the kb https://support.mozilla.org/en-US/kb/import-login-data-file do not currently receive the information required to complete their task, so there is a level of confusion regarding password import.

Cheers.

Comment 3

[Tim Giles [:tgiles] | OOO Nov 25-29]

The main blocker for re-enabling login CSV import is Bug 1701660, the feature will not be enabled until we can resolve performance issues when importing a sizeable amount of logins. If we re-enabled the feature currently, there is a good chance the browser will lock up during the import process which is something we definitely want to avoid. If the only blocker was, like you said, a rare moment of confusion, then yeah it would be a different story. Unfortunately this is not the case.

Comment 5

[:Gijs (out for now; he/him)]

(In reply to Tim Giles [:tgiles] from comment #3)

The main blocker for re-enabling login CSV import is Bug 1701660, the feature will not be enabled until we can resolve performance issues when importing a sizeable amount of logins. If we re-enabled the feature currently, there is a good chance the browser will lock up during the import process which is something we definitely want to avoid. If the only blocker was, like you said, a rare moment of confusion, then yeah it would be a different story. Unfortunately this is not the case.

1701660 is fixed now - can we reconsider letting this ride the train? :-)

Comment 6

[Tim Giles [:tgiles] | OOO Nov 25-29]

(In reply to :Gijs (he/him) from comment #5)

1701660 is fixed now - can we reconsider letting this ride the train? :-)

Unfortunately, we still can't let this feature ride the train. While we've fixed the browser UI refresh issue, which was a major issue, the import process is still on the main thread. Having this processing on the main thread can still lock up the browser, so Bug 1748491 is a blocking issue for enabling login CSV import.