1705582 - No popuphiding/popuphidden event if a native context menu is hidden before the popupshown event

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Markus Stange [:mstange]]

Similar problem to bug 1704215, but with a slightly different set of circumstances.

We have some tests which call menupopup.openPopupAtScreen(...) and menupopup.hidePopup() without waiting for the popupshown event in between. Under those circumstances, the native menu doesn't get far enough in its opening sequence to know that it should fire popuphiding/popuphidden when it is closed.

This is causing a test failure in devtools/client/netmonitor/test/browser_net_columns_last_column.js: Since the old popup never fires popuphidden, this cleanup in devtools/client/framework/menu.js never happens, and old remnant popup nodes are left in the DOM. Those old nodes then confuse the testLastMenuItem check which looks at an old DOM node.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1705582 - Make sure NativeMenuMac::Close fires popuphiding / popuphidden even if the menu wasn't fully opened. r=harry

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c99c4097d7e
Make sure NativeMenuMac::Close fires popuphiding / popuphidden even if the menu wasn't fully opened. r=harry

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0c99c4097d7e