1705616 - Aspect-ratio's auto content-based min size added block-start border and padding twice

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

aState.mBCoord initialized with block-start border and padding in https://searchfox.org/mozilla-central/rev/5e70cd673a0ba0ad19b662c1cf656e0823781596/layout/generic/BlockReflowInput.cpp#132

So contentBSize + borderPadding.BStartEnd(wm) added block-start border and padding twice.
https://searchfox.org/mozilla-central/rev/5e70cd673a0ba0ad19b662c1cf656e0823781596/layout/generic/nsBlockFrame.cpp#1889,1900-1903

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1705616 - Fix aspect-ratio's auto content-based min size when the block frame has border and padding. r?boris,emilio

aState.mBCoord already includes block-start border and padding, so we
wrongly add the block-start border and padding twice when computing the
border-box content block-size. This patch fixed it, and rename
contentBSize variable to make it clearer.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8550fed3a6fe
Fix aspect-ratio's auto content-based min size when the block frame has border and padding. r=boris,emilio

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/28550 for changes under testing/web-platform/tests

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8550fed3a6fe

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot