17058 - [DOGFOOD] [PP] mac: POP mail filtering on body doesn't work

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[ekrock's old account (dead)]

As of M10 this is not yet implemented on any platform.

I'm nominating this as a [DOGFOOD] bug because I personally have 181 filters
defined including many with tests on the POP3 message body, and I can't move
over to Nav5 Messenger until this is supported.  (If I had to sort all that
email manually, my work would grind to a halt.  Over the last 3 years I've
created many email submission links and mail submit forms across DevEdge Online
for developer input and I rely on mail filtering with body tests to manage the
flow.)

I should mention that this feature was on the post beta 1 list.  I know
we're trying to avoid feature creep for beta 1, but this is a genuine dogfood
issue at least for me, so I'll let PDT make the call on that issue.

Sorry if this is a DUP, but I queried and couldn't find a bug specifically for
mail filtering on the body, although there were references in other descriptions
to the fact that it's not yet implemented.

Comment 1

[Phil Peterson]

Eric, have you migrated your profile from 4.x? In general, migrated filters are
supposed to work, even though we don't yet have a front-end for manipulating
filters in mozilla. I would also be unhappy if I had no filters at all, but I'm
limping along with migrated filters.

Comment 2

[laurel]

Doesn't work with migrated filters. Basic Sender & subject do, but this doesn't
(there is a problem with filtering date, too, already logged against bienvenu).

Comment 3

[hamerly]

We think this is an edge case, and are impressed with the amount of mail you
must read.  Please provide 5 more names and we'll go with a PDT+.

Comment 4

[Phil Peterson]

David, I saw you were working on this, so over to you.

Comment 5

[David :Bienvenu]

*** Bug 17173 has been marked as a duplicate of this bug. ***

Comment 6

[David :Bienvenu]

I didn't know this bug existed, so I filed a new one a few days ago, but I
ported over the code last night while I was blocked on something else. It almost
works now. Not quite, though.

Comment 7

[David :Bienvenu]

this basically works now. I've seen some strange problems where sometimes
filters don't fire when you have multiple matching messages, but I can't
reproduce it. If that doesn't put blood in the water, I don't know what will :-)

Comment 8

[laurel]

Basics working on NT 4.0 using 1999-11-04-08m11 commercial build.
Am definitely seeing the multiple message match problem David described above --
will log a separate bug on that.

Still verifying other platforms...

Comment 9

[laurel]

Basics work for single match message using nov5 commercial build on linux 6.0

I cannot get (POP) body filter to work on Mac using nov5 commercial build. (can
get other filter like simple subject contains to work on mac, so it's not that
all filters are broken on mac)

Reopening for mac case...

Comment 10

[David :Bienvenu]

Moving to m12. Looks like I have another date with my imac :-(

Comment 11

[David :Bienvenu]

I think I have a fix for this but I need a green tree.

Comment 12

[David :Bienvenu]

Can you try this with tomorrow's build, laurel? dougt fixed a problem with file
streams, and I fixed a problem with move filters in general.

Comment 13

[lchiang]

Laurel's been out sick :-(
Hopefully, she'll be in tomorrow.

Comment 14

[laurel]

Using 12-06-08 m12 on mac OS 8.5.1 I still cannot get this to work. I've tried
many times now and have tried using body contains, doesn't contain, is, isn't.

Comment 15

[David :Bienvenu]

sor

Comment 16

[laurel]

What does your comment mean? (Are you "sor" at me for reopening? just kidding)

Comment 17

[David :Bienvenu]

ah, focus must have got set to the wrong window - I never meant to add a comment
to this - I was replying to a mail message which started: "sorry".

Comment 18

[David :Bienvenu]

OK, I found another fix - I'll try it on the mac tomorrow.

Comment 19

[David :Bienvenu]

OK, I got this working on my mac, anyway :-)

Comment 20

[laurel]

Did this get in for m12 or will this be checked in m13?

Comment 21

[David :Bienvenu]

it should be in m12, I checked it in last night.

Comment 22

[laurel]

Cannot get it to work on my machine using the 12-08-08m12 commercial build on
mac 0S 8.5.1.

Will attack it again tomorrow and also on another machine...

Is this a torture test?

Comment 23

[David :Bienvenu]

the filter I got to work is "body contains". I'm pretty sure I checked it in
though I could have made a boo-boo, since I make the same change on windows and
checked that in.

Comment 24

[laurel]

Victory! This makes my day!

OK (woohoo!!) using 12-10-08m12 commercial build on Mac OS 8.5.1

Also still OK on NT 4.0 and linux using 12-10-08m12 commercial builds.