1705872 - [Fission] When redirect to a moz-extension:// url the back button doesn't work reliably

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P3)

Description

[kernp25]

Attachment: test.zip

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:87.0) Gecko/20100101 Firefox/87.0

Steps to reproduce:

1. Install the test add-on in about:debugging
2. Enter https://example.com/ in the address bar and click enter to load the page
3. Now click the browser back button

Actual results:

The browser back button works fine for the first time but then you have to click more times (the click count increases every time you load https://example.com/) to get back to the previous page.

Expected results:

It should just work.

Comment 1

[kernp25]

Attachment: fyL6T9irIh.mp4

Comment 2

[kernp25]

It seems to get fixed, if you set fission.bfcacheInParent to true.

Comment 3

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Address Bar' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 4

[Chris Peterson [:cpeterson]]

It seems to get fixed, if you set fission.bfcacheInParent to true.

needinfo'ing kmag because he said he would test whether this is related to Fission or BFCache.

The test extension redirects example.com to a moz-extension page. We seem to be adding a new session history entry for each example.com visit.

Comment 5

[Marcela (Please NI request to Brindusa Tot)]

Hi kernp25!
I was not able to reproduce this issue on latest Nighlty version 89.0a1a (2021-04-19)(64-bit) on Windows 10. I'll attach a file with evidence.
I've followed the next steps:

1. Open about:debugging and Load temporary add-on using the file attached.
2. Open a new tab and type: thttp://example.com/ in the address bar
3. Press the back button and type the same http://example.com/
4. Repeat step 3.
   Preference fission.bfcacheInParent was on Flase.
   Please let us know if the steps are correct.
   Could you try to reproduce it on the latest Nightly version and tell us your input? You can download it from here: https://nightly.mozilla.org/

Comment 6

[Marcela (Please NI request to Brindusa Tot)]

Attachment: 1705872.mp4

Comment 7

[kernp25]

You must have fission activated for this bug to reproduce.

Set fission.autostart to true in about:config.

Comment 8

[Kris Maglione [:kmag]]

We think this is probably another manifestation as the same issue as bug 1707603. If Peter can confirm, then the bugs can be merged.

Comment 9

[Peter Van der Beken [:peterv]]

I am not sure this is the same as bug 1707603. I can reproduce this one but not bug 1707603.

Comment 10

[Peter Van der Beken [:peterv]]

Attachment: Bug 1705872 - Clear history's epoch in the parent when replacing BC. r?smaug!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/def2e03a3881
Clear history's epoch in the parent when replacing BC. r=smaug

Comment 12

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/def2e03a3881