[QM_TRY] Failures in dom/quota/ActorsParent.cpp:EnsureDirectory
Categories
(Core :: Storage: Quota Manager, defect, P3)
Tracking
()
People
(Reporter: jstutte, Unassigned, NeedInfo)
References
(Depends on 3 open bugs, Blocks 1 open bug)
Details
Attachments
(5 obsolete files)
| Clients | Sessions | Hits | Anchor | Stack |
|---|---|---|---|---|
| 2 | 2 | 2 | dom/quota/ActorsParent.cpp:EnsureDirectory | dom/quota/ActorsParent.cpp#2401:WIN32(0x70) <- dom/quota/ActorsParent.cpp#4634:WIN32(0x70) <- dom/quota/ActorsParent.cpp#4224:WIN32(0x70) <- dom/quota/ActorsParent.cpp#6223:WIN32(0x70) |
|
Reporter | |
Updated•2 years ago
|
|
|
Reporter | |
Comment 2•2 years ago
|
||
| Clients | Sessions | Hits | Anchor | Stack |
|---|---|---|---|---|
| 1 | 2 | 2 | dom/quota/ActorsParent.cpp:EnsureDirectory | dom/quota/ActorsParent.cpp#2401:NS_ERROR_FILE_ACCESS_DENIED <- dom/quota/ActorsParent.cpp#4636:NS_ERROR_FILE_ACCESS_DENIED <- dom/quota/ActorsParent.cpp#4226:NS_ERROR_FILE_ACCESS_DENIED <- dom/quota/ActorsParent.cpp#4229:NS_ERROR_FILE_ACCESS_DENIED <- dom/quota/ActorsParent.cpp#6225:NS_ERROR_FILE_ACCESS_DENIED |
| 1 | 1 | 1 | dom/quota/ActorsParent.cpp:EnsureDirectory | dom/quota/ActorsParent.cpp#2401:NS_ERROR_FILE_FS_CORRUPTED <- dom/quota/ActorsParent.cpp#4636:NS_ERROR_FILE_FS_CORRUPTED <- dom/quota/ActorsParent.cpp#4226:NS_ERROR_FILE_FS_CORRUPTED <- dom/quota/ActorsParent.cpp#4229:NS_ERROR_FILE_FS_CORRUPTED <- dom/quota/ActorsParent.cpp#6225:NS_ERROR_FILE_FS_CORRUPTED |
| Clients | Sessions | Hits | Anchor | Stack |
|---|---|---|---|---|
| 1 | 1 | 1 | dom/quota/ActorsParent.cpp:EnsureDirectory | dom/quota/ActorsParent.cpp#2401:NS_ERROR_FILE_ACCESS_DENIED <- dom/quota/ActorsParent.cpp#4636:NS_ERROR_FILE_ACCESS_DENIED <- dom/quota/ActorsParent.cpp#4226:NS_ERROR_FILE_ACCESS_DENIED <- dom/quota/ActorsParent.cpp#4229:NS_ERROR_FILE_ACCESS_DENIED <- dom/quota/ActorsParent.cpp#6225:NS_ERROR_FILE_ACCESS_DENIED |
| Clients | Sessions | Hits | Anchor | Stack |
|---|---|---|---|---|
| 1 | 2 | 2 | dom/quota/ActorsParent.cpp:EnsureDirectory | dom/quota/ActorsParent.cpp#2401:NS_ERROR_FILE_ACCESS_DENIED <- dom/quota/ActorsParent.cpp#4636:NS_ERROR_FILE_ACCESS_DENIED <- dom/quota/ActorsParent.cpp#4226:NS_ERROR_FILE_ACCESS_DENIED <- dom/quota/ActorsParent.cpp#4229:NS_ERROR_FILE_ACCESS_DENIED <- dom/quota/ActorsParent.cpp#6225:NS_ERROR_FILE_ACCESS_DENIED |
| 1 | 1 | 1 | dom/quota/ActorsParent.cpp:EnsureDirectory | dom/quota/ActorsParent.cpp#2401:NS_ERROR_FILE_FS_CORRUPTED <- dom/quota/ActorsParent.cpp#4636:NS_ERROR_FILE_FS_CORRUPTED <- dom/quota/ActorsParent.cpp#4226:NS_ERROR_FILE_FS_CORRUPTED <- dom/quota/ActorsParent.cpp#4229:NS_ERROR_FILE_FS_CORRUPTED <- dom/quota/ActorsParent.cpp#6225:NS_ERROR_FILE_FS_CORRUPTED |
|
|
Reporter | |
Comment 3•2 years ago
|
||
| Clients | Sessions | Hits | Anchor | Stack |
|---|---|---|---|---|
| 1 | 1 | 1 | dom/quota/ActorsParent.cpp:EnsureDirectory | dom/quota/ActorsParent.cpp#2401:NS_ERROR_FILE_NO_DEVICE_SPACE <- dom/quota/ActorsParent.cpp#4640:NS_ERROR_FILE_NO_DEVICE_SPACE <- dom/quota/ActorsParent.cpp#4230:NS_ERROR_FILE_NO_DEVICE_SPACE <- dom/quota/ActorsParent.cpp#6229:NS_ERROR_FILE_NO_DEVICE_SPACE |
| 1 | 1 | 1 | dom/quota/ActorsParent.cpp:EnsureDirectory | dom/quota/ActorsParent.cpp#2401:NS_ERROR_FILE_NO_DEVICE_SPACE <- dom/quota/ActorsParent.cpp#4640:NS_ERROR_FILE_NO_DEVICE_SPACE <- dom/quota/ActorsParent.cpp#4230:NS_ERROR_FILE_NO_DEVICE_SPACE <- dom/quota/ActorsParent.cpp#6229:NS_ERROR_FILE_NO_DEVICE_SPACE |
|
|
Reporter | |
Comment 4•2 years ago
|
||
| Clients | Sessions | Hits | Anchor | Stack |
|---|---|---|---|---|
| 1 | 4 | 4 | dom/quota/ActorsParent.cpp:EnsureDirectory | dom/quota/ActorsParent.cpp#2399:NS_ERROR_FILE_ACCESS_DENIED |
| 1 | 1 | 4 | dom/quota/ActorsParent.cpp:EnsureDirectory | dom/quota/ActorsParent.cpp#2399:NS_ERROR_FILE_ACCESS_DENIED <- dom/quota/ActorsParent.cpp#4634:NS_ERROR_FILE_ACCESS_DENIED <- dom/quota/ActorsParent.cpp#4224:NS_ERROR_FILE_ACCESS_DENIED <- dom/quota/ActorsParent.cpp#4227:NS_ERROR_FILE_ACCESS_DENIED <- dom/quota/ActorsParent.cpp#6220:NS_ERROR_FILE_ACCESS_DENIED |
| 1 | 1 | 1 | dom/quota/ActorsParent.cpp:EnsureDirectory | dom/quota/ActorsParent.cpp#2406:NS_ERROR_FILE_DESTINATION_NOT_DIR |
| 1 | 1 | 1 | dom/quota/ActorsParent.cpp:EnsureDirectory | dom/quota/ActorsParent.cpp#2406:NS_ERROR_FILE_DESTINATION_NOT_DIR <- dom/quota/ActorsParent.cpp#6227:NS_ERROR_FILE_DESTINATION_NOT_DIR |
|
|
Reporter | |
Comment 5•2 years ago
|
||
|
|
Reporter | |
Comment 6•2 years ago
•
|
||
So the last bunch of failures have always the same code path but different error messages:
NS_ERROR_FILE_NO_DEVICE_SPACEwhich is not actionableNS_ERROR_FILE_NAME_TOO_LONGand(NS_ERROR_MODULE_WIN32, 0x7B) -> Illegal file namewhich both seem to indicate that there are origins that cannot be represented well by a directory name (and/or we fail some conversion on the way to a valid file name). To securely avoid any problems here we probably need to transform the origin name into some hash value to be used for the directory name which is part of QM v4, IIRC. I wonder if that part could be done isolated as a small first step.
|
|
Reporter | |
Comment 7•2 years ago
|
||
|
|
Reporter | |
Comment 8•2 years ago
|
||
|
|
Reporter | |
Comment 9•2 years ago
|
||
|
|
Reporter | |
Comment 10•2 years ago
|
||
(In reply to Jens Stutte [:jstutte] from comment #6)
So the last bunch of failures have always the same code path but different error messages:
NS_ERROR_FILE_NO_DEVICE_SPACEwhich is not actionableNS_ERROR_FILE_NAME_TOO_LONGand(NS_ERROR_MODULE_WIN32, 0x7B) -> Illegal file namewhich both seem to indicate that there are origins that cannot be represented well by a directory name (and/or we fail some conversion on the way to a valid file name). To securely avoid any problems here we probably need to transform the origin name into some hash value to be used for the directory name which is part of QM v4, IIRC. I wonder if that part could be done isolated as a small first step.
Jan, this seems something we should look at.
|
|
Reporter | |
Comment 11•2 years ago
|
||
|
|
Reporter | |
Comment 12•2 years ago
|
||
|
|
Reporter | |
Comment 13•2 years ago
|
||
|
|
Reporter | |
Comment 14•2 years ago
|
||
Comment 6 still holds.
|
||
Comment 15•2 years ago
|
||
|
||
Updated•2 years ago
|
|
||
Comment 16•2 years ago
|
||
Taken from Attachment 9236979 [details].
|
|
||
Comment 17•2 years ago
|
||
Taken from Attachment 9237504 [details].
|
|
||
Comment 18•2 years ago
|
||
|
|
||
Comment 19•2 years ago
|
||
Taken from Attachment 9238169 [details].
|
|
||
Comment 20•2 years ago
|
||
Taken from Attachment 9238538 [details].
|
|
||
Comment 21•2 years ago
|
||
|
|
||
Comment 22•2 years ago
|
||
Taken from Attachment 9239371 [details].
|
|
||
Comment 23•2 years ago
|
||
Taken from Attachment 9239692 [details].
|
|
||
Comment 24•2 years ago
|
||
|
|
||
Comment 25•2 years ago
|
||
Taken from Attachment 9240325 [details].
|
|
||
Comment 26•2 years ago
|
||
|
|
||
Comment 27•2 years ago
|
||
Taken from Attachment 9240951 [details].
|
|
||
Comment 28•2 years ago
|
||
Taken from Attachment 9241622 [details].
|
|
||
Comment 29•2 years ago
|
||
Taken from Attachment 9242094 [details].
|
|
||
Comment 30•2 years ago
|
||
Taken from Attachment 9242714 [details].
|
|
||
Comment 31•2 years ago
|
||
Taken from Attachment 9243039 [details].
|
|
||
Comment 32•2 years ago
|
||
Taken from Attachment 9243730 [details].
|
|
||
Comment 33•2 years ago
|
||
Taken from Attachment 9244185 [details].
|
|
||
Comment 34•2 years ago
|
||
Taken from Attachment 9244815 [details].
|
|
||
Comment 35•2 years ago
|
||
Taken from Attachment 9245269 [details].
|
|
||
Comment 36•2 years ago
|
||
Taken from Attachment 9245933 [details].
|
|
||
Comment 37•2 years ago
|
||
Taken from Attachment 9246450 [details].
|
|
||
Comment 38•2 years ago
|
||
Taken from Attachment 9247122 [details].
|
|
||
Comment 39•1 year ago
|
||
Taken from Attachment 9247551 [details].
|
|
||
Comment 40•1 year ago
|
||
Taken from Attachment 9248252 [details].
|
|
||
Comment 41•1 year ago
|
||
Taken from Attachment 9248707 [details].
|
|
||
Comment 42•1 year ago
|
||
Taken from Attachment 9249306 [details].
|
|
||
Comment 43•1 year ago
|
||
Taken from Attachment 9249782 [details].
|
|
||
Comment 44•1 year ago
|
||
Taken from Attachment 9250412 [details].
|
|
||
Comment 45•1 year ago
|
||
Taken from Attachment 9250741 [details].
|
|
||
Comment 46•1 year ago
|
||
Taken from Attachment 9251435 [details].
|
|
||
Comment 47•1 year ago
|
||
Taken from Attachment 9251918 [details].
|
|
||
Comment 48•1 year ago
|
||
Taken from Attachment 9252504 [details].
|
|
||
Comment 49•1 year ago
|
||
Taken from Attachment 9252886 [details].
|
|
||
Comment 50•1 year ago
|
||
Taken from Attachment 9253493 [details].
|
|
||
Comment 51•1 year ago
|
||
Taken from Attachment 9253914 [details].
|
|
||
Comment 52•1 year ago
|
||
Taken from Attachment 9254522 [details].
|
|
||
Comment 53•1 year ago
|
||
Taken from Attachment 9255050 [details].
|
|
||
Comment 54•1 year ago
|
||
Taken from Attachment 9255717 [details].
|
|
||
Comment 55•1 year ago
|
||
Taken from Attachment 9256168 [details].
|
|
||
Comment 56•1 year ago
|
||
Taken from Attachment 9257342 [details].
|
|
||
Comment 57•1 year ago
|
||
Taken from Attachment 9257839 [details].
|
|
||
Comment 58•1 year ago
|
||
Taken from Attachment 9258408 [details].
|
|
||
Comment 59•1 year ago
|
||
Taken from Attachment 9258943 [details].
|
|
||
Comment 60•1 year ago
|
||
Taken from Attachment 9259422 [details].
|
|
||
Comment 61•1 year ago
|
||
Taken from Attachment 9259961 [details].
|
|
||
Updated•1 year ago
|
|
|
||
Updated•1 year ago
|
|
|
||
Updated•1 year ago
|
|
|
||
Updated•1 year ago
|
|
|
||
Comment 62•1 year ago
|
||
Taken from Attachment 9260423 [details].
|
|
||
Comment 63•1 year ago
|
||
Taken from Attachment 9261099 [details].
|
|
||
Comment 64•1 year ago
|
||
Taken from Attachment 9261549 [details].
|
|
||
Comment 65•1 year ago
|
||
Taken from Attachment 9262116 [details].
|
|
||
Comment 66•1 year ago
|
||
Taken from Attachment 9262645 [details].
|
|
||
Comment 67•1 year ago
|
||
Taken from Attachment 9263325 [details].
|
|
||
Comment 68•1 year ago
|
||
Taken from Attachment 9263751 [details].
|
|
||
Comment 69•1 year ago
|
||
Taken from Attachment 9264398 [details].
|
|
||
Comment 70•1 year ago
|
||
Taken from Attachment 9264854 [details].
|
|
||
Comment 71•1 year ago
|
||
Taken from Attachment 9265394 [details].
|
|
||
Comment 72•1 year ago
|
||
Taken from Attachment 9265725 [details].
|
|
||
Comment 73•1 year ago
|
||
Taken from Attachment 9266276 [details].
|
|
||
Comment 74•1 year ago
|
||
Taken from Attachment 9267194 [details].
|
|
||
Comment 75•1 year ago
|
||
Taken from Attachment 9267680 [details].
|
|
||
Comment 76•1 year ago
|
||
Taken from Attachment 9268245 [details].
|
|
||
Comment 77•1 year ago
|
||
Taken from Attachment 9268673 [details].
|
|
||
Comment 78•1 year ago
|
||
Taken from Attachment 9269234 [details].
|
|
||
Comment 79•1 year ago
|
||
Taken from Attachment 9269668 [details].
|
|
||
Comment 80•1 year ago
|
||
Taken from Attachment 9270720 [details].
|
|
||
Comment 81•1 year ago
|
||
Taken from Attachment 9273265 [details].
|
|
||
Comment 82•11 months ago
|
||
Taken from Attachment 9273630 [details].
|
|
||
Comment 83•11 months ago
|
||
Taken from Attachment 9274230 [details].
|
|
||
Comment 84•11 months ago
|
||
Taken from Attachment 9274666 [details].
|
|
||
Comment 85•11 months ago
|
||
Taken from Attachment 9275142 [details].
|
|
||
Comment 86•10 months ago
|
||
Taken from Attachment 9277802 [details].
|
|
||
Comment 87•10 months ago
|
||
Taken from Attachment 9278772 [details].
Description
•