170615 - eliminate use of nsAutoString in parser attribute token

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect, P3)

Description

[Cathleen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0

to reduce the size of attribute token for footprint improvement.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[harishd]

Attachment: patch v1.0 [ reduce attr token size and removed unused code ]

This patch should reduce the attribute token size by ~100 bytes. Basically,
I've replaced the nsAutoString, for mTextValue, with nsSlidingSubstring and
nsString.
The idea is to use nsString for attribute values that contain entities ( which,
AFAIK, is way less compared to attribute values without entities ) and for the
rest use nsSlidingSubstring ( eliminates string copy! ).

Comment 2

[Simon Paquet [:sipaq]]

Comment on attachment 100484 [details] [diff] [review]
patch v1.0 [ reduce attr token size and removed unused code ]

Asking for reviews

Comment 3

[Boris Zbarsky [:bzbarsky]]

This is pretty big... I'm not likely to get to it before 1.7a.  :(

Comment 4

[Simon Paquet [:sipaq]]

Comment on attachment 100484 [details] [diff] [review]
patch v1.0 [ reduce attr token size and removed unused code ]

The patch does no longer apply and with darin's string changes the whole patch
probably needs to be redone.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

This was fixed by the checkin to bug 269853, marking FIXED.