Closed Bug 1706204 Opened 3 years ago Closed 3 years ago

Public bulk mail notification won't count beyond 15 when adding more recipients, and silently discards all To/Cc recipients added after notification.

Categories

(Thunderbird :: Message Compose Window, defect, P1)

Tracking

(thunderbird_esr78 unaffected, thunderbird89 affected)

RESOLVED FIXED
90 Branch
Tracking Status
thunderbird_esr78 --- unaffected
thunderbird89 --- affected

People

(Reporter: thomas8, Assigned: lasana)

References

(Regression)

Details

(4 keywords, Whiteboard: [enterprise-relevance])

Attachments

(2 files)

Public bulk mail notification won't count beyond 15 when you add more recipients after its appearance, and worse, it'll silently discard any public recipients added after the notification when moving pills with Use Bcc instead. Fortunately, Thomas is here to uncover this assault on user's precious recipient pills...

STR (see screencast)

  1. compose, add 15 recipients in To or Cc
    -> Public bulk mail notification appears, suggesting to Use Bcc instead
  2. add more recipients in To or Cc, say 3 more to make them 18, and observe notification count
  3. Hit Use Bcc Instead

Actual result

  • step 2) While adding more pills, notification count stuck at 15
  • step 3) All To/Cc recipients added after notifcation's appearance are silently discarded when moving recipients to Bcc - that's serious dataloss!

Expected result

  • Keep counting in the notification while more recipients are added! (Fluent handles such dynamic updates very well).
  • Don't discard added recipients upon Use Bcc Instead!!!
Whiteboard: [enterprise-relevance]
  • Basic recipient deduplication based on full address for Use Bcc instead would also be nice.
  • With TB on half-screen width, wide notification pushes UI out of screen to the right. Notification should adjust to available space instead.
Keywords: regression

Uncaught TypeError: can't access property "setAttribute", msgText is null
checkPublicRecipientsLimit chrome://messenger/content/messengercompose/MsgComposeCommands.js:5124
gRecipientObserver chrome://messenger/content/messengercompose/MsgComposeCommands.js:3830
MsgComposeCommands.js:5124:5

Looks like it may be proton related.

Assignee: nobody → lasana

(In reply to Lasana Murray from comment #3)

Looks like it may be proton related.

Probably. Thanks for looking into this, Lasana!

Status: NEW → ASSIGNED
Target Milestone: --- → 90 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/f8202094c9e2
Update public recipients warning for proton. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
See Also: → 1710245

Which release is this fixed in ? Its still broken on the "beta update" channel (currently on v89.0b4).

IMHO - this merits pulling that Bcc warning out of v89 or rolling this fix into it, as its currently a DATA LOOSING bug.

This is not hypothetical, I reported another bug with this warning bug #1712475; and only just spotted this separate bug and noticed my reply had stripped the last four recipients silently. That's bad as it essentially disrupted the entire conversation chain for those 4 people.

Comment on attachment 9217187 [details]
Bug 1706204 - Update public recipients warning for proton. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 271405
User impact if declined: After "Use BCC instead", silent dataloss of all public recipients added after the notification appeared.
Testing completed (on c-c, etc.): Yes
Risk to taking this patch (and alternatives if risky): low

Attachment #9217187 - Flags: approval-comm-beta?

(In reply to Mitra Ardron from comment #7)

Which release is this fixed in ? Its still broken on the "beta update" channel (currently on v89.0b4).
IMHO - this merits pulling that Bcc warning out of v89 or rolling this fix into it, as its currently a DATA LOOSING bug.

Thanks much Mitra for alerting us to the continued presence of this serious dataloss bug in Beta (confirmed for 89.0b4-32 on Win10).
I have requested that this bug be fixed on Beta channel.

There won't be another 89 beta, so it will get automatically fixed with 90.0b1, around June 1.

Ok Magnus, maybe that patch (to add the warning) should be backed out in 90.0b1, since apart from this bug which is hopefully fixed, there is at least one more bad bug in that patch, bug #171245 that I reported yesterday - where you can't actually decline the "move to Bcc" option since doing so leaves "Send" disabled.

Bug 1712475 (but, no idea why that would happen).

I've added more detail on Bug #1712475, these bugs may be related, i.e. the message that triggers bug #1712475 has also hit this bug, while if I reply to a reply to that message (which has fewer recipients, because of the data loss aspect of this bug) then I don't hit this bug or bug #1712475

Comment on attachment 9217187 [details]
Bug 1706204 - Update public recipients warning for proton. r=mkmelin

[Triage Comment]
this will appear in beta 90

Attachment #9217187 - Flags: approval-comm-beta? → approval-comm-beta-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: