1706219 - hang / session restore problem with upgrading devedition 88.0b9 profile ->89.0b1 on win10/64

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect, P1)

Description

[Bill Goldstein [:aja] (UTC-6)]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

Tried updating from devedition 88.0b9 to 89.0b1 on win10/64 using .zip file from archive.m.o

Actual results:

"Hangs" during startup, show a blank New Tab and non-functional address bar.

Expected results:

Should successfully startup with existing 88.0b9 profile.

Comment 1

[Bill Goldstein [:aja] (UTC-6)]

Startup works with a new profile.

NOTE: Beta seems fine.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Startup and Profile System' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 3

[Bill Goldstein [:aja] (UTC-6)]

Related crashes?
https://crash-stats.mozilla.org/report/index/d3c132f2-21fc-4b6c-8319-8c84d0210227
https://crash-stats.mozilla.org/report/index/5044c83e-b335-409e-b542-c661b0210227

Comment 4

[Bill Goldstein [:aja] (UTC-6)]

Above dumps probably unrelated...they're dated 2021-02-27 ??? (Don't understand how they'd be in new profile...strange)

Comment 5

[Pascal Chevrel:pascalc]

Dave, could you have a look please? We are not shipping devedition 89.0b1 until we understand the problem better . Thanks

Comment 6

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Attachment: deved_hang.gif

We have tried to reproduce it on Windows 10 by updating/paveover from older devedition builds and from 88.0b9 to 89.0b1 devedition but we were only able to reproduce it with new profiles (very intermittent though). A hang can be seen when first starting a session, and it takes ~5-6 seconds to launch the browser, for me and atrif these kind of hangs can be seen after that: white screen and new tab hang for a couple of seconds, then the browser works as intended.
Tried on macOS 10.15.7 and Ubuntu 20.04 and the browser window starts in ~0.5 seconds, no hangs encountered.
Here's an attachment with what we are encountering everytime with a new profile.

Comment 7

[Dave Townsend [:mossop]]

What are the steps to reproduce this?

Comment 8

[Pascal Chevrel:pascalc]

It doesn't seem we can really reproduce the bug and dataloss so we didn't block Deved beta 1 on this one but rolled it out to 25% of our users only and will stop updates if more people are experiencing a startup hang leading to a data loss.

Comment 9

[Catalin Sasca, Desktop Test Engineering [:csasca]]

We don't really have exact steps, it just happens intermittently (white screen and tab hangs after the window is launched). We noticed that when starting Firefox on Windows it takes about ~5-6 seconds to load while starting on macOS/ubuntu ~1 second, and this is reproducible every time, just by launching it from the profile manager with a new profile.

Comment 10

[Dave Townsend [:mossop]]

The 5 second delay starting up is probably bug 1553399. The white screen sounds like the blank window shown in early startup, florian can you confirm? The pause before restoring seems like a delayed session restore, any thoughts Mike?

Does this only happen when extracting the zip archive over an old install or does it also happen when installing from the installer/updater?

Comment 11

[Florian Quèze [:florian]]

(In reply to Dave Townsend [:mossop] from comment #10)

The white screen sounds like the blank window shown in early startup, florian can you confirm?

That's likely.

Having a startup profile to look at would be really useful here. To capture one, you'll need to start Firefox from a terminal, set MOZ_PROFILER_STARTUP=1 in the environment. You'll need to enable the Firefox Profiler toolbar icon (either do it in a previous run, or quickly after Firefox has started), and click it to capture the profile. Then upload it and share the permalink.

Comment 12

[Bill Goldstein [:aja] (UTC-6)]

(In reply to Dave Townsend [:mossop] from comment #10)

Does this only happen when extracting the zip archive over an old install or does it also happen when installing from the installer/updater?
No, always delete old directory, then unzip into new directory.

Glad there's been no further reports with symptoms I saw.
I understand updates have been set to 100% for 89.0b2 beta/dev this morning, so feel free to close WORKSFORME or INVALID in a few days.

Comment 13

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Dave, we reproduced this with clean downloaded zips of that build and with paveover as well. It didn't require a paveover for this to happen. Although we reproduced only a few times over many many tries.

Comment 14

[ryanclarkdev]

Hi, all. I am writing to report similar problem with Dev Edition on MacOS 11.2.3. I am happy to create a new bug if appropriate.

Last night, I restarted the browser and it automatically installed the new version. I see the new UI with a non-functioning address bar, like Bill reports. Selecting entries from History opens a new window, and nothing else happens.

After opening "About Firefox", I see my version is 89.0b2, and a button to "Restart to Update Firefox." When selected, the button does restart the browser, though nothing else changes and the button still appears in "About Firefox."

Moved existing Firefox Dev Edition to the Trash, downloaded and install a fresh copy, and the problem persists.

Comment 15

[Dave Townsend [:mossop]]

(In reply to ryanclarkdev from comment #14)

Hi, all. I am writing to report similar problem with Dev Edition on MacOS 11.2.3. I am happy to create a new bug if appropriate.

Last night, I restarted the browser and it automatically installed the new version. I see the new UI with a non-functioning address bar, like Bill reports. Selecting entries from History opens a new window, and nothing else happens.

This issue being investigated in this bug goes away after a second or two. If your issue is more persistent then you should file a new bug for it.

Comment 16

[Dave Townsend [:mossop]]

So at this point I'm not sure there is more I can do to help here, either Mike or Florian could help further particularly if a profile is available.

I'll note that I believe we don't really support installing from zip files. We don't make zips available for release and betas for this reason. So if this is only an issue for installs from zips then I don't think we should be very concerned with it.

Comment 17

[Julian Descottes [:jdescottes]]

Note that we had several similar reports on the DevTools discourse after users upgraded to 89.0b3 , but on macos: https://discourse.mozilla.org/t/my-firefox-developer-edition-does-not-work-on-macos-the-interface-is-unstable-not-responding-to-clicks-version-89-0b3/79174/9

Symptoms are similar to this bug and to Bug 1685780.

(In reply to Dave Townsend [:mossop] from comment #15)

This issue being investigated in this bug goes away after a second or two. If your issue is more persistent then you should file a new bug for it.

The initial report doesn't clearly say that the hang goes away after a few seconds. It was only mentioned in comment 6 after :csasca attempted to reproduce this. Happy to file another bug, but it seems that a complete hang is what the report was already about?

Comment 18

[William.Rogan]

I have the same problem as Bill Goldstein. Also on Windows 10

Comment 19

[Julian Descottes [:jdescottes]]

It seems that v89 hangs on startup for profiles with userValues for the preference browser.uiCustomization.state (which is automatically created when using customizable UI)

The STRs could be:

• start Firefox DevEdition v88
• set browser.uiCustomization.state to {"placements":{"widget-overflow-fixed-list":[]},"seen":["developer-button","profiler-button"],"dirtyAreaCache":[],"currentVersion":16,"newElementCount":0} (it was a value I had in a local profile)
• upgrade to DevEdition v89

Comment 20

[Mike Conley (:mconley) (:⚙️)]

Hey Mark, could this maybe be related to toolbar migration stuff?

Comment 22

[Bill Goldstein [:aja] (UTC-6)]

Confirming that original report is for a "complete hang", not a transient one that goes away after several seconds.
That said, morph this bug, or move the transient ones to another bug, as you see fit.

As Dave mentioned, installing release updates from zip files is unsupported (though it's how I've routinely updated for years).
Filed this bug primarily as a "canary in a coal mine" as suggested by a release team member on Matrix; an area for QA and release teams to keep an eye on prior to turning on updates (which they did).

Comment 23

[Dave Townsend [:mossop]]

My apologies, I misunderstood the original report. Sounds like not a session restore thing.

Comment 24

[Bill Goldstein [:aja] (UTC-6)]

FWIW, https://discourse.mozilla.org/t/my-firefox-developer-edition-does-not-work-on-macos-the-interface-is-unstable-not-responding-to-clicks-version-89-0b3/79174/20 suggests deletion of browser.uiCustomization.state before update avoids the problem on MacOs.

I may very well have customized the toolbar (to add/remove extension icons) at some point over the life of my old profile.

Comment 25

[Mark Striemer [:mstriemer]]

This does indeed appear to be related to the proton toolbar migration. Using the pref data from comment 19 to start a new profile locally with:

./mach run --setpref 'browser.uiCustomization.state={"placements":{"widget-overflow-fixed-list":[]},"seen":["developer-but ton","profiler-button"],"dirtyAreaCache":[],"currentVersion":16,"newElementCount":0}'

We get an exception in the migration code at https://searchfox.org/mozilla-central/rev/37edd2782e67e716dd07a85016da07b4d6275e5d/browser/components/customizableui/CustomizableUI.jsm#656

Comment 26

[Mark Striemer [:mstriemer]]

Attachment: Bug 1706219 - Handle empty placements in proton toolbar migration r?emalysz,mconley

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80ec1e7b64c8
Handle empty placements in proton toolbar migration r=emalysz,mconley

Comment 28

[Mark Striemer [:mstriemer]]

Attachment: Bug 1706219 - Handle gSavedSate without placements in proton toolbar migration r?gijs

Depends on D113423

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0047c4c8787
Handle gSavedSate without placements in proton toolbar migration r=Gijs

Comment 32

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/80ec1e7b64c8
https://hg.mozilla.org/mozilla-central/rev/f0047c4c8787

Comment 34

[Pascal Chevrel:pascalc]

Mark, can you request an uplift to beta? We have multiple dupes on this one and I'd like to make sure we don't hit this on the release channel. Thanks!

Comment 35

[Mark Striemer [:mstriemer]]

Comment on attachment 9218515 [details]
Bug 1706219 - Handle gSavedSate without placements in proton toolbar migration r?gijs

Beta/Release Uplift Approval Request

• User impact if declined: Could get into a broken window and hang with upgrade to proton

Required for MR1 / Proton

• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 19
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Adds null checks, includes tests
• String changes made/needed: None

Comment 36

[Pascal Chevrel:pascalc]

Comment on attachment 9218515 [details]
Bug 1706219 - Handle gSavedSate without placements in proton toolbar migration r?gijs

Approved for 89 beta 5, thanks.

Comment 37

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/fe8ace43dcd0
https://hg.mozilla.org/releases/mozilla-beta/rev/3f2528a3a80b

Comment 38

[William.Rogan]

Many thanks!

It works again

Comment 39

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Verified that the hangs aren't occurring anymore when updating from Firefox 88 to 89.0b5 and 90.0a1 (2021-04-28). Tests were performed on Windows 10, Ubuntu 20.04 and macOS 10.15.7

Comment 40

[chris.firefox]

Also confirming, hang no longer occuring for me when attempting to run the problem profile in 90.0a1 (2021-04-28). And after restoring the profile back to its state on 25/Apr, FF DE 89.0b5 I was also able to start with the problem profile (MacOS 10.15.7).