1706404 - Change all Get(Own)PropertyDescriptor callers to using Maybe<PropertyDescriptor>

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Comment 1

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1706404 - Remove internal non-Maybe GetOwnPropertyDescriptor overload. r?jandem

Comment 2

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1706404 - Change internal GetPropertyDescriptor to use Maybe and return holder object seperately. r?jandem

Depends on D112790

Comment 3

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1706404 - Add JS_GetOwnPropertyDescriptorById Maybe<PropertyDescriptor> overload. r?jandem

Depends on D112917

Comment 4

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1706404 - Convert some simple cases to the Maybe<PropertyDescriptor> API. r?smaug

I am going to chip away at replacing all callers that don't use the Maybe based API.

Depends on D113017

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f506b5e43ace
Remove internal non-Maybe GetOwnPropertyDescriptor overload. r=jandem
https://hg.mozilla.org/integration/autoland/rev/ef0366119194
Change internal GetPropertyDescriptor to use Maybe and return holder object seperately. r=jandem
https://hg.mozilla.org/integration/autoland/rev/4848bc176c9a
Add JS_GetOwnPropertyDescriptorById Maybe<PropertyDescriptor> overload. r=jandem

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/f506b5e43ace
https://hg.mozilla.org/mozilla-central/rev/ef0366119194
https://hg.mozilla.org/mozilla-central/rev/4848bc176c9a

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b6120126874
Convert some simple cases to the Maybe<PropertyDescriptor> API. r=smaug

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/5b6120126874

Comment 9

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1706404 - BaseDOMProxyHandler::getOwnPropertyDescriptor should return Maybe<PropertyDescriptor>. r?smaug

Comment 10

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1706404 - Use Maybe<PropertyDescriptor> for JS_GetPropertyDescriptor in js/. r?jandem

Depends on D113660

Comment 11

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1706404 - Use Maybe<PropertyDescriptor> more in XPConnect. r?smaug

The current defineProperty code sadly uses existing_desc.object() to check
if the property is being defined would shadow an own property.

All of this code is not really something that we should be doing, but I am not even sure how we would replace GetPropertyDescriptor
with GetOwnPropertyDescriptor here.

Depends on D113661

Comment 12

[Tom S. (please needinfo tschuster)]

At this point there incremental improvements are getting a lot harder. I am going to open a new bug to completely switch all code away from using object.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0c0700ce719
BaseDOMProxyHandler::getOwnPropertyDescriptor should return Maybe<PropertyDescriptor>. r=smaug
https://hg.mozilla.org/integration/autoland/rev/b50507879a6b
Use Maybe<PropertyDescriptor> for JS_GetPropertyDescriptor in js/. r=jandem
https://hg.mozilla.org/integration/autoland/rev/5ecbe2eb1d25
Use Maybe<PropertyDescriptor> more in XPConnect. r=smaug

Comment 14

[Dorel Luca [:dluca]]

Backed out 3 changesets (bug 1706404) for Linting failures in builds/worker/checkouts/gecko/dom/bindings/Codegen.py. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=338195156&repo=autoland&lineNumber=449

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=5ecbe2eb1d259cf422dc6187b9e73a6ebdaf41b4

Backout:
https://hg.mozilla.org/integration/autoland/rev/c00df77af50e0703d37188be7c57032713e6efec

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed6bfacabd45
BaseDOMProxyHandler::getOwnPropertyDescriptor should return Maybe<PropertyDescriptor>. r=smaug
https://hg.mozilla.org/integration/autoland/rev/e9316277cf28
Use Maybe<PropertyDescriptor> for JS_GetPropertyDescriptor in js/. r=jandem
https://hg.mozilla.org/integration/autoland/rev/aba0c1734f17
Use Maybe<PropertyDescriptor> more in XPConnect. r=smaug

Comment 16

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/ed6bfacabd45
https://hg.mozilla.org/mozilla-central/rev/e9316277cf28
https://hg.mozilla.org/mozilla-central/rev/aba0c1734f17