1706483 - Make some more debugger tests work with native menus

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, task)

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1706483 - Make callers of selectContextMenuItem wait for the context menu to open before calling selectContextMenuItem. r=jdescottes

This makes it work with native menus, which open asynchronously and which do not
support EventUtils.synthesizeMouseAtCenter on menuitems.

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1706483 - Make openContextMenuSubmenu wait for the submenu to open. r=harry

Without this, devtools/client/debugger/test/mochitest/browser_dbg-watchpoints.js
was timing out for me locally with non-native menus.

Depends on D112826

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1706483 - Use openContextMenuSubmenu and activateItem in browser_dbg-watchpoints.js. r=#mac-reviewers

Depends on D112839

Comment 4

[Markus Stange [:mstange]]

Attachment: Bug 1706483 - In browser_dbg-watchpoints.js and browser_dbg-blackbox-all.js, make sure the menu is open before calling openContextMenuSubmenu or selectContextMenuItem on it. r=#mac-reviewers

Depends on D112840

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09a8cbbf6373
Make callers of selectContextMenuItem wait for the context menu to open before calling selectContextMenuItem. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/583cf0746e25
Make openContextMenuSubmenu wait for the submenu to open. r=harry
https://hg.mozilla.org/integration/autoland/rev/ab51ffaaa218
Use openContextMenuSubmenu and activateItem in browser_dbg-watchpoints.js. r=mac-reviewers,harry
https://hg.mozilla.org/integration/autoland/rev/6afd3dc2b375
In browser_dbg-watchpoints.js and browser_dbg-blackbox-all.js, make sure the menu is open before calling openContextMenuSubmenu or selectContextMenuItem on it. r=mac-reviewers,bradwerth

Comment 6

[Markus Stange [:mstange]]

https://treeherder.mozilla.org/jobs?repo=try&revision=8eb15956ae5e69989e87b558b6b71fc639d91cbd

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/09a8cbbf6373
https://hg.mozilla.org/mozilla-central/rev/583cf0746e25
https://hg.mozilla.org/mozilla-central/rev/ab51ffaaa218
https://hg.mozilla.org/mozilla-central/rev/6afd3dc2b375

Comment 8

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/b916d042902d
https://hg.mozilla.org/releases/mozilla-beta/rev/fdd6e63c4300
https://hg.mozilla.org/releases/mozilla-beta/rev/29de2678961d
https://hg.mozilla.org/releases/mozilla-beta/rev/921eba4a3af0