1706652 - [macOS] The browser's "Close" button is not disabled if a modal (such as the existing/updating users Onboarding modal) is displayed

Status: RESOLVED WONTFIX

(Core :: Widget: Cocoa, defect)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Affected versions]:

• Firefox Beta 89.0b2 - Build ID: 20210420191345
• Firefox Nightly 90.0a1 - Build ID: 20210421095627

[Affected Platforms]:

• macOS

[Prerequisites]:

• Have a Firefox 88 version or older installed.

[Steps to reproduce]:

1. Open the browser from the prerequisites and update it.
2. Click the browser's "Close" button.
3. Observe the behavior.

[Expected result]:

• Nothing happens.

[Actual result]:

• The button is actionable and the "Close this browser" confirmation message is displayed after the modal is dismissed.

[Additional Notes]:

• This issue is not reproducible on Windows and Linux.
• Attached a screen recording of the issue.

Comment 1

[:Gijs (he/him)]

(In reply to Marius Coman [:mcoman], Ecosystem QA from comment #0)

• This issue is not reproducible on Windows and Linux.
• Attached a screen recording of the issue.

I imagine it's reproducible if you enable the titlebar in customize mode, and perhaps on Windows 7 even without that - can you check?

Otherwise, I don't know how this works on Linux, but on Windows 10 we paint our own close buttons, which is how they are inaccessible when there's a mask on the window. On macOS (and Windows 7, I think?), I think we let the OS paint the buttons. We might be able to tell the OS that the buttons should be disabled in response to the window entering/leaving modal state, but we appear not to be doing that right now.

Romain, can we clarify how you want to prioritize this issue? It's likely to be non-trivial engineering work that would need platform involvement if we think this needs addressing for MR1.

Comment 2

[Marius Coman [:mcoman], Ecosystem QA]

(In reply to :Gijs (he/him) from comment #1)

(In reply to Marius Coman [:mcoman], Ecosystem QA from comment #0)

• This issue is not reproducible on Windows and Linux.
• Attached a screen recording of the issue.

I imagine it's reproducible if you enable the titlebar in customize mode, and perhaps on Windows 7 even without that - can you check?

Hi Gijs, I have tested this issue with the titlebar enabled on Windows 10 x64, Windows 7 x64, and Linux Mint 20. You can find the results below:

• Windows 10 x64 - This issue is reproducible with the titlebar enabled, the browser's "Close" button becomes actionable even if the existing users Onboarding modal is displayed.
• Windows 7 x64 - The issue is not reproducible by default, but the browser's "Close" button becomes actionable if the titlebar is enabled from the "Customization" menu.
• Linux Mint 20 - This issue is reproducible with the titlebar enabled, the browser's "Close" button becomes actionable even if the existing users Onboarding modal is displayed.
• macOS 10.15.7 - This issue is reproducible even if the titlebar is not enabled.

I hope it helps. Also, if you will need extra information, you can ping me here or on Slack (mcoman).

Comment 3

[Romain Testard [:RT]]

I'll mark this as "Won't fix" given that:

• I don't think that prevent browser closure with this modal is actually a requirement
• If this behavior is desirable it seems low value/high complexity and won't be applicable post MR1 (the bug becomes invalid post MR1 where this modal won't display again)