1706963 - The browser's "Close tabs and exit?" confirmation message is not displayed if the browser's "Close" button is clicked while the existing users Onboarding modal is displayed

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P2)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue (2).gif

[Notes]:

• This issue is a follow-up of Bug 1706652 where it was decided that on macOS the browser's "Close" button will remain active while the existing users Onboarding modal is displayed. Considering this, if the "Close" button will be clicked the browser will not be closed and the "Close tabs and exit?" confirmation message will be added to the queue until the Onboarding modal will be dismissed.

[Affected versions]:

• Firefox Beta 89.0b2 - Build ID: 20210420191345
• Firefox Nightly 90.0a1 - Build ID: 20210421212740

[Affected Platforms]:

• macOS 10.15.7
• macOS 11.2.3

[Prerequisites]:

• Have a Firefox 88 version or older installed.

[Steps to reproduce]:

1. Open the browser from the prerequisites and update it.
2. Click the browser's "Close" button.
3. Observe the behavior.

[Expected result]:

• The existing users Onboarding modal is dismissed and the "Close tabs and exit?" confirmation message is displayed.

[Actual result]:

• Nothing happens.

[Additional Notes]:

• This issue is not reproducible on Windows and Linux because the browser's "Close" button is not accessible.
• Attached a screen recording of the issue.

Comment 1

[Ed Lee :Mardak]

Attachment: Bug 1706963 - Close other window modal subdialog before quit/close window prompts r?Gijs

Allow setting a document.mozSubDialogRequestYield that gets called when another subdialog is trying to open. Have upgrade dialog close when requested.

Comment 2

[Ed Lee :Mardak]

As noted in bug 1706652 comment 2, this can happen on platforms when one turns on the titlebar.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/178fd61bc6cb
Close other window modal subdialog before quit/close window prompts r=Gijs

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/178fd61bc6cb

Comment 5

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (90.0a1 Build ID - 20210524084213) installed on macOS 10.15.7. Now I can confirm that the Upgrade modal is dismissed and the "Close tabs and exit?" confirmation message is displayed if the browser's "Close" button is clicked.

Comment 7

[Ed Lee :Mardak]

Some reason I can't comment in bug 1705365 but that other bug potentially is WONTFIX now that this bug made it so multiple quit/close prompts don't end up open at the same time avoiding the nested event loop spinning. Unless there are other places that nest spinning?

Bugzilla has suffered an internal error:
bug is not a valid parameter for the Bugzilla::Comment::create function. 
count is not a valid parameter for the Bugzilla::Comment::create function.