1706723 - Some add-ons have empty space on popup when opened from overflow menu

Status: RESOLVED DUPLICATE of bug 1448276

(Firefox :: Foxfooding, defect)

Description

[Peter deHaan [:pdehaan]]

This comment is copy/pasted from a community issue filed during the Foxfooding program.

---

Firefox Version: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0
Window Size (inner width and height): 1920x978

Steps to Reproduce

1. Put Facebook Container or uBlock Origin addon to overflow menu
2. Click to open it

Expected Behavior

Add-ons should fill the entire popup just like when opening outside of the overflow menu

Actual Behavior

There was empty space

Comment 1

[Peter deHaan [:pdehaan]]

Attachment: Facebook Container add-on (toolbar)

Comment 2

[Peter deHaan [:pdehaan]]

Attachment: Facebook Container add-on (overflow)

Comment 3

[Peter deHaan [:pdehaan]]

My guts are telling me this is probably an issue w/ the CSS stylings of each add-on, where it assumes its parent container is a static width, and the overflow menu is slighter wider -- but they aren't using a fluid layout.
I can see if Maxx or Lesley are familiar with the Facebook Container stylings and can confirm that theory.

Found this old issue, so I don't think this isn't a Proton specific regression. https://github.com/mozilla/contain-facebook/issues/231#issuecomment-648590561

Plus https://github.com/mozilla/contain-facebook/issues/234, which links us to a 4 year old Bugzilla issue that is still open (and possibly related): https://bugzilla.mozilla.org/show_bug.cgi?id=1373490

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Peter deHaan [:pdehaan] from comment #3)

My guts are telling me this is probably an issue w/ the CSS stylings of each add-on, where it assumes its parent container is a static width, and the overflow menu is slighter wider -- but they aren't using a fluid layout.
I can see if Maxx or Lesley are familiar with the Facebook Container stylings and can confirm that theory.

Found this old issue, so I don't think this isn't a Proton specific regression. https://github.com/mozilla/contain-facebook/issues/231#issuecomment-648590561

Plus https://github.com/mozilla/contain-facebook/issues/234, which links us to a 4 year old Bugzilla issue that is still open (and possibly related): https://bugzilla.mozilla.org/show_bug.cgi?id=1373490

Definitely not a new issue on its own, this has been reported in the past (it is not a new regression neither, I think this has been an issue from as long as I can remember, which is basically from when the browserAction button has been originally introduced) and from what I see in this report it doesn't seem there is any new detail specifically related to any of the Proton changes.

We can either make this a duplicate of one of the pre-existing issue with the browserAction popups opened from the overflow menu (e.g. Bug 1448276) or make this one to block the meta Bug 1459046 if there are reasons to believe this is a different variation of that class of issues.

Comment 5

[Romain Testard [:RT]]

I'm marking as a dupe of bug 1448276 since this indeed seels like the same issue.