1706777 - Download Panel "find in folder" button is missing hover/active state

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, defect, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

According to the specification, if the user is hovering the "Find in folder" button, then it should use the "ghost button" hover/active states. If they're hovering any other part of the download item, then the entire download item should show the current hover state.

I'm not 100% sure this can be done with CSS - the cascade doesn't let us affect the state of the containing download item element when hovering the child find-in-folder item.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Turns out we must have been dealing with this before - a .downloadHoveringButton class is applied on the root richlistitem when hovering the button.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1706777 - Apply ghost-button styling to Downloads Panel's Show In Folder button. r?mak!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39959393568c
Apply ghost-button styling to Downloads Panel's Show In Folder button. r=mak,desktop-theme-reviewers,harry

Comment 4

[Ciprian Georgiu, Desktop QA]

Hi Mike, it seems that hover effect is also missing for the cancel and retry buttons, will these issues be fixed with this patch? Otherwise, we can file separate bugs to track them.

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/39959393568c

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Yes, this should address that too.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9217912 [details]
Bug 1706777 - Apply ghost-button styling to Downloads Panel's Show In Folder button. r?mak!

Beta/Release Uplift Approval Request

• User impact if declined: Required for MR1 / Proton
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): A very simple almost CSS-only patch that carries forward some pre-Proton rules for download panel buttons.
• String changes made/needed: None.

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9217912 [details]
Bug 1706777 - Apply ghost-button styling to Downloads Panel's Show In Folder button. r?mak!

Approved for 89 beta 6, thanks.

Comment 9

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/7de9a7eafed1