1706978 - Apply the density settings to the AppMenu and Windows 10 Proton menus

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

The Proton AppMenu and the Windows 10 menus are very tall. We should reduce this depending of the density setting. The actual dimensions would be good for the Touch setting.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1706978-menu-density.patch

This patch needs bug 1706895 applied first.

I had to remove the on-hover apply because this made the menu jump like crazy on Windows 10. The pre-patch dimensions are the Touch dimensions with this patch. The two other are smaller.

I'll attach a screenshot of the Win 10 menu.

I cleaned also some media queries to really apply only on Win 10 and checked that older Windows still look like before.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Win10-menu-density.png

The different density settings on the Windows 10 menus.

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9217745 [details] [diff] [review]
1706978-menu-density.patch

Review of attachment 9217745 [details] [diff] [review]:
-----------------------------------------------------------------

This bitrotted a bit with the latest trunk.
Can you update the patch, please?

Comment 4

[Richard Marti (:Paenglab)]

You have applied bug 1706895 first as I wrote in comment 1?

Comment 5

[Alessandro Castellani [:aleca]]

Ah, sorry, I missed that, let me review it again.

Comment 6

[Alessandro Castellani [:aleca]]

Comment on attachment 9217745 [details] [diff] [review]
1706978-menu-density.patch

Review of attachment 9217745 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, thanks.

Comment 7

[Richard Marti (:Paenglab)]

Attachment: 1706978-menu-density.patch

Updated the patch to apply without bug 1706895.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/004a96e6608d
Apply the density settings to the AppMenu and Windows 10 Proton menus. r=aleca

Comment 9

[Richard Marti (:Paenglab)]

Comment on attachment 9217840 [details] [diff] [review]
1706978-menu-density.patch

[Approval Request Comment]
User impact if declined: too big menus for Windows 10 users
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low, it would be good to get early feedback of this feature

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9217840 [details] [diff] [review]
1706978-menu-density.patch

[Triage Comment]
Approved for beta

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 89.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/1184bd8e04b9