Closed Bug 1707126 Opened 4 years ago Closed 4 years ago

Merge nsIRadioGroupContainer implementation of DocumentOrShadowRoot and HTMLFormElement

Categories

(Core :: DOM: Forms, task, P2)

Product:
Core
Component:
DOM: Forms
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: saschanaz, Assigned: saschanaz)

References

Details

Attachments

(2 files)

Bug 1707126 - Part 1: Split RadioGroupManager r=smaug
48 bytes, text/x-phabricator-request
Details | Review
Bug 1707126 - Part 2: Use RadioGroupManager in HTMLFormElement r=smaug
48 bytes, text/x-phabricator-request
Details | Review

It seems the major difference is that DocumentOrShadowRoot uses nsRadioGroupStruct while HTMLFormElement uses several of its own members (mControls, mSelectedRadioButtons, mRequiredRadioButtonCounts, and mValueMissingRadioGroups). It would be great if we can separate the form part from DocumentOrShadowRoot and apply it to HTMLFormElement, and ultimately to any disconnected elements for bug 1685926.

Assignee: nobody → krosylight
See Also: 1685926 →
Severity: -- → N/A
Priority: -- → P2
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/286ed5c750e2 Part 1: Split RadioGroupManager r=smaug https://hg.mozilla.org/integration/autoland/rev/8d711949a98c Part 2: Use RadioGroupManager in HTMLFormElement r=smaug

https://hg.mozilla.org/mozilla-central/rev/286ed5c750e2
https://hg.mozilla.org/mozilla-central/rev/8d711949a98c

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Regressions: 1708702
Regressions: 1837540
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: