1708228 - Remove the flush parameter for HTMLFormElement::DoResolveName and its callers

Status: RESOLVED FIXED

(Core :: DOM: Forms, task, P2)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

The context https://phabricator.services.mozilla.com/D113578#3690585:

The flushing is added in bug 324828 to workaround bug 22480 which is fixed a few years later. So it should be safe to keep the flushing calls removed here, and I'll remove the flush parameters as a followup.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1708228 - Part 1: Remove redundant flushing from HTMLFormControlsCollection r=smaug

This was done in bug 324828 to workaround bug 22480 but shouldn't be needed anymore.

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1708228 - Part 2: Remove redundant flush param from nsIRadioGroupContainer r=smaug

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1708228 - Part 3: Remove aNotify from HTMLInputElement::VisitGroup r=smaug

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1708228 - Part 4: Remove aNotify from nsRadioSetValueMissingState r=smaug

It already had no use before the patches.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ec00f0f1ff9
Part 1: Remove redundant flushing from HTMLFormControlsCollection r=smaug
https://hg.mozilla.org/integration/autoland/rev/553dabb2eae4
Part 2: Remove redundant flush param from nsIRadioGroupContainer r=smaug
https://hg.mozilla.org/integration/autoland/rev/d2341976ad40
Part 3: Remove aNotify from HTMLInputElement::VisitGroup r=smaug
https://hg.mozilla.org/integration/autoland/rev/3d755eded726
Part 4: Remove aNotify from nsRadioSetValueMissingState r=smaug

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/0ec00f0f1ff9
https://hg.mozilla.org/mozilla-central/rev/553dabb2eae4
https://hg.mozilla.org/mozilla-central/rev/d2341976ad40
https://hg.mozilla.org/mozilla-central/rev/3d755eded726