1707190 - The Warning badge for an "Extension requires new permissions" notification from the Hamburger menu icon is misaligned

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P2)

Description

[Rares Doghi, Desktop QA]

Attachment: multiplePermissionRequests.png

[Affected platforms]:
Platforms: All

[Steps to reproduce]

1. Launch the Firefox browser and install a few older addons like :
   Install version 1.35.2 of Bitwarden – Free Password manager - https://addons.mozilla.org/en-US/firefox/addon/bitwarden-password-manager/versions/?utm_content=search&utm_medium=referral&utm_source=addons.mozilla.org
   install version 7.0.0 of New Tab Override - https://addons.mozilla.org/en-US/firefox/addon/new-tab-override/versions/?utm_content=recommended_fallback&utm_medium=referral&utm_source=addons.mozilla.org

2. Set the extensions.update.interval - 10

3. Restart the Browser and wait for the Menu notifications to be displayed.

[Expected result]
The Warning Badge should be on top of the Hamburger menu icon (3 lines).

[Actual result]
The Warning badge is to the Right of the 3 lines (Hamburger menu) instead of on top of them (part of the top right corner).

Comment 1

[Emma Malysz]

Attachment: Bug 1707190, update warning and notification icons for app menu badges

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d24540ca38d
update warning and notification icons for app menu badges r=sfoster

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4d24540ca38d

Comment 4

[Rares Doghi, Desktop QA]

So even though the new icon is displayed, this particular case for the extension requires new permissions case the icon from the badge is still misaligned, its all the way to the right. Ill attach a new screenshot for it.

Comment 5

[Rares Doghi, Desktop QA]

Attachment: Missaligned.png

Comment 6

[Emma Malysz]

Hey Rares, thanks for reporting. Which platform are you on? I was having trouble reproducing on macos.

I also noticed the fxa-needs-authentication still uses the full app menu icon. I can file a follow up. I think what we'll need to do to improve this is:

1. Add #PanelUI-menu-button[badge-status="addon-alert"] > .toolbarbutton-badge-stack > .toolbarbutton-badge to this list: https://searchfox.org/mozilla-central/rev/6b099d836c882bc155d2ef285e0ad0ab9f5038f6/browser/themes/shared/customizableui/panelUI.inc.css#117

2. Add fxa-needs-authentication to here https://searchfox.org/mozilla-central/rev/6b099d836c882bc155d2ef285e0ad0ab9f5038f6/browser/themes/shared/toolbarbutton-icons.inc.css#281

Comment 7

[Rares Doghi, Desktop QA]

Hi Emma, it seems this issue only occurs on Windows and Ubuntu. Mac looks great.

Comment 8

[Rares Doghi, Desktop QA]

Hi Emma.. I just got what you meant by the FxA addon=alert issue for when the user is disconnected , the badge from the FxA icon is still the Warning sign with the exclamation mark inside, did you log any follow up issue for it ? or should I log one now ?

Comment 9

[Rares Doghi, Desktop QA]

Also, should we log a new issue for Windows and Ubuntu ? or should we reopen this one ?

Comment 10

[Emma Malysz]

Filed both as separate issues. Thanks again for reporting!

Comment 11

[Rares Doghi, Desktop QA]

Since this fix remained for Mac only I will update the flags to Verified since this issue no longer occurs on Mac in our latest Nightly builds.