Closed
Bug 1711083
Opened 5 years ago
Closed 5 years ago
Fix padding for warning icon on linux/windows
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
VERIFIED
FIXED
90 Branch
People
(Reporter: emmamalysz, Assigned: emmamalysz)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression, Whiteboard: [proton-appmenu-notifications])
Attachments
(1 file)
See https://bugzilla.mozilla.org/show_bug.cgi?id=1707190#c5.
The new warning icon (introduced in Bug 1707190) needs a different margin value for the badge on windows and linux. It relies on the rules for .toolbarbutton-badge
Note, in that bug we already handled the mac case
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/27548e3039fc
fix margins for toolbar button badges on windows and linux r=mhowell
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox90:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
|
||
Comment 4•5 years ago
|
||
This issue is Verified as fixed in our latest Nightly build 90.0a1 (2021-05-14) on Windows and Linux, I will update the flag for Beta in the hopes that maybe it will get uplifted.
status-firefox89:
--- → affected
|
||
Comment 5•5 years ago
|
||
The patch landed in nightly and beta is affected.
:emalysz, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.
For more information, please visit auto_nag documentation.
Flags: needinfo?(emalysz)
|
|
Assignee | |
Updated•5 years ago
|
Flags: needinfo?(emalysz)
|
|
||
Comment 6•5 years ago
|
||
Updating the status flag for this issue since it wont be uplifted to beta.
Status: RESOLVED → VERIFIED
|
||
Updated•5 years ago
|
Keywords: regression
|
||
Updated•5 years ago
|
Has Regression Range: --- → yes
|
||
Updated•4 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•