1707211 - stop using content/ css - move the css to the shared theme file instead

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Magnus Melin [:mkmelin]]

content/ .css is not useful anymore now that xbl is gone and 3rd party full themes do not exist anymore.

The distinction of what is styling and structure is fluent enough that it makes sense to move such css into the platform shared file instead.

Comment 1

[Magnus Melin [:mkmelin]]

https://searchfox.org/comm-central/search?q=content%2F.*.css&path=jar.mn&case=false&regexp=true

See mail/themes/shared/jar.inc.mn

Comment 2

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Merge newmailalert.css content into skin. r=mkmelin

Comment 3

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Move glodacomplete.css into themes. r=mkmelin

Comment 4

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Move fieldMapImport.css into themes. r=mkmelin

Comment 5

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Merge am-server.css into accountManage.css. r=mkmelin

Comment 6

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Move content calendar CSS files into themes/common. r=darktrojan

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9b74c095efbd
Merge newmailalert.css content into skin. r=mkmelin
https://hg.mozilla.org/comm-central/rev/88701f939fe0
Move glodacomplete.css into themes. r=mkmelin
https://hg.mozilla.org/comm-central/rev/237515af017b
Move fieldMapImport.css into themes. r=mkmelin

Comment 8

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Drop notification.css. r=mkmelin

This stylesheet is intended for xul:notification elements. However, these are unused (instead, notifications use xul:notification-message elements, which uses message-bar.css).

Comment 9

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Merge tabmail.css content into skin. r=mkmelin

Comment 10

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Move content/multimessageview.css into themes/shared. r=mkmelin

Comment 11

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Move content/customizeToolbar.css into themes/shared. r=mkmelin

Also removed MOZ_SUITE checks from customizeToolbar.xhtml since it is not a shared file.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/421848d544b8
Merge am-server.css into accountManage.css. r=mkmelin
https://hg.mozilla.org/comm-central/rev/39059485f991
Move content calendar CSS files into themes/common. r=darktrojan
https://hg.mozilla.org/comm-central/rev/942ea0363403
Drop notification.css. r=mkmelin
https://hg.mozilla.org/comm-central/rev/c1285eaf5e9c
Merge tabmail.css content into skin. r=mkmelin
https://hg.mozilla.org/comm-central/rev/70327f18e16c
Move content/multimessageview.css into themes/shared. r=mkmelin
https://hg.mozilla.org/comm-central/rev/ff5255d2cdf5
Move content/customizeToolbar.css into themes/shared. r=mkmelin

Comment 13

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Move aboutAddonsExtra.css into themes. r=mkmelin

Comment 14

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Merge messenger.css content into shared/skin. r=mkmelin

Comment 15

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Move content/glodaFacetView.css into themes/shared. r=mkmelin

Comment 16

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Move tree-listbox.css into themes. r=darktrojan

Comment 17

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Move converterDialog.css into themes. r=mkmelin

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0248e301860e
Move aboutAddonsExtra.css into themes. r=mkmelin

Comment 19

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Move content/menulist.css into themes/shared. r=mkmelin

Comment 20

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Merge multimessageview_print.css into multimessageview.css. r=mkmelin

Comment 21

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Move santizeDialog.css into themes. r=mkmelin

Comment 22

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Merge sharedsummary.css into multimessageview.css. r=mkmelin

Depends on D125568

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1392ebed9caf
Merge messenger.css content into shared/skin. r=mkmelin
https://hg.mozilla.org/comm-central/rev/d9d46bb38f5c
Move content/glodaFacetView.css into themes/shared. r=mkmelin
https://hg.mozilla.org/comm-central/rev/82eb38836661
Move converterDialog.css into themes. r=mkmelin
https://hg.mozilla.org/comm-central/rev/ff39f6fe10e8
Move content/menulist.css into themes/shared. r=mkmelin
https://hg.mozilla.org/comm-central/rev/766aef629be7
Merge multimessageview_print.css into multimessageview.css. r=mkmelin
https://hg.mozilla.org/comm-central/rev/ccc2b47a5cf8
Move santizeDialog.css into themes. r=mkmelin
https://hg.mozilla.org/comm-central/rev/6a13079a529f
Merge sharedsummary.css into multimessageview.css. r=mkmelin

Comment 24

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Move composerOverlay.css into themes. r=mkmelin

Comment 25

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Remove hide-private.css. r=mkmelin

Comment 26

[Henry Wilkes (they/them) [:henry-x]]

Do you think mail/components/cloudfile/content/selectDialog.css should be moved to

1. mail/themes/shared/mail/selectDialog.css,
2. mail/themes/shared/mail/cloudfileSelectDialog.css (with or without renaming the other cloudfile selectDialog* files), or
3. mail/themes/shared/mail/cloudfile/selectDialog.css?

Comment 27

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Move aboutPolicies.css into themes. r=mkmelin

Comment 28

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Move EditorContent.css into themes. r=mkmelin

Comment 29

[Henry Wilkes (they/them) [:henry-x]]

Also, if you look at something like imAccountWizard.css, it is stored in mail/components/im/themes, but is registered in mail/themes/linux/jar.mn. chat.css is similarly spread around.

Should we move all of the content of mail/components/im/themes into either chat/themes or mail/themes?

Comment 30

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - fixup rev 6a13079a529f. r=mkmelin

Comment 31

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Move addressbook print.css into themes. r=darktrojan

Comment 32

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/379f5a94f1f4
fixup rev 6a13079a529f. r=mkmelin

Comment 33

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d0f498534a79
Move composerOverlay.css into themes. r=mkmelin
https://hg.mozilla.org/comm-central/rev/e27e576b82b7
Remove hide-private.css. r=mkmelin
https://hg.mozilla.org/comm-central/rev/aea746d01c9a
Move aboutPolicies.css into themes. r=mkmelin
https://hg.mozilla.org/comm-central/rev/f70d87a3f162
Move EditorContent.css into themes. r=mkmelin

Comment 34

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dc4d76159758
Move tree-listbox.css into themes. r=darktrojan
https://hg.mozilla.org/comm-central/rev/de35d92fd3ea
Move addressbook print.css into themes. r=darktrojan DONTBUILD

Comment 35

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1707211 follow-up - Update a test to match. r=mkmelin

I've stopped encoding the strings in this test since btoa is now available in the test context. The values are the same as before with the stylesheet URL changed.

Comment 36

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/23d8c3c61de0
follow-up - Update a test to match. r=mkmelin

Comment 37

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Move extensionPopup.css into themes. r=mkmelin

Comment 38

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Merge handlers.css into applications.css. r=mkmelin

Comment 39

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Remove openpgp/ui/*.css entry. r=mkmelin

There are no CSS files in this directory.

Comment 40

[Henry Wilkes (they/them) [:henry-x]]

Files still to go are:

• mail/components/cloudfile/content/selectDialog.css - See comment 26.
• mail/components/im/content/chat.css - See comment 29.
• mail/base/content/aboutDialog.css - See Bug 1728474, which is moving the file.
• mail/branding/thunderbird/content/aboutDialog.css - Being edited in the same bug, but it is not being moved. I'm not sure if or where to move this.
• mail/branding/nightly/content/aboutDialog.css - Same as above.

Let me know what the approach should be for these.

Comment 41

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fbf0197084ab
Move extensionPopup.css into themes. r=mkmelin
https://hg.mozilla.org/comm-central/rev/111c9676bb8b
Merge handlers.css into applications.css. r=mkmelin
https://hg.mozilla.org/comm-central/rev/cc5655a05392
Remove openpgp/ui/*.css entry. r=mkmelin

Comment 42

[Magnus Melin [:mkmelin]]

(In reply to Henry Wilkes [:henry] from comment #26)

Do you think mail/components/cloudfile/content/selectDialog.css should be moved to
2. mail/themes/shared/mail/cloudfileSelectDialog.css (with or without renaming the other cloudfile selectDialog* files), or

I'd go for this, and not renaming the other files there.

(In reply to Henry Wilkes [:henry] from comment #29)

Also, if you look at something like imAccountWizard.css, it is stored in mail/components/im/themes, but is registered in mail/themes/linux/jar.mn. chat.css is similarly spread around.

Should we move all of the content of mail/components/im/themes into either chat/themes or mail/themes?

I'd move it into mail/themes.

Re the branding, not sure but there is a prior example of using things to theme/ there:
https://searchfox.org/comm-central/rev/ddc5727d39202eaa94d280a4a5ba8d9532e5a9ec/mail/branding/thunderbird/jar.mn

Comment 43

[Richard Marti (:Paenglab)]

The two branding aboutDialog.css are different and moving them to /theme/ would also need new branding folders which then have only one file in it. Maybe it's better to leave them there they are to let it simple to know what all belongs to the specific branding.

Comment 44

[Henry Wilkes (they/them) [:henry-x]]

(In reply to Richard Marti (:Paenglab) from comment #43)

The two branding aboutDialog.css are different and moving them to /theme/ would also need new branding folders which then have only one file in it. Maybe it's better to leave them there they are to let it simple to know what all belongs to the specific branding.

Yes, I don't think moving them into mail/themes makes sense. I wonder if, since the branding directories already include a locales sub-directory for translations, we could similarly include a themes sub-directory.

And maybe move the icons into there as well. Perhaps in a separate bug, since we have icons placed under "content" chrome paths, which probably need a similar treatment to the CSS files in this bug.

Comment 45

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Move cloudfile selectDialog.css into themes. r=mkmelin

Comment 46

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Move joinchat CSS rules into joinchat.css. r=mkmelin

They are only used by the joinchat.xhtml dialog, so we should prevent leaking the rules to other windows. Moreover, the dialog does not use any other content/chat.css rules.

Comment 47

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Create verifychat.css for verify.xhtml. r=mkmelin

It is only used by the verify.xhtml dialog, so we should prevent leaking the rules to other windows. Moreover, the dialog does not use any other content/chat.css rules.

Depends on D126504

Comment 48

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1707211 - Move chat.css from mail/components/im into mail/themes. r=mkmelin

Both themes/chat.css and content/chat.css were merged together into mail/themes/shared/chat.css

Depends on D126505

Comment 49

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/257860a21169
Move cloudfile selectDialog.css into themes. r=mkmelin

Comment 50

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c76b23c147d4
Move joinchat CSS rules into joinchat.css. r=mkmelin

Comment 51

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/61e6e26cce83
Move chat.css from mail/components/im into mail/themes. r=mkmelin

Comment 52

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/32957980cdbf
Create verifychat.css for verify.xhtml. r=mkmelin

Comment 53

[Magnus Melin [:mkmelin]]

Looks like we're done with this, as far as it's reasonable to take it.
I did spot some minor cleanup so will post that. But after that, I guess we should close.

Comment 54

[Magnus Melin [:mkmelin]]

Attachment: Bug 1707211 - centralize some @imports. r=john.bieling

Comment 55

[Henry Wilkes (they/them) [:henry-x]]

I think its only the various aboutDialog.css files that remain. Bug 1728474 is still blocking on this, but we could make the change here instead.

Comment 56

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/272ed718520a
centralize some @imports. r=john.bieling

Comment 57

[Alessandro Castellani [:aleca]]

I agree with magnus per comment 53.
The about dialog is a different beast we will tackle in its own bug.