Open Bug 1707211 Opened 8 months ago Updated 2 months ago

stop using content/ css - move the css to the shared theme file instead

Categories

(Thunderbird :: General, task)

Tracking

(thunderbird_esr91 wontfix, thunderbird93 wontfix)

ASSIGNED
94 Branch
Tracking Status
thunderbird_esr91 --- wontfix
thunderbird93 --- wontfix

People

(Reporter: mkmelin, Assigned: henry)

References

(Depends on 1 open bug)

Details

(Keywords: leave-open)

Attachments

(32 files)

48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review

content/ .css is not useful anymore now that xbl is gone and 3rd party full themes do not exist anymore.

The distinction of what is styling and structure is fluent enough that it makes sense to move such css into the platform shared file instead.

Assignee: nobody → henry
Keywords: leave-open
Status: NEW → ASSIGNED

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/9b74c095efbd
Merge newmailalert.css content into skin. r=mkmelin
https://hg.mozilla.org/comm-central/rev/88701f939fe0
Move glodacomplete.css into themes. r=mkmelin
https://hg.mozilla.org/comm-central/rev/237515af017b
Move fieldMapImport.css into themes. r=mkmelin

This stylesheet is intended for xul:notification elements. However, these are unused (instead, notifications use xul:notification-message elements, which uses message-bar.css).

Also removed MOZ_SUITE checks from customizeToolbar.xhtml since it is not a shared file.

Target Milestone: --- → 94 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/421848d544b8
Merge am-server.css into accountManage.css. r=mkmelin
https://hg.mozilla.org/comm-central/rev/39059485f991
Move content calendar CSS files into themes/common. r=darktrojan
https://hg.mozilla.org/comm-central/rev/942ea0363403
Drop notification.css. r=mkmelin
https://hg.mozilla.org/comm-central/rev/c1285eaf5e9c
Merge tabmail.css content into skin. r=mkmelin
https://hg.mozilla.org/comm-central/rev/70327f18e16c
Move content/multimessageview.css into themes/shared. r=mkmelin
https://hg.mozilla.org/comm-central/rev/ff5255d2cdf5
Move content/customizeToolbar.css into themes/shared. r=mkmelin

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/0248e301860e
Move aboutAddonsExtra.css into themes. r=mkmelin

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/1392ebed9caf
Merge messenger.css content into shared/skin. r=mkmelin
https://hg.mozilla.org/comm-central/rev/d9d46bb38f5c
Move content/glodaFacetView.css into themes/shared. r=mkmelin
https://hg.mozilla.org/comm-central/rev/82eb38836661
Move converterDialog.css into themes. r=mkmelin
https://hg.mozilla.org/comm-central/rev/ff39f6fe10e8
Move content/menulist.css into themes/shared. r=mkmelin
https://hg.mozilla.org/comm-central/rev/766aef629be7
Merge multimessageview_print.css into multimessageview.css. r=mkmelin
https://hg.mozilla.org/comm-central/rev/ccc2b47a5cf8
Move santizeDialog.css into themes. r=mkmelin
https://hg.mozilla.org/comm-central/rev/6a13079a529f
Merge sharedsummary.css into multimessageview.css. r=mkmelin

Do you think mail/components/cloudfile/content/selectDialog.css should be moved to

  1. mail/themes/shared/mail/selectDialog.css,
  2. mail/themes/shared/mail/cloudfileSelectDialog.css (with or without renaming the other cloudfile selectDialog* files), or
  3. mail/themes/shared/mail/cloudfile/selectDialog.css?

Also, if you look at something like imAccountWizard.css, it is stored in mail/components/im/themes, but is registered in mail/themes/linux/jar.mn. chat.css is similarly spread around.

Should we move all of the content of mail/components/im/themes into either chat/themes or mail/themes?

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/d0f498534a79
Move composerOverlay.css into themes. r=mkmelin
https://hg.mozilla.org/comm-central/rev/e27e576b82b7
Remove hide-private.css. r=mkmelin
https://hg.mozilla.org/comm-central/rev/aea746d01c9a
Move aboutPolicies.css into themes. r=mkmelin
https://hg.mozilla.org/comm-central/rev/f70d87a3f162
Move EditorContent.css into themes. r=mkmelin

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/dc4d76159758
Move tree-listbox.css into themes. r=darktrojan
https://hg.mozilla.org/comm-central/rev/de35d92fd3ea
Move addressbook print.css into themes. r=darktrojan DONTBUILD

I've stopped encoding the strings in this test since btoa is now available in the test context. The values are the same as before with the stylesheet URL changed.

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/23d8c3c61de0
follow-up - Update a test to match. r=mkmelin

There are no CSS files in this directory.

Files still to go are:

  • mail/components/cloudfile/content/selectDialog.css - See comment 26.
  • mail/components/im/content/chat.css - See comment 29.
  • mail/base/content/aboutDialog.css - See Bug 1728474, which is moving the file.
  • mail/branding/thunderbird/content/aboutDialog.css - Being edited in the same bug, but it is not being moved. I'm not sure if or where to move this.
  • mail/branding/nightly/content/aboutDialog.css - Same as above.

Let me know what the approach should be for these.

Depends on: 1728474
Flags: needinfo?(mkmelin+mozilla)

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/fbf0197084ab
Move extensionPopup.css into themes. r=mkmelin
https://hg.mozilla.org/comm-central/rev/111c9676bb8b
Merge handlers.css into applications.css. r=mkmelin
https://hg.mozilla.org/comm-central/rev/cc5655a05392
Remove openpgp/ui/*.css entry. r=mkmelin

(In reply to Henry Wilkes [:henry] from comment #26)

Do you think mail/components/cloudfile/content/selectDialog.css should be moved to
2. mail/themes/shared/mail/cloudfileSelectDialog.css (with or without renaming the other cloudfile selectDialog* files), or

I'd go for this, and not renaming the other files there.

(In reply to Henry Wilkes [:henry] from comment #29)

Also, if you look at something like imAccountWizard.css, it is stored in mail/components/im/themes, but is registered in mail/themes/linux/jar.mn. chat.css is similarly spread around.

Should we move all of the content of mail/components/im/themes into either chat/themes or mail/themes?

I'd move it into mail/themes.

Re the branding, not sure but there is a prior example of using things to theme/ there:
https://searchfox.org/comm-central/rev/ddc5727d39202eaa94d280a4a5ba8d9532e5a9ec/mail/branding/thunderbird/jar.mn

Flags: needinfo?(mkmelin+mozilla)

The two branding aboutDialog.css are different and moving them to /theme/ would also need new branding folders which then have only one file in it. Maybe it's better to leave them there they are to let it simple to know what all belongs to the specific branding.

(In reply to Richard Marti (:Paenglab) from comment #43)

The two branding aboutDialog.css are different and moving them to /theme/ would also need new branding folders which then have only one file in it. Maybe it's better to leave them there they are to let it simple to know what all belongs to the specific branding.

Yes, I don't think moving them into mail/themes makes sense. I wonder if, since the branding directories already include a locales sub-directory for translations, we could similarly include a themes sub-directory.

And maybe move the icons into there as well. Perhaps in a separate bug, since we have icons placed under "content" chrome paths, which probably need a similar treatment to the CSS files in this bug.

See Also: → 1732307

They are only used by the joinchat.xhtml dialog, so we should prevent leaking the rules to other windows. Moreover, the dialog does not use any other content/chat.css rules.

It is only used by the verify.xhtml dialog, so we should prevent leaking the rules to other windows. Moreover, the dialog does not use any other content/chat.css rules.

Depends on D126504

Both themes/chat.css and content/chat.css were merged together into mail/themes/shared/chat.css

Depends on D126505

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/257860a21169
Move cloudfile selectDialog.css into themes. r=mkmelin

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/c76b23c147d4
Move joinchat CSS rules into joinchat.css. r=mkmelin
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/61e6e26cce83
Move chat.css from mail/components/im into mail/themes. r=mkmelin
Attachment #9242687 - Attachment description: Bug 1707211 - Move chat verify CSS rule into verifychat.css. r=mkmelin → Bug 1707211 - Create verifychat.css for verify.xhtml. r=mkmelin
Regressions: 1733060

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/32957980cdbf
Create verifychat.css for verify.xhtml. r=mkmelin

Regressions: 1734686
You need to log in before you can comment on or make changes to this bug.