A point [dot] "." at the beginning of a news post line will sometimes be doubled
Categories
(MailNews Core :: Networking: NNTP, defect)
Tracking
(thunderbird_esr78+ fixed, thunderbird83 affected)
People
(Reporter: frank.1977, Assigned: infofrommozilla)
References
Details
Attachments
(1 file, 3 obsolete files)
5.35 KB,
patch
|
infofrommozilla
:
review+
wsmwk
:
approval-comm-beta-
wsmwk
:
approval-comm-esr78+
|
Details | Diff | Splinter Review |
Comment 1•22 years ago
|
||
Comment 2•22 years ago
|
||
Updated•20 years ago
|
Updated•20 years ago
|
Comment 3•18 years ago
|
||
Comment 4•17 years ago
|
||
Comment 5•17 years ago
|
||
Updated•16 years ago
|
Updated•14 years ago
|
Comment 7•12 years ago
|
||
Comment 8•11 years ago
|
||
Comment 9•6 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Comment 10•4 years ago
|
||
I don't see any reason why the double dot was saved here in the first place.
If TB saves the articles directly offline, he also removes the dot.
Assignee | ||
Comment 11•4 years ago
|
||
I added a test.
For that I had to trick a little. Apparently the dot handling in the test server does not work correctly either. But the result is in line with expectations. With patch, the test delivers 100% PASS. Without the patch, the second test fails:
PASS run_test - [run_test : 40] "From: \\"Demo User\\" <nobody@example.net>\\nMessage-ID: <2@dot.invalid>\\nNewsgroups: dot.test\\nSubject: Bug 170727: Test article with dots\\n\\n. 1 dot\\n.. 2 dots\\n"
== "From: \\"Demo User\\" <nobody@example.net>\\nMessage-ID: <2@dot.invalid>\\nNewsgroups: dot.test\\nSubject: Bug 170727: Test article with dots\\n\\n. 1 dot\\n.. 2 dots\\n"
FAIL run_test - [run_test : 56] "From: \\"Demo User\\" <nobody@example.net>\\nMessage-ID: <2@dot.invalid>\\nNewsgroups: dot.test\\nSubject: Bug 170727: Test article with dots\\n\\n.. 1 dot\\n... 2 dots\\n"
== "From: \\"Demo User\\" <nobody@example.net>\\nMessage-ID: <2@dot.invalid>\\nNewsgroups: dot.test\\nSubject: Bug 170727: Test article with dots\\n\\n. 1 dot\\n.. 2 dots\\n"
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 12•4 years ago
|
||
(In reply to Alfred Peters from comment #11)
For that I had to trick a little. Apparently the dot handling in the test server does not work correctly either.
When Bug 1669277 will be fixed, the test works without the /tricks/ ;-)
Assignee | ||
Comment 13•4 years ago
|
||
(In reply to Alfred Peters from comment #12)
Created attachment 9179655 [details] [diff] [review]
review? Joshua Cranmer
I took him because he was suggested by Buzilla and he has written this code once. But he is absent since august.
The other suggestion was 'neil' but he had already 22 reviews in queue.
So would anybody else do the review of this and bug 1669277?
Updated•4 years ago
|
Updated•4 years ago
|
Comment 14•4 years ago
|
||
Assignee | ||
Comment 15•4 years ago
|
||
(In reply to Ben Campbell from comment #14)
I'd probably add a comment with the term "dot-stuffing" (or a link to
https://tools.ietf.org/html/rfc3977#section-3.1.1, say) for the benefit of
future archeologists.
Done.
I'd probably slip in a few more nasty cases to give it a good workout, eg:
Done.
Assignee | ||
Updated•4 years ago
|
Comment 16•4 years ago
|
||
Please remember to run ./mach eslint --fix <path> and ./mach clang-format -p <path>.
Updated•4 years ago
|
Comment 17•4 years ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/2ad1ef8c60f4
Remove the escaped dot from body lines before saving in the offline store so dot at the beginning of news posts won't be doubled. r=benc
Comment 18•4 years ago
|
||
But thanks for the patches! Keep 'em coming! ;)
Updated•4 years ago
|
Comment 19•4 years ago
|
||
Comment on attachment 9184980 [details] [diff] [review]
Remove the escaped dot from body lines before saving in the offline store.
[Approval Request Comment]
User impact if declined: per bug summary
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): not very risky, but should be uplifted together with bug 1669277
Comment 20•4 years ago
|
||
Comment on attachment 9184980 [details] [diff] [review]
Remove the escaped dot from body lines before saving in the offline store.
[Triage Comment]
Approved for esr78 - needs to be taken with the other patch for 78.
We don't plan another beta for uplifts - so this will appear in beta 84
Comment 21•4 years ago
|
||
bugherder uplift |
Thunderbird 78.5.0:
https://hg.mozilla.org/releases/comm-esr78/rev/744206d92a10
Description
•