1707286 - Duplicate notification(Set as default) when start up

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Alice0775 White]

Attachment: image.png

User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:90.0) Gecko/20100101 Firefox/90.0
Build ID 20210423095101

Steps To Reproduce:
nothing of special. Just started Nightly.

Comment 1

[Andrei Oprea [:andreio]]

Thanks for catching this. Most likely a regression from bug 1681130.

Comment 2

[Andrei Oprea [:andreio]]

Can you please confirm:

1. Turn on browser.newtabpage.activity-stream.asrouter.devtoolsEnabled
2. Navigate to about:newtab#devtools-targeting
3. Look for messageImpressions and paste the contents for INFOBAR_DEFAULT_AND_PIN_87

For me it looks like this

{
  "INFOBAR_DEFAULT_AND_PIN_87": [
    1619205134458
  ]
}

That's the id of the message and the timestamp when it was shown. If it is indeed the same message being shown twice the timestamps should be really close to each other.

Comment 3

[Andrei Oprea [:andreio]]

Sorry no need to confirm. Definitely due to the bug I mentioned previously.

Comment 4

[Andrei Oprea [:andreio]]

https://github.com/mozilla/messaging-system-inflight-assets/pull/209

Comment 5

[Andrei Oprea [:andreio]]

Attachment: Bug 1707286 - Prevent stacking multiple Infobar messages

Comment 7

[Andrei Oprea [:andreio]]

Fix landed in Remote Settings.

Comment 8

[Andrei Oprea [:andreio]]

Reopening. Also planning to prevent duplicates in code as a safety mechanism since these targeting expressions are getting complex.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6dc407660186
Prevent stacking multiple Infobar messages r=Mardak

Comment 10

[Cosmin Sabou [:CosminS]]

Backed out for bc failures on browser_asrouter_infobar.js.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=6dc407660186707976a36ca5a2458144401e0f88&selectedTaskRun=P1Ht-urVTsuwxr0YqLVOSg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=338176570&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/ab4bef60942086e4c96dd936b05afe69f81cca3e

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/544acbf5c6c4
Prevent stacking multiple Infobar messages r=Mardak

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/544acbf5c6c4

Comment 13

[Bogdan Maris, Desktop Test Engineering]

Unfortunately I could not reproduce the issue on an affected build. I know I saw this bug in the past but now, using the Nightly from 2021-04-23 I see the new modal with default browser and no infobars.

Alice since you are the original reporter of this bug, could you please confirm that this is no longer an issue using latest 90 beta build?

Comment 14

[Alice0775 White]

No longer reproduce the issue in Firefox90.0beta.
So, I mark this as VERIFIED.

Comment 15

[Bogdan Maris, Desktop Test Engineering]

Thanks Alice!