Closed Bug 1681130 Opened 8 months ago Closed 3 months ago

Remove the "Set to Default" notification bar

Categories

(Firefox :: Messaging System, task, P3)

task

Tracking

()

VERIFIED FIXED
90 Branch
Iteration:
90.1 - Apr 19 - May 2
Tracking Status
firefox89 --- verified
firefox90 --- verified

People

(Reporter: jaws, Assigned: andreio)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [proton-onboarding] [proton-uplift])

Attachments

(3 files)

We got more data back and saw that this change did not affect retention or activation but did hurt "Set to Default" conversions. Looked at from a different perspective, this means that the current modal dialog is not hurting retention or activation. We would like to find an experience that increases "Set to Default" conversion while also keeping retention and activation equal or showing an improvement.

Details can be found at https://mana.mozilla.org/wiki/pages/viewpage.action?pageId=130914342 (sorry, this link is MoCo confidential but the details I shared in this comment describe the contents of the link at a high level).

Bug 1664876 should be fixed as part of this work.

Bug 1701867 makes defaultbrowser.notificationbar even less useful by ignoring it when browser.proton.enabled is true. The code is indeed pretty confusing with so many paths, so we'll want to simplify by removing.

Blocks: 1701995
Depends on: 1701867
Assignee: nobody → andrei.br92
Attached image image.png

This duplicated notification will not be a problem after this lands?

(In reply to gwarser from comment #4)

This duplicated notification will not be a problem after this lands?

Do you know what version of nightly you were running for that screenshot? (You can check about:support -> Build ID.) One of the notifications should have been removed from nightly 4 days ago with bug 1701867. This bug is cleaning up the code that is no longer active in latest nightly.

Hi,

I've also noticed the duplicated default browser notification on Nightly 89.0a1 (20210414160838) and on the latest Nightly 89.0a1 (20210419094740)
so it doesn't seem to have been removed with Bug 1701867

Here is how I can reproduce this every time:

  1. Open Firefox using a new profile
  2. Open a new tab ("old" default browser notification infobar appears)
  3. Close Firefox without closing the notification
  4. Open Firefox using the same profile as before
  5. When the modal is presented, check the "Don't show this message again" checkbox and press "Not now"
  6. Open a new tab ("new" default browser notification infobar appears with the added "(i)" icon)
  7. Go back to the previous tab -> both the "old" and "new" infobar is present
Flags: needinfo?(edilee)

Here is a screenshot with the issue occurring

Attachment #9216394 - Attachment description: WIP: Bug 1681130 - Remove the Set to Default notification bar → Bug 1681130 - Remove the Set to Default notification bar

(In reply to Peter_M from comment #6)

I've also noticed the duplicated default browser notification on Nightly 89.0a1 (20210414160838) and on the latest Nightly 89.0a1 (20210419094740)
so it doesn't seem to have been removed with Bug 1701867

Thanks. This should be fixed now with bug 1703874 comment 3 with an extra https://github.com/mozilla/messaging-system-inflight-assets/commit/55a05c81cbefc2d09d0dd9f815b82a933fd14f73

Flags: needinfo?(edilee)
See Also: → 1703874
Pushed by aoprea@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a3777c1bbf2f
Remove the Set to Default notification bar r=Mardak,jaws
Iteration: --- → 90.1 - Apr 19 - May 2
Version: unspecified → Trunk
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Whiteboard: [proton-onboarding]

Comment on attachment 9216394 [details]
Bug 1681130 - Remove the Set to Default notification bar

Beta/Release Uplift Approval Request

  • User impact if declined: Users see both a modal prompt and infobar asking for default browser
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: 1. Make sure Firefox is not the default browser
  1. Launch Firefox with a new profile
  2. Restart Firefox (first start doesn't prompt)
  3. Only prompt and not infobar are shown
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Removing code that has been preffed off in release (but on in beta/nightly)
  • String changes made/needed: none
Attachment #9216394 - Flags: approval-mozilla-beta?
Flags: qe-verify+
QA Whiteboard: [qa-triaged]
Whiteboard: [proton-onboarding] → [proton-onboarding] [proton-uplift]

Verified the fix using Nightly 90.0a1 (20210427221830) on Windows 10, MacOS 11 and Ubuntu 20.04. The default browser infobar is no longer shown.

Comment on attachment 9216394 [details]
Bug 1681130 - Remove the Set to Default notification bar

Approved for 89 beta 6, thanks.

Attachment #9216394 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Status: RESOLVED → VERIFIED

Verified the fix using Firefox Beta 89.0b8 (20210504185920) on Windows 10, MacOS 11 and Ubuntu 20.04.

QA Whiteboard: [qa-triaged]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.