Closed Bug 1707337 Opened 4 years ago Closed 4 years ago

Modal content can be overscrolled despite no content to scroll

Categories

(Core :: Panning and Zooming, defect)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1706282

People

(Reporter: ntim, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached image image.png

This modal description can be overscrolled.

The part that you can overscroll is the part that say "This page is asking you..."?

The only way I was able to overscroll anything from the screenshot was if I got the dialog on a retina screen and then dragged it to a non-retina screen, then the description got a scrollbar, I also have show scrollbars always turned on.

(In reply to Timothy Nikkel (:tnikkel) from comment #1)

The part that you can overscroll is the part that say "This page is asking you..."?

Yes. No longer seems reproducible on latest Nightly, but still reproducible on 89.0 beta 3.

The only way I was able to overscroll anything from the screenshot was if I got the dialog on a retina screen and then dragged it to a non-retina screen, then the description got a scrollbar, I also have show scrollbars always turned on.

I've done none of that. I also don't have the always show scrollbars setting on.

Thanks.

This seems to be the fix range.

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=33143ef17c70c76f39ac75fe51d3ae9342365845&tochange=5413cedf852d89586c2935cd9c59ec7bad12cd05

No overscroll fixes in there that I can see, so I'm guessing it's a front end change.
maybe
4a2b343c670f80a8e61fa1a98ba2f573745a933e Emma Malysz — Bug 1685352, adjust print modal to match proton styles r=mstriemer
It hasn't been uplifted to beta. I can't bisect further (mozregression won't even let me launch autoland builds) due to bug 1707344

(In reply to Timothy Nikkel (:tnikkel) from comment #3)

Thanks.

This seems to be the fix range.

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=33143ef17c70c76f39ac75fe51d3ae9342365845&tochange=5413cedf852d89586c2935cd9c59ec7bad12cd05

No overscroll fixes in there that I can see, so I'm guessing it's a front end change.
maybe
4a2b343c670f80a8e61fa1a98ba2f573745a933e Emma Malysz — Bug 1685352, adjust print modal to match proton styles r=mstriemer

That's pretty unlikely given what's in the changeset. Though I don't see anything that stands out in the range either.

Maybe https://hg.mozilla.org/mozilla-central/rev/efc1b82bbd44147f16d8a560fc8033e2bbba637b (Bug 1706282 - Wrap default browser prompt title r=Gijs)?

It seems to apply to code shared by various dialogs, changes an overflow property, and also hasn't been uplifted to beta.

(In reply to Botond Ballo [:botond] from comment #5)

Maybe https://hg.mozilla.org/mozilla-central/rev/efc1b82bbd44147f16d8a560fc8033e2bbba637b (Bug 1706282 - Wrap default browser prompt title r=Gijs)?

It seems to apply to code shared by various dialogs, changes an overflow property, and also hasn't been uplifted to beta.

Yep, confirmed now that I have mozregression working. And there is an uplift request in that bug.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: