1706282 - [macOS] Devedition default browser message is not fully contained in its modal

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P2)

Description

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Attachment: deved default message.png

Affected versions

• Firefox 89.0b1 devedition

Affected platforms

• macOS 10.15.7

Steps to reproduce

1. Launch Firefox with a new profile and then close it
2. Launch Firefox again

Expected result

• The message "Make Firefox Developer Edition your default browser?" is fully visible

Actual result

• The "Make" is fully hidden and the first part of "Firefox" is barely visible

Regression range

• Will see for a regression

Additional notes

• The issue can be seen in the attachment
• The other Os's are not affected
• Only Devedition is affected

Comment 1

[:Gijs (he/him)]

We can turn off the fade but that doesn't really alter the fact that the width here is insufficient. Not sure what we want to do here. I also expect the same issue may affect other locales...

Comment 2

[Francesco Lodolo [:flod]]

(In reply to :Gijs (he/him) from comment #1)

We can turn off the fade but that doesn't really alter the fact that the width here is insufficient. Not sure what we want to do here. I also expect the same issue may affect other locales...

That's for sure. I don't even know if Chinese can fit in that space
https://transvision.flod.org/string/?entity=browser/browser/defaultBrowserNotification.ftl:default-browser-prompt-title-alt&repo=gecko_strings

Technically, it could be mitigated by using -brand-shorter-name, which resolves to "Firefox" on DevEdition too. But: it requires a new string, and it's potentially confusing. More importantly, I expect some locales to have truncation issues even on release with just "Firefox".

Comment 3

[Ed Lee :Mardak]

Attachment: example wrap title

Meridel and katieC agree the desired behavior is to wrap the title when too long

Comment 4

[Ed Lee :Mardak]

Attachment: Bug 1706282 - Wrap default browser prompt title r?Gijs

Allow adjustableTitle to wrap skiping cropping and fading.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/efc1b82bbd44
Wrap default browser prompt title r=Gijs

Comment 6

[Ed Lee :Mardak]

QA steps:

1. download tg (Tajik — Тоҷикӣ) build
2. get default browser prompt to show, e.g., ChromeUtils.import("resource:///modules/BrowserGlue.jsm").DefaultBrowserCheck.prompt(window);
3. see wrapped text instead of faded

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/efc1b82bbd44

Comment 8

[Ed Lee :Mardak]

Comment on attachment 9217268 [details]
Bug 1706282 - Wrap default browser prompt title r?Gijs

Beta/Release Uplift Approval Request

• User impact if declined: Long proton prompt titles aren't fully visible
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Comment 6
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Mainly CSS change to conditionally wrap vs crop
• String changes made/needed: none

Comment 10

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Attachment: fx icon.png

Verified that the text is wrapped now on Firefox 90.0a1 (2021-04-25) on macOS 10.15.

The icon for Firefox seems to be a bit offset now (see attachment). Will this be addressed here or should we file a bug for it?

Comment 11

[Ed Lee :Mardak]

Hmm.. That does look a little bit high. If it's also too high for Chinese, then we can have a separate bug to push it down a little.

Comment 12

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Attachment: zh-CN message.png

Doesn't seem to be as bad as the other one, but still a bit high though. What should we do?

Comment 13

[Ed Lee :Mardak]

Yeah we can have a followup bug to move the icon down probably 2px.

Comment 14

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Logged Bug 1707828 for the icon issue

Comment 15

[Pascal Chevrel:pascalc]

Comment on attachment 9217268 [details]
Bug 1706282 - Wrap default browser prompt title r?Gijs

Approved for 89 beta 6, thanks.

Comment 16

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/47ab85602f1b

Comment 17

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Verified with zh-CN build on 89.0b7 and the issue is fixed.