Closed Bug 1707458 Opened 4 years ago Closed 4 years ago

Remove unused xpi packaging code from chatZilla

Categories

(SeaMonkey :: Chat, task)

Product:
SeaMonkey
Component:
Chat
Type:
task

Tracking

(seamonkey2.53+ fixed, seamonkey2.57esr? affected)

Status:
RESOLVED FIXED
Milestone:
seamonkey 2.87
Tracking Flags:
Tracking Status
seamonkey2.53 + fixed
seamonkey2.57esr ? affected

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

Details

(Whiteboard: SM2.53.8)

Attachments

(1 file, 2 obsolete files)

1707458-remove-xpi-v1_1-2538.patch
69.47 KB, patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review

We do not use the xpi packaging code in the forked chatZilla code.
We also package the icons for chatZilla elsewhere so that is not needed.

Attached patch 1707458-remove-xpi-2538.patch (obsolete) — — Splinter Review

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.8
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Attachment #9218186 - Flags: review?(frgrahl)
Attachment #9218186 - Flags: approval-comm-release?
Attachment #9218186 - Flags: approval-comm-esr60?
Attached patch 1707458-remove-xpi-2538.patch (obsolete) — — Splinter Review

qrefreshed version with header

Attachment #9218186 - Attachment is obsolete: true
Attachment #9218186 - Flags: review?(frgrahl)
Attachment #9218186 - Flags: approval-comm-release?
Attachment #9218186 - Flags: approval-comm-esr60?
Attachment #9218187 - Flags: review?(frgrahl)
Attachment #9218187 - Flags: approval-comm-release?
Attachment #9218187 - Flags: approval-comm-esr60?

Include changes to allowed-dupes.mn in this patch

Attachment #9218187 - Attachment is obsolete: true
Attachment #9218187 - Flags: review?(frgrahl)
Attachment #9218187 - Flags: approval-comm-release?
Attachment #9218187 - Flags: approval-comm-esr60?
Attachment #9218751 - Flags: review?(frgrahl)
Attachment #9218751 - Flags: approval-comm-release?
Attachment #9218751 - Flags: approval-comm-esr60?
Blocks: 1604663, 1707459
Whiteboard: SM2.53.8

Comment on attachment 9218751 [details] [diff] [review]
1707458-remove-xpi-v1_1-2538.patch

LGTM

Attachment #9218751 - Flags: review?(frgrahl)
Attachment #9218751 - Flags: review+
Attachment #9218751 - Flags: approval-comm-release?
Attachment #9218751 - Flags: approval-comm-release+
Attachment #9218751 - Flags: approval-comm-esr60?
Attachment #9218751 - Flags: approval-comm-esr60+

https://hg.mozilla.org/comm-central/rev/a339c7ea3936907ec74e00a813b39537bec05112
Remove unused xpi packaging code from chatZilla. r=frg

status-seamonkey2.53: --- → affected
status-seamonkey2.57esr: --- → affected
tracking-seamonkey2.53: --- → ?
tracking-seamonkey2.57esr: --- → ?
Target Milestone: --- → seamonkey 2.87
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: