1707557 - fix TransformFrameRectToAncestor call in DoubleTapToZoom for fixed content where the ancestor frame isn't an ancestor

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Timothy Nikkel (:tnikkel)]

Attachment: fgs4.html

Bug 1705599 made the calculation we do in nsLayoutUtils::GetBoundingFrameRect work if its inside fixed content. But bug 1701749 added a similar calculation in DoubleTapToZoom.cpp which we didn't fix up for the same problem.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1707557. Fix TransformFrameRectToAncestor call in DoubleTapToZoom for fixed content where the ancestor frame isn't guaranteed to be an ancestor r?botond

Bug 1705599 made the calculation we do in nsLayoutUtils::GetBoundingFrameRect work if its inside fixed content. But bug 1701749 added a similar calculation in DoubleTapToZoom.cpp which we didn't fix up for the same problem.

Comment 2

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1707557. Add test. r?emilio,botond

Comment 3

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1707557. Add test. r?botond,emilio

Comment 4

[Phabricator Automation]

Comment on attachment 9218864 [details]
Bug 1707557. Add test. r?botond,emilio

Revision D113623 was moved to bug 1707234. Setting attachment 9218864 [details] to obsolete.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/869a82f47afa
Fix TransformFrameRectToAncestor call in DoubleTapToZoom for fixed content where the ancestor frame isn't guaranteed to be an ancestor r=emilio
https://hg.mozilla.org/integration/autoland/rev/24f512e5e212
Add test. r=emilio

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/869a82f47afa
https://hg.mozilla.org/mozilla-central/rev/24f512e5e212

Comment 7

[Timothy Nikkel (:tnikkel)]

Comment on attachment 9218315 [details]
Bug 1707557. Fix TransformFrameRectToAncestor call in DoubleTapToZoom for fixed content where the ancestor frame isn't guaranteed to be an ancestor r?botond

Beta/Release Uplift Approval Request

• User impact if declined: double tap inside some fixed content will choose a not ideal rect to zoom to
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): just changes code from assuming one node is an ancestor of another to allow them to not be ancestors
• String changes made/needed:

Comment 8

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

Comment on attachment 9218315 [details]
Bug 1707557. Fix TransformFrameRectToAncestor call in DoubleTapToZoom for fixed content where the ancestor frame isn't guaranteed to be an ancestor r?botond

Approved for 89 beta 7, thanks.

Comment 9

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

https://hg.mozilla.org/releases/mozilla-beta/rev/69d5ff79a28c
https://hg.mozilla.org/releases/mozilla-beta/rev/6c6f59e623d7