674371 - [meta] Support double-tap to zoom in on a section on macOS

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P2)

Description

[Alex Limi (:limi) — Firefox UX Team]

We should support double-tap to zoom in/out on a particular region of the page.

Comment 1

[Justin Dolske [:Dolske]]

There's opportunity here not only to match whatever OS X Lion is doing, but also to increase commonality with Firefox mobile (which already supports this).

Additionally, I bey frequently use the built in OS X (pre-Lion) support for screen zooming (part of the Universal Access stuff), because it's just super handy to get to and works instantly.

Comment 2

[Steven Michaud [:smichaud] (Retired)]

Related to bug 688990?

Comment 3

[Brandon Waterloo]

As per https://bugzilla.mozilla.org/show_bug.cgi?id=688990#c17, we'll be moving our work into an add-on.  Once OMTC / APZC is ready to go, the add-on will be deprecated.

The add-on depends on bugs 851128 and 853490.  It will be called "Multi-Touch Gestures" (or something very similar), and will be available on addons.mozilla.org before the end of April.

Unassigning myself from the bug.

Comment 4

[Jonathan Watt [:jwatt]]

Mass bug change to replace various 'parity' whiteboard flags with the new canonical keywords. (See bug 1443764 comment 13.)

Comment 5

[sivalingam]

I get used to this feature in chrome and I very much miss this in Firefox. I wonder why this 8 year bug in still unresolved.

Can someone recommend an already existing addon to make this happen in firefox.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

This isn't really specific to Lion, updating summary.

Comment 8

[Botond Ballo [:botond]]

(In reply to sivalingam from comment #5)

I get used to this feature in chrome and I very much miss this in Firefox. I wonder why this 8 year bug in still unresolved.

Can someone recommend an already existing addon to make this happen in firefox.

It's being worked on (see recent comments in bug 789906, which is the corresponding bug for Windows).

There's also an addon linked in that bug, though people report it doesn't work very well.

Comment 9

[Botond Ballo [:botond]]

I note that on mobile, we currently gate double-tap zooming on the following:

    // If the CSS viewport is narrower than the screen (i.e. width <=
    // device-width) then we disable double-tap-to-zoom behaviour.
    CSSToLayoutDeviceScale scale =
        mPresShell->GetPresContext()->CSSToDevPixelScale();
    if ((viewportInfo.GetSize() * scale).width <= screenSize.width) {
      zoomConstraints.mAllowDoubleTapZoom = false;
    }

This condition will never be true on desktop (since there is no mobile viewport sizing on desktop, the layout viewport always derives its width from the browser window's width), so we'll have to figure out what condition (if any) to gate it on for desktop.

Comment 10

[duarteosrm]

This would really improve the UX on mac.

Comment 11

[yoswed123]

Double tap with two fingers to zoom feature is available on both Chrome and Safari. With my Logitech MX Master 3, I can even zoom with a dedicated gesture button click (they call it "Smart Zoom"). Would love to see this feature come to Firefox.

Comment 12

[Greg]

I see bug 789906 and others have been closed, as pinch zooming went out in 83 release. 🎉 Any chance this can progressed now?

I'd love to have smart zooming, it's the functionality I miss the most from Chrome.

Comment 13

[Botond Ballo [:botond]]

Yes, this is one of the follow-ups to desktop zooming we hope to work on in the near future.

Comment 14

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 674371. Turn on the pref for double tap to zoom on mac. r=botond

Depends on D107389

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbf677b3fb7e
Turn on the pref for double tap to zoom on mac. r=botond

Comment 16

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/fbf677b3fb7e

Comment 17

[Dorel Luca [:dluca]]

Backed out changeset fbf677b3fb7e (bug 674371) on dev's request.

Backout:
https://hg.mozilla.org/integration/autoland/rev/65589ccfe6c2e333f1e5dce3d9c73655b9f7474d

Comment 18

[Timothy Nikkel (:tnikkel)]

I requested backout of this so that we can enable this nightly only for now, which I will do in bug 1698642.

Comment 19

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/65589ccfe6c2

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e40d9fe9190f
Turn on the pref for double tap to zoom on mac. r=botond

Comment 21

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e40d9fe9190f