1707659 - Show/hide password button in account setup is not keyboard accessible, no way for screen readers to read the password on request

Status: RESOLVED FIXED

(Thunderbird :: Disability Access, defect, P3)

Description

[Thomas D. (:thomas8)]

Every time I set up a new account for testing purposes, it's so inefficient having to switch to mouse just for disclosing the password instead of just pressing Tab, Enter... Worse for the blind, they will have no way to double-check their password for correctness using screen readers: Password will not be read as long as it is hidden.

STR

1. Account Setup via keyboard only
2. type name, tab, email, tab, password - oh, that's hidden, let me double-check
3. press tab in password field

Actual

• remember password checkbox focused

Expected

• Show/hide password button (eye icon) should be focused
• Enter or Space on the button should toggle show/hide
• For safety, focus should probably remain on button allowing rapid show/hide toggling

Comment 1

[Thomas D. (:thomas8)]

Same problem for the info icons in the other fields btw.

Comment 2

[Alessandro Castellani [:aleca]]

(In reply to Thomas D. (:thomas8) from comment #1)

Same problem for the info icons in the other fields btw.

There's no need to make those keyboard accessible since the screen readers pick up the placeholder/description of the field, which comes with plenty of context to guide the user.
Those info icon are not as important as the show/hide password.

Worse for the blind, they will have no way to double-check their password for correctness using screen readers.

I don't think this is an extremely valid point as screen readers have the ability to read back the typed keys while typing.
In terms of keyboard usability is also a bit weird, as blind users would need to focus on the show/hide icon, hit enter, then focus back on the input field to hear the text. So, not super useful and intuitive.

Making the password visibility toggle keyboard accessible is a good improvement, but is mostly to target keyboard-centric users.

Comment 3

[Ali Savas]

(In reply to Alessandro Castellani [:aleca] from comment #2)

(In reply to Thomas D. (:thomas8) from comment #1)

Worse for the blind, they will have no way to double-check their password for correctness using screen readers.

I don't think this is an extremely valid point as screen readers have the ability to read back the typed keys while typing.

Unfortunately, I have to disagree with you. In edit fields for passwords, the typed passwords are not read out for security reasons. No matter what is typed, you only hear "star star star".

Comment 4

[Alessandro Castellani [:aleca]]

Unfortunately, I have to disagree with you. In edit fields for passwords, the typed passwords are not read out for security reasons. No matter what is typed, you only hear "star star star".

Ah, damn, my bad, I remembered incorrectly, thanks for the clarification.

Comment 5

[Alessandro Castellani [:aleca]]

Setting 91 as a wontfix since this involves string changes.

Comment 6

[Alessandro Castellani [:aleca]]

Attachment: Bug 1707659 - Make the show/hide password toggle keyboard accessible and improve a11y of the feature. r=mkmelin,ui-r=Paenglab

Comment 7

[Alessandro Castellani [:aleca]]

Gentle ping here for a review from Thomas on phabricator.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e0eb612d9de3
Make the show/hide password toggle keyboard accessible and improve a11y of the feature. r=mkmelin,ui-r=Paenglab