Closed Bug 1707802 Opened 4 years ago Closed 4 years ago

use GetFlattenedTreeParentElement in DoubleTapToZoom.cpp instead of GetParentElement

Categories

(Core :: Panning and Zooming, enhancement)

Product:
Core
Component:
Panning and Zooming
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed
firefox90 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

(Whiteboard: [proton-uplift])

Attachments

(2 files)

Bug 1707802. Use GetFlattenedTreeParentElement in DoubleTapToZoom.cpp instead of GetParentElement. r?emilio
48 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details | Review
Bug 1707802. Add test. r?emilio
48 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details | Review

To deal with shadow dom correctly.

From here
https://phabricator.services.mozilla.com/D113341#inline-629863

Assignee: nobody → tnikkel
Status: NEW → ASSIGNED
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b110e25c8f35 Use GetFlattenedTreeParentElement in DoubleTapToZoom.cpp instead of GetParentElement. r=emilio https://hg.mozilla.org/integration/autoland/rev/603076f35df0 Add test. r=emilio

https://hg.mozilla.org/mozilla-central/rev/b110e25c8f35
https://hg.mozilla.org/mozilla-central/rev/603076f35df0

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Whiteboard: [proton-uplift]

Comment on attachment 9218552 [details]
Bug 1707802. Use GetFlattenedTreeParentElement in DoubleTapToZoom.cpp instead of GetParentElement. r?emilio

Beta/Release Uplift Approval Request

  • User impact if declined: double tap zoom doesn't work in shadow dom scenarios
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): just makes it work with shadow dom
  • String changes made/needed:
Attachment #9218552 - Flags: approval-mozilla-beta?
Attachment #9218902 - Flags: approval-mozilla-beta?

Comment on attachment 9218552 [details]
Bug 1707802. Use GetFlattenedTreeParentElement in DoubleTapToZoom.cpp instead of GetParentElement. r?emilio

Low risk, Approved for 89 beta 8, thanks.

Attachment #9218552 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9218902 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: