1707839 - Switch to tab option is not visible or cut off when the searched tab has longer strings and browser has certain width

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Alexandru Trif, Desktop QA [:atrif]]

Attachment: adress_switch to tab_00.gif

Affected versions

• 90.0a1(20210421212740)
• 89.0b4 (20210425185730)

Affected platforms

• Windows10 x64
• macOS 11.2.3
• Ubuntu 18.04

Steps to reproduce

1. Open Firefox with a new profile and a random Amazon product.
2. Open a new tab and click on the Tabs option.
3. Type ama and resize the browser horizontally.

Expected result

• Switch to tab option is displayed for Amazon.

Actual result

• Switch to tab option is not displayed on certain browser width.

Regression range

• I will search for one ASAP if there is one.

Notes

• Attached a screen recording.
• S2 because the issue is easily reproducible and it's more visible when higher scaling and resolutions are used.

Comment 1

[Drew Willcoxon :adw]

This is bug 1699325 AFAICT. I'll leave it to you all to dupe it if you'd like so that I don't interfere with your Proton planning.

Comment 2

[Marco Bonardo [:mak]]

The problem here is that removing the switch to tab badge in Proton made that bug outcome worse for the user, that now has no way to dtistinguish a switch to tab result if the chiclet is pushed out.

Comment 3

[Giorgia Nichita, Release Desktop QA]

Hello,

This issue is not a regression. Accordingly to bug 1699325#c2, we can also reproduce it on builds way back to 75.0, on Windows 10x64.

Thanks!

Comment 4

[Marco Bonardo [:mak]]

investigating...

Comment 5

[Marco Bonardo [:mak]]

Attachment: Bug 1707839 - Ensure the action text stays visible in Address Bar results. r=adw

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b55610e6d23
Ensure the action text stays visible in Address Bar results. r=adw

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4b55610e6d23

Comment 11

[Marco Bonardo [:mak]]

Comment on attachment 9219150 [details]
Bug 1707839 - Ensure the action text stays visible in Address Bar results. r=adw

Beta/Release Uplift Approval Request

• User impact if declined: Part of MR1 design. The Switch to tab chiclet should always be visible now that we removed the badge on the favicon.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Ensure that the Switch to tab chiclet stays visible even if the page has a long title. See comment 0.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple and limited css changes
• String changes made/needed:

Comment 12

[Pascal Chevrel:pascalc]

Comment on attachment 9219150 [details]
Bug 1707839 - Ensure the action text stays visible in Address Bar results. r=adw

Approved for 89 beta 7, thanks.

Comment 13

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/aa8db3d2d88c

Comment 14

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed using Firefox 89 beta 8 and latest Nightly 90.0a1 2021-05-04 across platforms.