Closed Bug 1707957 Opened 9 months ago Closed 9 months ago

Add GTK support for simultaneous light / dark system colors.

Categories

(Core :: Widget: Gtk, defect)

defect

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(2 files)

I thought this was going to be all we needed to fix stuff like bug 1707872 but we still need a bit more work.

Still this will allow us to implement the color-scheme CSS property properly, and it simplifies stuff, so I think it's worth landing what I have.

And add code to use the appropriate variant like we do in macOS with
respect-system-appearance (but this still needs more work as noted in
StaticPrefList.yaml).

Still, it cleans up a bunch, and allows to not depend on the content
process boundary to provide light system colors.

Depends on D113542

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0fb0e3d056f8
Extract both light and dark system colors in GTK. r=stransky
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

It's a relatively minor one (two keyframes are leaked). I built latest
GTK3 from source and it wasn't reproducible locally. I think our GTK
version on automation might be too old and not have this commit:

https://gitlab.gnome.org/GNOME/gtk/-/commit/10fa786dfa718188243935c32deedfa8bec1f208

Or something of that sort.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2f0462c1b2aa
Extract both light and dark system colors in GTK. r=stransky
https://hg.mozilla.org/integration/autoland/rev/a57a18bd5034
Add a valgrind suppression for a GTK leak. r=stransky
Status: REOPENED → RESOLVED
Closed: 9 months ago9 months ago
Resolution: --- → FIXED
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/f9beaf5fb592
Restore two lines in RemoteLookAndFeel which shouldn't have been removed.
Regressions: 1720508
Regressions: 1721359
Regressions: 1722886
No longer regressions: 1720768
You need to log in before you can comment on or make changes to this bug.