1707957 - Add GTK support for simultaneous light / dark system colors.

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

I thought this was going to be all we needed to fix stuff like bug 1707872 but we still need a bit more work.

Still this will allow us to implement the color-scheme CSS property properly, and it simplifies stuff, so I think it's worth landing what I have.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1707957 - Extract both light and dark system colors in GTK. r=stransky

And add code to use the appropriate variant like we do in macOS with
respect-system-appearance (but this still needs more work as noted in
StaticPrefList.yaml).

Still, it cleans up a bunch, and allows to not depend on the content
process boundary to provide light system colors.

Depends on D113542

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0fb0e3d056f8
Extract both light and dark system colors in GTK. r=stransky

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/0fb0e3d056f8

Comment 4

[Iulian Moraru]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/3b6178fd74b1

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1707957 - Add a valgrind suppression for a GTK leak. r=stransky

It's a relatively minor one (two keyframes are leaked). I built latest
GTK3 from source and it wasn't reproducible locally. I think our GTK
version on automation might be too old and not have this commit:

https://gitlab.gnome.org/GNOME/gtk/-/commit/10fa786dfa718188243935c32deedfa8bec1f208

Or something of that sort.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f0462c1b2aa
Extract both light and dark system colors in GTK. r=stransky
https://hg.mozilla.org/integration/autoland/rev/a57a18bd5034
Add a valgrind suppression for a GTK leak. r=stransky

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2f0462c1b2aa
https://hg.mozilla.org/mozilla-central/rev/a57a18bd5034

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9beaf5fb592
Restore two lines in RemoteLookAndFeel which shouldn't have been removed.

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f9beaf5fb592