1707996 - Checkboxes in native windows now look like in-content checkboxes

Status: VERIFIED FIXED

(Toolkit :: Themes, defect, P2)

Description

[Julian Gaibler]

Attachment: oh-no-the-checkbox-is-slightly-off.png

Windows that are supposed to have a native checkbox (download window, import wizard) currently look like in-content checkboxes (see attached picture).

I could only test this on mac, but it could also be an issue on other platforms.

Comment 1

[Martin Balfanz [:mbalfanz]]

Attachment: checkbox-windows.png

The same problem appears on Windows. I assume we want to fix this across all platforms, as it looks a bit out of place.

Comment 2

[Martin Balfanz [:mbalfanz]]

Attachment: Bug 1707996 - change checkboxes in download dialog to native, r?gijs,mconley

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2730ac083f9
change checkboxes in download dialog to native, r=Gijs

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1699889

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/a2730ac083f9

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9218887 [details]
Bug 1707996 - change checkboxes in download dialog to native, r?gijs,mconley

Beta/Release Uplift Approval Request

• User impact if declined: Required for Proton/MR1
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Open a URL that causes the Unknown Content type dialog to appear. Make sure that the checkboxes in the dialog use their native appearance.
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Changes styling to native using an already accepted approach just by changing an attribute with no extra behavior/styling adjustments.
• String changes made/needed: none

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9218887 [details]
Bug 1707996 - change checkboxes in download dialog to native, r?gijs,mconley

Low risk, approved for 89 beta 8, thanks.

Comment 8

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/05391f9733c6

Comment 9

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Nightly build as well as Beta 89.0b9 on Windows, Mac and Ubuntu.