1708209 - Checkboxes in native windows now look like in-content checkboxes

Status: VERIFIED FIXED

(Toolkit :: Themes, defect, P2)

Description

[Martin Balfanz [:mbalfanz]]

Markus pointed out that there are more places where we should show native checkboxes instead of in-content ones.

The places are:

• Clear Recent History dialog
• Page Info -> Permissions panel
• Import Wizard -> Items to Import panel

Comment 1

[Julian Gaibler]

It stands to reason that all checkboxes in native-looking windows are affected by this, right? It feels, and maybe I'm wrong, that this bug should not be addressed by going on a hunt for checkboxes in our UI, but to figure out what code change caused the differentiation between in-content checkboxes and native checkboxes to break. For instance, the drop-down menus and buttons also got updated, but they still look native where they should be.

Comment 2

[Harry Twyford]

I spoke with Martin and I'm going to take this bug. This was probably regressed by bug 1697315. That bug updated all checkboxes but introduced a [native] attribute to be used in exceptional cases. Drop-down menus were also fixed with an à-la-carte approach in bug 1697863, since they were also implemented with a [native] attribute for exceptions.

Comment 3

[Harry Twyford]

Attachment: Bug 1708209 - Use native checkboxes in all native windows. r?Gijs!

This patch also ensures we always use the dedicated preferences sanitize.xhtml in about:preferences.

Comment 4

[Harry Twyford]

[Tracking Requested - why for this release]:

Inconsistent look in Proton checkboxes, making native dialogs feel out of place. Straightforward patch; easy uplift.

I'll request uplift after I verify the fix in Nightly tomorrow.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7057915ac757
Use native checkboxes in all native windows. r=Gijs,preferences-reviewers

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/7057915ac757

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Hey harry, just pinging this bug to remind you to request uplift on it as soon as you can (per comment 4)

Comment 8

[Harry Twyford]

Comment on attachment 9218990 [details]
Bug 1708209 - Use native checkboxes in all native windows. r?Gijs!

Beta/Release Uplift Approval Request

• User impact if declined: Incorrect look in several native-styled windows, like the Clear Recent History window. Proton regression.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please check our various native-styled windows to see that checkboxes are styled like OS checkboxes instead of the checkboxes we use elsewhere in Firefox, such as in about:preferences?
  Some of those windows:

• Clear Recent History
• Page info window (lock icon -> connection status -> More Information)
• Setting desktop wallpaper
• Import Wizard -> Items to Import panel
• Unknown content type download window

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We already support a [native] attribute on checkboxes. This patch just applies that attribute to a few more <checkbox>es.
• String changes made/needed:

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9218990 [details]
Bug 1708209 - Use native checkboxes in all native windows. r?Gijs!

Low risk, approved for 89 beta 8, thanks.

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/4e2dc7bf0619

Comment 11

[Rares Doghi, Desktop QA]

This issue is Verified as fixed in our latest Nightly build as well as in Beta 89.0b9 on Windows, Mac and Ubuntu.

However Harry Twyford also mentioned the : Setting desktop wallpaper modal but I couldnt find any checkboxes on it.

Comment 12

[Harry Twyford]

(In reply to Rares Doghi from comment #11)

However Harry Twyford also mentioned the : Setting desktop wallpaper modal but I couldnt find any checkboxes on it.

Sorry, I was just listing off native-themed windows. If there are no checkboxes on that window, then we're all good.