Closed Bug 1708056 Opened 3 months ago Closed 3 months ago

[win7] Use new upgrade onboarding string for dismissing the dialog

Categories

(Firefox :: Messaging System, enhancement, P2)

enhancement

Tracking

()

VERIFIED FIXED
90 Branch
Tracking Status
firefox89 --- wontfix
firefox90 --- verified

People

(Reporter: Mardak, Assigned: mconley)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [proton-onboarding][priority:2c])

Attachments

(1 file)

Bug 1707141 is landing for uplift without requiring a new string and reuses "Okay" from asrouter.ftl

We should have a dedicated string that is perhaps more exciting as well.

Whiteboard: [proton-onboarding]

The context here is that the user will ONLY see the first screen, yes? No second theme screen. If I understand correctly, then the button string can be: Okay, got it!

Priority: -- → P1
Priority: P1 → P2
Whiteboard: [proton-onboarding] → [proton-onboarding] [priority:2a]

This is a new string that we don't need for MR1 as we found one to reuse. We'll fix it later in the 90 nightly cycle with an actual string to avoid uplift conflicts.

Whiteboard: [proton-onboarding] [priority:2a] → [proton-onboarding][priority:2c]
Assignee: nobody → mconley
Status: NEW → ASSIGNED
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ac0419747894
Add a dedicated primary button string for the upgrade dialog for Win7. r=Mardak,fluent-reviewers
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Blocks: 1710955

I have verified this enhancement and I can confirm that the "Okay, got it!" label is displayed on the primary button of the Upgrade Onboarding modal.

Verified using the latest Firefox Nightly (90.0a1 Build ID - 20210525153449) installed on Windows 7 x64.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.