1707141 - [win7] Remove theme screen from upgrade onboarding

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P2)

Description

[Ed Lee :Mardak]

To avoid bug 1702480, don't have upgrade users pick a theme.

Still pending final designs for what the first screen buttons should be if Firefox is already the default (as normally it shows a button mentioning themes). We can reuse "Okay" cfr-doorhanger-doh-primary-button-2 from newtab/asrouter.ftl as the only button (no "Not now").

Steps indicator should not be shown as there's only one step.

Comment 1

[Ed Lee :Mardak]

Attachment: Bug 1707141 - [win7] Remove theme screen from upgrade onboarding r=pdahiya

Detect old windows version to change content reusing an asrouter "Okay" string for now.

Comment 2

[Ed Lee :Mardak]

Attachment: already default

Comment 3

[Ed Lee :Mardak]

Attachment: not default

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48f696159514
[win7] Remove theme screen from upgrade onboarding r=pdahiya

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/48f696159514

Comment 6

[Ed Lee :Mardak]

Comment on attachment 9218784 [details]
Bug 1707141 - [win7] Remove theme screen from upgrade onboarding r=pdahiya

Beta/Release Uplift Approval Request

• User impact if declined: Upgrading windows 7 users see a theme selection screen making bug 1702480 more common
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Set browser.startup.homepage_override.mstone to "88.0"

2. Make sure browser.startup.upgradeDialog.version is cleared
3. Restart Firefox
4. See windows-7 single screen upgrade dialog

• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Slight behavior change removing the second upgrade screen for windows 7
• String changes made/needed: no new strings by reusing an existing one

Comment 7

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement and I can confirm the following:

• The "Make Firefox my default browser" modal is displayed if the browser is not set as default.
• The "Okay" modal is displayed if the browser is set as default.
• The "Themes" modal is not displayed regardless if the browser is set as default or not.

Verified using the latest Firefox Nightly (90.0a1 - Build ID: 20210428100720) installed on Windows 7 x64.

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9218784 [details]
Bug 1707141 - [win7] Remove theme screen from upgrade onboarding r=pdahiya

Approved for 89 beta 6, thanks.

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/8b80f15acbd1

Comment 10

[Alexandru Michis [:malexandru]]

Backed out changeset 48f696159514 (Bug 1707141) for causing bc failures in browser_browserGlue_upgradeDialog.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/abbe74ed15352292ef6f6b617f7b27ddc1ac27bd
Push with failures, failure log.

Comment 11

[Ed Lee :Mardak]

Attachment: Bug 1707141 - Mock AppConstants during most of upgradeDialog test to avoid win7-specific failures r?pdahiya,andreio

This is a separate test-only followup for easier uplift.

Comment 12

[Ed Lee :Mardak]

I've fixed the win7 bc test failure and relanding to autoland. I'll request uplift of attachment 9219122 [details] test-only fix for beta with r+ and when autoland is green.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ba8c82320e1
[win7] Remove theme screen from upgrade onboarding r=pdahiya

Comment 14

[Iulian Moraru]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/abbe74ed1535

Push from comment 10 will be merged to central later on.

Comment 15

[Punam Dahiya [:pdahiya]]

not sure if switching to P2 is intended, changing to P2 in favor of Proton team bugs tracking

Comment 16

[Ed Lee :Mardak]

Comment on attachment 9219122 [details]
Bug 1707141 - Mock AppConstants during most of upgradeDialog test to avoid win7-specific failures r?pdahiya,andreio

Beta/Release Uplift Approval Request

• User impact if declined: Test-only patch fixing perma orange on mozilla-beta
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The autoland commit at the bottom of this range includes this patch (but not as a separate commit):
  https://treeherder.mozilla.org/jobs?repo=autoland&searchStr=7-32%2Cbc&fromchange=0ba8c82320e1fc66292547bf856292a02ad61313&tochange=e3c38425f7bec2ed038ad035259595adc850b633

Windows 7 opt bc2 and debug bc6 are green and ran the beta-failing browser_browserGlue_upgradeDialog.js

• String changes made/needed: none

Comment 17

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0ba8c82320e1

Comment 18

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9219122 [details]
Bug 1707141 - Mock AppConstants during most of upgradeDialog test to avoid win7-specific failures r?pdahiya,andreio

Approved for beta, thanks.

Comment 19

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/97b0f65d85d7

Comment 20

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement and I can confirm the following:

• The "Make Firefox my default browser" modal is displayed if the browser is not set as default.
• The "Okay" modal is displayed if the browser is set as default.
• The "Themes" modal is not displayed regardless if the browser is set as default or not.

Verified using the latest Firefox Beta (89.0b7 - Build ID: 20210502185943) installed on Windows 7 x64.

Comment 21

[Florin Strugariu [:Bebe]]

== Change summary for alert #29965 (as of Wed, 05 May 2021 04:16:02 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
18%	amazon-search	fnbpaint	android-hw-g5-7-0-arm7-api-16-shippable	warm	905.79 -> 740.12
18%	amazon-search	fcp	android-hw-g5-7-0-arm7-api-16-shippable	warm	875.77 -> 722.00
16%	bbc	SpeedIndex	android-hw-p2-8-0-android-aarch64-shippable-qr	warm webrender	599.67 -> 503.08
16%	amazon-search	FirstVisualChange	android-hw-g5-7-0-arm7-api-16-shippable	warm	1,149.33 -> 965.08
14%	amazon-search	FirstVisualChange	android-hw-p2-8-0-android-aarch64-shippable-qr	warm webrender	496.04 -> 424.75
...	...	...	...	...	...
8%	booking	PerceptualSpeedIndex	android-hw-g5-7-0-arm7-api-16-shippable-qr	warm webrender	2,515.88 -> 2,314.83

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=29965

Comment 22

[Ed Lee :Mardak]

The perf alert should probably be for bug 1697215